March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: scripts/docker-rebuild: add debian-bullseye-jenkins-arm
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31999 ) Change subject: scripts/docker-rebuild: add debian-bullseye-jenkins-arm ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I55bd5869ecd753549b8f2f2822e825623d940acd Gerrit-Change-Number: 31999 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 16:47:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/master-builds: use debian-bullseye-jenkins
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32000 ) Change subject: jobs/master-builds: use debian-bullseye-jenkins ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7d5bc7bb4c1457d4e05fd6e0d27668382c39973a Gerrit-Change-Number: 32000 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 16:46:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: debian-bullseye-jenkins: sync with buster-jenkins
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31997 ) Change subject: debian-bullseye-jenkins: sync with buster-jenkins ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I51925d0ab9e5a779379efab59c381ef12fb60929 Gerrit-Change-Number: 31997 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 16:46:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: debian-bullseye-jenkins-arm: add new container
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31998 ) Change subject: debian-bullseye-jenkins-arm: add new container ...................................................................... Patch Set 1: -Code-Review (1 comment) File debian-bullseye-jenkins-arm/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/31998/comment/b700137e_cb4… PS1, Line 1: UPSTREAM_DISTRO=debian:buster-slim Shouldn't this be bullseye? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8e1741f86ffb8abd658d1e4e0415dfd11fb1a8a1 Gerrit-Change-Number: 31998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 16:45:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: debian-bullseye-jenkins-arm: add new container
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31998 ) Change subject: debian-bullseye-jenkins-arm: add new container ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8e1741f86ffb8abd658d1e4e0415dfd11fb1a8a1 Gerrit-Change-Number: 31998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 16:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/master-builds: use debian-bullseye-jenkins
by osmith 21 Mar '23

21 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32000 ) Change subject: jobs/master-builds: use debian-bullseye-jenkins ...................................................................... jobs/master-builds: use debian-bullseye-jenkins I've verified that all master-builds jobs still work with this change. Related: OS#5949 Depends: docker-playground I51925d0ab9e5a779379efab59c381ef12fb60929 Change-Id: I7d5bc7bb4c1457d4e05fd6e0d27668382c39973a --- M jobs/master-builds.yml 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/00/32000/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 008452a..23e5219 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -63,7 +63,7 @@ -e CCACHE_DIR="/ccache" \ -e PATH="/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" \ -v "$CCACHE_DIR:/ccache" \ - docker_img: '$USER/debian-buster-jenkins' + docker_img: '$USER/debian-bullseye-jenkins' timeout_cmd: '/usr/bin/timeout 30m' cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' trigger: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7d5bc7bb4c1457d4e05fd6e0d27668382c39973a Gerrit-Change-Number: 32000 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: scripts/docker-rebuild: add debian-bullseye-jenkins-arm
by osmith 21 Mar '23

21 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31999 ) Change subject: scripts/docker-rebuild: add debian-bullseye-jenkins-arm ...................................................................... scripts/docker-rebuild: add debian-bullseye-jenkins-arm Prepare to let all master-builds jobs use debian-bullseye instead of debian-buster. Depends: docker-playground I8e1741f86ffb8abd658d1e4e0415dfd11fb1a8a1 Related: OS#5949 Change-Id: I55bd5869ecd753549b8f2f2822e825623d940acd --- M scripts/osmo-ci-docker-rebuild.sh 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/31999/1 diff --git a/scripts/osmo-ci-docker-rebuild.sh b/scripts/osmo-ci-docker-rebuild.sh index 57005ed..ced9ce8 100755 --- a/scripts/osmo-ci-docker-rebuild.sh +++ b/scripts/osmo-ci-docker-rebuild.sh @@ -12,6 +12,7 @@ ;; arm*) docker_images_require \ + "debian-bullseye-jenkins-arm" \ "debian-buster-jenkins-arm" ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I55bd5869ecd753549b8f2f2822e825623d940acd Gerrit-Change-Number: 31999 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in docker-playground[master]: debian-bullseye-jenkins: sync with buster-jenkins
by osmith 21 Mar '23

21 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31997 ) Change subject: debian-bullseye-jenkins: sync with buster-jenkins ...................................................................... debian-bullseye-jenkins: sync with buster-jenkins Prepare to let jenkins master-builds use debian-bullseye-jenkins instead of debian-buster-jenkins. Add almost everything from the buster Dockerfile to the bullseye Dockerfile that is not there, except for: dh-systemd (not available in debian11) Also add python2, as some projects still require it to run tests (OS#5950). Related: OS#5949 Change-Id: I51925d0ab9e5a779379efab59c381ef12fb60929 --- M debian-bullseye-jenkins/Dockerfile 1 file changed, 56 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/31997/1 diff --git a/debian-bullseye-jenkins/Dockerfile b/debian-bullseye-jenkins/Dockerfile index 71ee08c..7c02cbe 100644 --- a/debian-bullseye-jenkins/Dockerfile +++ b/debian-bullseye-jenkins/Dockerfile @@ -12,6 +12,9 @@ # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-fr… ARG DEBIAN_VERSION +# LLVM-embedded-toolchain-for-Arm version +ARG LLVM_VERSION="14.0.0" + # Install apt dependencies (keep in alphabetic order) RUN \ [ "$(arch)" = "x86_64" ] && dpkg --add-architecture i386; \ @@ -27,6 +30,7 @@ bison \ bzip2 \ ca-certificates \ + ccache \ cmake \ coccinelle \ cppcheck \ @@ -43,11 +47,13 @@ gawk \ gcc \ gcc-arm-none-eabi \ + ghostscript \ git \ git-buildpackage \ graphviz \ htop \ inkscape \ + latexmk \ lcov \ libaio-dev \ libasound2-dev \ @@ -82,6 +88,7 @@ libsqlite3-dev \ libssl-dev \ libtalloc-dev \ + libtinfo5 \ libtool \ libusb-1.0-0-dev \ libusb-dev \ @@ -97,6 +104,8 @@ patchelf \ picolibc-arm-none-eabi \ pkg-config \ + python-setuptools \ + python2.7 \ python3 \ python3-gi \ python3-mako \ @@ -114,17 +123,34 @@ sudo \ systemd \ tcpdump \ + tex-gyre \ texinfo \ unzip \ wget \ xsltproc +RUN set -x && \ + [ "$(arch)" = "x86_64" ] || exit 0; \ + wget -q https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/do… && \ + tar -xf LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ + rm LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ + mv LLVMEmbeddedToolchainForArm-${LLVM_VERSION} /opt/llvm-arm && \ + /opt/llvm-arm/bin/clang --version && \ + /opt/llvm-arm/bin/clang --print-targets + # Install pip dependencies (keep in alphabetic order) RUN pip3 install \ - git+https://github.com/podshumok/python-smpplib.git \ - git+https://github.com/eriwen/lcov-to-cobertura-xml.git \ - pydbus \ - pysispm + 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git' \ + 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ + 'git+https://github.com/podshumok/python-smpplib.git' \ + 'pydbus' \ + 'pylint' \ + 'pysispm' \ + 'sphinx' \ + 'sphinxcontrib-napoleon' \ + 'swig' +ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt +RUN pip3 install -r /tmp/pysim_requirements.txt # match the outside user RUN useradd --uid=1000 build @@ -133,6 +159,14 @@ RUN mkdir /build RUN chown build:build /build +# Install osmo-python-tests for python2 (OS#5950) +ARG OSMO_PYTHON2_TESTS_COMMIT=fb4b813d4df62b7b2445bdced961eb1847267eed +ADD http://git.osmocom.org/python/osmo-python-tests/patch/?id=$OSMO_PYTHON2_TES… /tmp/osmo-python-tests2-commit +RUN git clone https://gerrit.osmocom.org/python/osmo-python-tests osmo-python-tests2 && \ + cd osmo-python-tests2 && \ + git checkout $OSMO_PYTHON2_TESTS_COMMIT && \ + python2 setup.py clean build install + # Install osmo-python-tests for python3 ADD http://git.osmocom.org/python/osmo-python-tests/patch /tmp/osmo-python-tests3-commit RUN git clone https://gerrit.osmocom.org/python/osmo-python-tests osmo-python-tests3 && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I51925d0ab9e5a779379efab59c381ef12fb60929 Gerrit-Change-Number: 31997 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in docker-playground[master]: debian-bullseye-jenkins-arm: add new container
by osmith 21 Mar '23

21 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31998 ) Change subject: debian-bullseye-jenkins-arm: add new container ...................................................................... debian-bullseye-jenkins-arm: add new container Add a bullseye based container that can be used instead of debian-buster-jenkins-arm. The master-builds jenkins jobs will attempt to use this jenkins job for the arm builds after setting the main default image from debian-buster-jenkins to debian-bullseye-jenkins. Related: OS#5949 Change-Id: I8e1741f86ffb8abd658d1e4e0415dfd11fb1a8a1 --- A debian-bullseye-jenkins-arm/Dockerfile A debian-bullseye-jenkins-arm/Makefile 2 files changed, 96 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/31998/1 diff --git a/debian-bullseye-jenkins-arm/Dockerfile b/debian-bullseye-jenkins-arm/Dockerfile new file mode 100644 index 0000000..8ba9c49 --- /dev/null +++ b/debian-bullseye-jenkins-arm/Dockerfile @@ -0,0 +1,78 @@ +# Image used to run contrib/jenkins.sh scripts of a few Osmocom projects on +# arm. Keep this image minimal so the rpis don't need forever to build it. +# See master-builds.yml, gerrit-verifications.yml in osmo-ci.git. + +ARG DEBIAN_VERSION=bullseye-slim +ARG REGISTRY=docker.io +FROM ${REGISTRY}/debian:${DEBIAN_VERSION} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" + +# Install apt dependencies (keep in alphabetic order) +RUN \ + DEBIAN_FRONTEND=noninteractive apt-get update && \ + DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + autoconf \ + automake \ + bzip2 \ + ca-certificates \ + ccache \ + g++ \ + gcc \ + git \ + libboost-dev \ + libboost-filesystem-dev \ + libboost-program-options-dev \ + libboost-thread-dev \ + libfftw3-dev \ + libgnutls28-dev \ + libmnl-dev \ + libortp-dev \ + libpcsclite-dev \ + libsctp-dev \ + libtalloc-dev \ + libtool \ + libusb-1.0-0-dev \ + make \ + pkg-config \ + python3-minimal \ + python3-setuptools \ + sdcc \ + stow \ + && \ + apt-get clean + +# match the outside user +RUN useradd --uid=1000 build + +RUN mkdir /build +RUN chown build:build /build + +# Install osmo-python-tests for python3 +ADD http://git.osmocom.org/python/osmo-python-tests/patch /tmp/osmo-python-tests3-commit +RUN git clone https://gerrit.osmocom.org/python/osmo-python-tests osmo-python-tests3 && \ + cd osmo-python-tests3 && \ + python3 setup.py clean build install + +# Install osmo-ci.git/scripts to /usr/local/bin +ADD http://git.osmocom.org/osmo-ci/patch /tmp/osmo-ci-commit +RUN git clone https://gerrit.osmocom.org/osmo-ci osmo-ci && \ + cp -v $(find osmo-ci/scripts \ + -maxdepth 1 \ + -type f ) \ + /usr/local/bin + +# Install packages from Osmocom OBS repositories: +# * osmo-trx: liblimesuite-dev, libuhd-dev +ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" +COPY .common/Release.key /etc/apt/trusted.gpg.d/obs.osmocom.org.asc +RUN echo "deb [signed-by=/etc/apt/trusted.gpg.d/obs.osmocom.org.asc] " \ + $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list +ADD $OSMOCOM_REPO/Release /tmp/Release +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + liblimesuite-dev \ + libuhd-dev \ + && \ + apt-get clean diff --git a/debian-bullseye-jenkins-arm/Makefile b/debian-bullseye-jenkins-arm/Makefile new file mode 100644 index 0000000..ea61ed8 --- /dev/null +++ b/debian-bullseye-jenkins-arm/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:buster-slim +DISTRO=debian-buster-slim +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8e1741f86ffb8abd658d1e4e0415dfd11fb1a8a1 Gerrit-Change-Number: 31998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libasn1c[master]: INTEGER: ignore invalid -Warray-bounds from GCC-10
by osmith 21 Mar '23

21 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libasn1c/+/31995 ) Change subject: INTEGER: ignore invalid -Warray-bounds from GCC-10 ...................................................................... INTEGER: ignore invalid -Warray-bounds from GCC-10 GCC 10.2.1 20210110 from Debian 11 generates an invalid Warray-bounds error. It was fixed in future GCC versions, I verified it with GCC 11.3.0. Ignore the warning, so we can build on Debian 11 with -Werror. Fix for: INTEGER.c: In function ‘asn_int642INTEGER’: INTEGER.c:1340:34: error: array subscript 0 is outside array bounds of ‘int64_t[1]’ {aka ‘long int[1]’} [-Werror=array-bounds] 1340 | for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) | ~~~~~~^~~~~~ INTEGER.c:1296:42: note: while referencing ‘value’ 1296 | asn_int642INTEGER(INTEGER_t *st, int64_t value) { | ~~~~~~~~^~~~~ Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93582 Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 --- M src/INTEGER.c 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/INTEGER.c b/src/INTEGER.c index 042fd75..0da24ad 100644 --- a/src/INTEGER.c +++ b/src/INTEGER.c @@ -1336,9 +1336,16 @@ } break; } +#if __GNUC__ == 10 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; +#if __GNUC__ == 10 +#pragma GCC diagnostic pop +#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; @@ -1391,9 +1398,16 @@ } break; } +#if __GNUC__ == 10 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; +#if __GNUC__ == 10 +#pragma GCC diagnostic pop +#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 Gerrit-Change-Number: 31995 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0