March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: INTEGER: ignore invalid -Warray-bounds from GCC-10
by osmith 21 Mar '23

21 Mar '23

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/31995 ) Change subject: INTEGER: ignore invalid -Warray-bounds from GCC-10 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Did you try moving that += before the loop and see if it improves? Same behavior: ``` INTEGER.c: In function ‘asn_int642INTEGER’: INTEGER.c:1341:8: error: array subscript 0 is outside array bounds of ‘int64_t[1]’ {aka ‘long int[1]’} [-Werror=array-bounds] 1341 | pend1 += add; | ~~~~~~^~~~~~ INTEGER.c:1296:42: note: while referencing ‘value’ 1296 | asn_int642INTEGER(INTEGER_t *st, int64_t value) { | ~~~~~~~~^~~~~ ``` -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 Gerrit-Change-Number: 31995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 15:24:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: INTEGER: ignore invalid -Warray-bounds from GCC-10
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: osmith, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/31995 ) Change subject: INTEGER: ignore invalid -Warray-bounds from GCC-10 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Did you try moving that += before the loop and see if it improves? -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 Gerrit-Change-Number: 31995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 15:13:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: doc: overview: replace section TRAU mapper / E1 sub-channel muxer
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31996 ) Change subject: doc: overview: replace section TRAU mapper / E1 sub-channel muxer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If33589feb80e1b29b4f841b678fe5329b8c06a76 Gerrit-Change-Number: 31996 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 14:32:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: doc: overview: replace section TRAU mapper / E1 sub-channel muxer
by dexter 21 Mar '23

21 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31996 ) Change subject: doc: overview: replace section TRAU mapper / E1 sub-channel muxer ...................................................................... doc: overview: replace section TRAU mapper / E1 sub-channel muxer The manual contains a section about a TRAU mapper / E1 sub-channel muxer. This section seems to be copied from the OsmoNITB manual. In OsmoNITB everything was integrated in one binary, now dealing with TRAU frames is the task of the MGW. Let's remove the section but still leave a word about how Speech traffic is handled/relayed by OsmoBSC. Change-Id: If33589feb80e1b29b4f841b678fe5329b8c06a76 --- M doc/manuals/chapters/overview.adoc 1 file changed, 24 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/31996/1 diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index a27b0bf..aca0c98 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -135,11 +135,13 @@ For more information, see <<net>>, <<bts>> and <<bts-examples>>. -==== TRAU mapper / E1 sub-channel muxer +==== Speech traffic -Unlike classic GSM networks, OsmoBSC does not perform any transcoding. -Rather, a compatible codec is selected for both legs of a call, and -codec frames are passed through transparently. In order to achieve this -with E1 based BTS, OsmoBSC contains a E1 sub-channel de- and -re-multiplexer as well as a TRAU mapper that can map uplink to downlink -frames and vice versa. +OsmoBSC, by itself, does not perform any transcoding or relaying of user plane +speech traffic. This task is handled entirely by a BSC co-located media gateway, +such as OsmoMGW, which will take care of relaying the RTP traffic from the BTS +into the core network. + +In case classic E1 based BTSs are used, OsmoBSC will instruct the MGW to +convert between TRAU frames on the E1 side and RTP frames on the IP based core +network side. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If33589feb80e1b29b4f841b678fe5329b8c06a76 Gerrit-Change-Number: 31996 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libasn1c[master]: INTEGER: ignore invalid -Warray-bounds from GCC-10
by fixeria 21 Mar '23

21 Mar '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/31995 ) Change subject: INTEGER: ignore invalid -Warray-bounds from GCC-10 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 Gerrit-Change-Number: 31995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 13:12:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: INTEGER: ignore invalid -Warray-bounds from GCC-10
by osmith 21 Mar '23

21 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/31995 ) Change subject: INTEGER: ignore invalid -Warray-bounds from GCC-10 ...................................................................... INTEGER: ignore invalid -Warray-bounds from GCC-10 GCC 10.2.1 20210110 from Debian 11 generates an invalid Warray-bounds error. It was fixed in future GCC versions, I verified it with GCC 11.3.0. Ignore the warning, so we can build on Debian 11 with -Werror. Fix for: INTEGER.c: In function ‘asn_int642INTEGER’: INTEGER.c:1340:34: error: array subscript 0 is outside array bounds of ‘int64_t[1]’ {aka ‘long int[1]’} [-Werror=array-bounds] 1340 | for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) | ~~~~~~^~~~~~ INTEGER.c:1296:42: note: while referencing ‘value’ 1296 | asn_int642INTEGER(INTEGER_t *st, int64_t value) { | ~~~~~~~~^~~~~ Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93582 Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 --- M src/INTEGER.c 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/95/31995/1 diff --git a/src/INTEGER.c b/src/INTEGER.c index 042fd75..0da24ad 100644 --- a/src/INTEGER.c +++ b/src/INTEGER.c @@ -1336,9 +1336,16 @@ } break; } +#if __GNUC__ == 10 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; +#if __GNUC__ == 10 +#pragma GCC diagnostic pop +#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; @@ -1391,9 +1398,16 @@ } break; } +#if __GNUC__ == 10 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; +#if __GNUC__ == 10 +#pragma GCC diagnostic pop +#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773 Gerrit-Change-Number: 31995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: contrib/osmo-bts.spec.in: do not depend on libosmogb
by fixeria 21 Mar '23

21 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31992 ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: contrib/osmo-bts.spec.in: do not depend on libosmogb ...................................................................... contrib/osmo-bts.spec.in: do not depend on libosmogb The header file <osmocom/gprs/protocol/gsm_04_60.h> was recently deprecated and moved to <osmocom/gsm/protocol/gsm_44_060.h>, so it's now part of libosmogsn and depending libosmogb is not needed. Change-Id: I823de7ebac2fe5dfddb88d533f1a9419f4a605db Related: libosmocore.git I70cc21bf25a7081070738abacb409ed19094c3b2 Related: OS#5312 --- M TODO-RELEASE M contrib/osmo-bts.spec.in 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 7ac9302..1833716 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmogsm >1.8.0 <osmocom/gsm/protocol/gsm_44_060.h> added diff --git a/contrib/osmo-bts.spec.in b/contrib/osmo-bts.spec.in index 83a6c71..afa0b31 100644 --- a/contrib/osmo-bts.spec.in +++ b/contrib/osmo-bts.spec.in @@ -36,8 +36,6 @@ BuildRequires: pkgconfig(libosmoabis) >= 1.4.0 BuildRequires: pkgconfig(libosmotrau) >= 1.4.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.3.0 -### FIXME: DependencyHACK to include osmocom/gprs/protocol/gsm_04_60.h -BuildRequires: pkgconfig(libosmogb) %{?systemd_requires} %description -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I823de7ebac2fe5dfddb88d533f1a9419f4a605db Gerrit-Change-Number: 31992 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: contrib/osmo-bts.spec.in: do not depend on libosmogb
by osmith 21 Mar '23

21 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31992 ) Change subject: contrib/osmo-bts.spec.in: do not depend on libosmogb ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I823de7ebac2fe5dfddb88d533f1a9419f4a605db Gerrit-Change-Number: 31992 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 12:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: lc15bts.h: add missing extern keyword
by osmith 21 Mar '23

21 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31994 ) Change subject: lc15bts.h: add missing extern keyword ...................................................................... lc15bts.h: add missing extern keyword Fix linker errors with ld from binutils 2.35.2 in Debian 11: /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x100): multiple definition of `lc15bts_l1prim_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x80): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x2a0): multiple definition of `lc15bts_sysprim_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x220): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x420): multiple definition of `lc15bts_l1sapi_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x3a0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x5a0): multiple definition of `lc15bts_l1status_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x520): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x760): multiple definition of `lc15bts_tracef_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x6e0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0x940): multiple definition of `lc15bts_tracef_docs'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x8c0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0xb20): multiple definition of `lc15bts_tch_pl_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xaa0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0xc20): multiple definition of `lc15bts_clksrc_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xba0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0xcc0): multiple definition of `lc15bts_dir_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xc40): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15_l1_hw.o:(.rodata+0xd20): multiple definition of `pdch_msu_size'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xca0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x0): multiple definition of `lc15bts_l1prim_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x80): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x1a0): multiple definition of `lc15bts_sysprim_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x220): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x320): multiple definition of `lc15bts_l1sapi_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x3a0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x4a0): multiple definition of `lc15bts_l1status_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x520): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x660): multiple definition of `lc15bts_tracef_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x6e0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0x840): multiple definition of `lc15bts_tracef_docs'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0x8c0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0xa20): multiple definition of `lc15bts_tch_pl_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xaa0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.rodata+0x820): multiple definition of `lc15bts_clksrc_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xba0): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.data.rel.ro.local+0xb20): multiple definition of `lc15bts_dir_names'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xc40): first defined here /usr/bin/ld: osmo-bts-litecell15/lc15bts.o:(.rodata+0x8e0): multiple definition of `pdch_msu_size'; osmo-bts-litecell15/lc15_l1_if.o:(.rodata+0xca0): first defined here Change-Id: I33c061e79536a6e9ea7289a245af996e8d17c6ce --- M src/osmo-bts-litecell15/lc15bts.h 1 file changed, 42 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bts-litecell15/lc15bts.h b/src/osmo-bts-litecell15/lc15bts.h index 4c40db0..31ca923 100644 --- a/src/osmo-bts-litecell15/lc15bts.h +++ b/src/osmo-bts-litecell15/lc15bts.h @@ -23,24 +23,24 @@ }; enum l1prim_type lc15bts_get_l1prim_type(GsmL1_PrimId_t id); -const struct value_string lc15bts_l1prim_names[GsmL1_PrimId_NUM+1]; +extern const struct value_string lc15bts_l1prim_names[GsmL1_PrimId_NUM+1]; GsmL1_PrimId_t lc15bts_get_l1prim_conf(GsmL1_PrimId_t id); enum l1prim_type lc15bts_get_sysprim_type(Litecell15_PrimId_t id); -const struct value_string lc15bts_sysprim_names[Litecell15_PrimId_NUM+1]; +extern const struct value_string lc15bts_sysprim_names[Litecell15_PrimId_NUM+1]; Litecell15_PrimId_t lc15bts_get_sysprim_conf(Litecell15_PrimId_t id); -const struct value_string lc15bts_l1sapi_names[GsmL1_Sapi_NUM+1]; -const struct value_string lc15bts_l1status_names[GSML1_STATUS_NUM+1]; +extern const struct value_string lc15bts_l1sapi_names[GsmL1_Sapi_NUM+1]; +extern const struct value_string lc15bts_l1status_names[GSML1_STATUS_NUM+1]; -const struct value_string lc15bts_tracef_names[29]; -const struct value_string lc15bts_tracef_docs[29]; +extern const struct value_string lc15bts_tracef_names[29]; +extern const struct value_string lc15bts_tracef_docs[29]; -const struct value_string lc15bts_tch_pl_names[15]; +extern const struct value_string lc15bts_tch_pl_names[15]; -const struct value_string lc15bts_clksrc_names[10]; +extern const struct value_string lc15bts_clksrc_names[10]; -const struct value_string lc15bts_dir_names[6]; +extern const struct value_string lc15bts_dir_names[6]; enum pdch_cs { PDCH_CS_1, @@ -59,6 +59,6 @@ _NUM_PDCH_CS }; -const uint8_t pdch_msu_size[_NUM_PDCH_CS]; +extern const uint8_t pdch_msu_size[_NUM_PDCH_CS]; #endif /* LC15BTS_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I33c061e79536a6e9ea7289a245af996e8d17c6ce Gerrit-Change-Number: 31994 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: contrib/osmo-bts.spec.in: do not depend on libosmogb
by pespin 21 Mar '23

21 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31992 ) Change subject: contrib/osmo-bts.spec.in: do not depend on libosmogb ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I823de7ebac2fe5dfddb88d533f1a9419f4a605db Gerrit-Change-Number: 31992 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 12:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0