February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: tests/db/db_test.err: adjust to XOR-3G rename

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31458 ) Change subject: tests/db/db_test.err: adjust to XOR-3G rename ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Important fix, as without tests passing, the osmo-hlr package doesn't build, causing an inconsistent repository state and all sorts of failures on jobs using these packages. Merging it now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I68878d24340659f888e5e348b937161cffbd54e2 Gerrit-Change-Number: 31458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Feb 2023 08:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I wonder whether this patch still makes sense. […] Indeed, these can be internal BTS flags. Is there still a need to report them to the BSC? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 07:32:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[master]: tests/db/db_test.err: adjust to XOR-3G rename

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31458 ) Change subject: tests/db/db_test.err: adjust to XOR-3G rename ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I68878d24340659f888e5e348b937161cffbd54e2 Gerrit-Change-Number: 31458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Feb 2023 07:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: add design charts for new context map FSMs

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 ) Change subject: add design charts for new context map FSMs ...................................................................... Patch Set 3: (1 comment) File doc/charts/hnbgw_context_map_fsm.dot: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430/comment/f451311b_44981400 PS2, Line 2: rankdir=TB > Extra indentation in this block like you did in other files may be welcome. that would mean to indent basically all of the file, i'd rather keep the bulk unindented -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I661bf65d79972a732c52732934095e8bfcd99694 Gerrit-Change-Number: 31430 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 01:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp_sap_up(): ignore PCSTATE.ind

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 ) Change subject: sccp_sap_up(): ignore PCSTATE.ind ...................................................................... Patch Set 6: (1 comment) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429/comment/fc684738_dcf1b087 PS4, Line 434: LOGP(DMAIN, LOGL_DEBUG, "Ignoring: SCCP USER SAP: %s\n", osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I547387a5cc14ccb506be04ac785e6807fc4e6a96 Gerrit-Change-Number: 31429 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 01:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp_sap_up(): ignore PCSTATE.ind

by neels

Attention is currently required from: neels, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 to look at the new patch set (#6). Change subject: sccp_sap_up(): ignore PCSTATE.ind ...................................................................... sccp_sap_up(): ignore PCSTATE.ind Silence the error log about "unknown" PCSTATE prim. Todo / coming up: instead of ignoring, detect a Destination Unavailable from prim->u.pcstate and disconnect all conns with that particular CN link. Depends: libosmo-sccp If381f537ab91af1feef7f0e51921217f27e18e6a Change-Id: I547387a5cc14ccb506be04ac785e6807fc4e6a96 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_cn.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/29/31429/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I547387a5cc14ccb506be04ac785e6807fc4e6a96 Gerrit-Change-Number: 31429 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: log tweak

by neels

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31428 ) Change subject: log tweak ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > The procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9.1.x. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib6f8c46355d4748089e59c80fc1c8c736c887a26 Gerrit-Change-Number: 31428 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Feb 2023 01:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: drop stray backslash

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31425 ) Change subject: cosmetic: drop stray backslash ...................................................................... cosmetic: drop stray backslash Change-Id: I311b62ff393c6520d72fc6aee21d86723487133f --- M include/osmocom/hnbgw/context_map.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index a8d1f97..1342da5 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -8,7 +8,7 @@ SUBSYS, LEVEL, "RUA-%u %s: " FMT, \ (HNB_CTX_MAP) ? (HNB_CTX_MAP)->rua_ctx_id : 0, \ (HNB_CTX_MAP) ? ((HNB_CTX_MAP)->is_ps ? "PS" : "CS") : "NULL", \ - ##ARGS) \ + ##ARGS) enum hnbgw_context_map_state { MAP_S_NULL, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I311b62ff393c6520d72fc6aee21d86723487133f Gerrit-Change-Number: 31425 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: drop obsolete fixme comment

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31426 ) Change subject: drop obsolete fixme comment ...................................................................... drop obsolete fixme comment msgb will be freed by osmo_stream_srv_send(), called via hnbgw_rua_tx(). Change-Id: If35f4cedf6f37be797dcd48e816461d3b1d9db54 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 07b78b3..2160694 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -156,8 +156,6 @@ ies.ranaP_Message.size = len; } - /* FIXME: msgb_free(msg)? ownership not yet clear */ - memset(&out, 0, sizeof(out)); rc = rua_encode_disconnecties(&out, &ies); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35f4cedf6f37be797dcd48e816461d3b1d9db54 Gerrit-Change-Number: 31426 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: various comment tweaks

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31427 ) Change subject: various comment tweaks ...................................................................... various comment tweaks Change-Id: Ie40aa672948062282c566c90300f6e96963e05ec --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/mgw_fsm.c M src/osmo-hnbgw/ps_rab_ass_fsm.c 4 files changed, 26 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index 1342da5..3a145b6 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -47,17 +47,22 @@ enum hnbgw_context_map_state state; - /* FSM instance for the MGW */ + /* FSM instance for the MGW, handles the async MGCP communication necessary to intercept CS RAB Assignment and + * redirect the RTP via the MGW. */ struct osmo_fsm_inst *mgw_fi; - /* FSMs handling RANAP RAB assignments for PS. list of struct ps_rab_ass. For PS RAB Assignment, each Request - * and gets one ps_rab_ass FSM and each Response gets one ps_rab_ass FSM. The reason is that theoretically, each - * such message can contain any number and any combination of RAB IDs, and Request and Response don't - * necessarily match the RAB IDs contained. In practice I only ever see a single RAB matching in Request and - * Response, but we cannot rely on that to always be true. The state of each RAB's PFCP negotiation is kept - * separately in the list hnbgw_context_map.ps_rabs, and as soon as all RABs appearing in a PS RAB Assignment - * message have completed their PFCP setup, we can replace the GTP info for the RAB IDs and forward the RAB - * Assignment Request to HNB / the RAB Assignment Response to CN. */ + /* FSMs handling RANAP RAB assignments for PS, list of struct ps_rab_ass. They handle the async PFCP + * communication necessary to intercept PS RAB Assignment and redirect the GTP via the UPF. + * + * For PS RAB Assignment, each Request gets one ps_rab_ass FSM and each Response gets one ps_rab_ass FSM. + * The reason is that theoretically, each such message can contain any number and any combination of RAB IDs, + * and Request and Response don't necessarily match the RAB IDs contained. In practice I only ever see a single + * RAB matching in Request and Response, but we cannot rely on that to always be true. + * + * The state of each RAB's PFCP negotiation is kept separately in the list ps_rabs, and as soon as all RABs + * appearing in a PS RAB Assignment message have completed their PFCP setup, we can replace the GTP info for the + * RAB IDs and forward the RAB Assignment Request to HNB / the RAB Assignment Response to CN. + */ struct llist_head ps_rab_ass; /* All PS RABs and their GTP tunnel mappings. list of struct ps_rab. Each ps_rab FSM handles the PFCP diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c index 39b9b50..96365fb 100644 --- a/src/osmo-hnbgw/context_map.c +++ b/src/osmo-hnbgw/context_map.c @@ -111,7 +111,7 @@ LOGHNB(hnb, DMAIN, LOGL_INFO, "Creating new Mapping RUA CTX %p/%u <-> SCU Conn ID %p/%u\n", hnb, rua_ctx_id, cn_if_new, new_scu_conn_id); - /* alloate a new map entry */ + /* allocate a new map entry. */ map = talloc_zero(hnb, struct hnbgw_context_map); map->state = MAP_S_NULL; map->cn_link = cn_if_new; diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 764e9a7..fe1e227 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -780,7 +780,7 @@ } /*! Release the FSM and clear its associated RTP streams. - * \ptmap[in] map hanbgw context map that is responsible for this call. + * \ptmap[in] map hnbgw context map that is responsible for this call. * \returns 0 on success; negative on error. */ int mgw_fsm_release(struct hnbgw_context_map *map) { diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index e676c2c..e232de8 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -620,6 +620,7 @@ rab->resp_fi = NULL; } + /* remove from map->ps_rab_ass */ llist_del(&rab_ass->entry); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie40aa672948062282c566c90300f6e96963e05ec Gerrit-Change-Number: 31427 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023