February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[osmith/1.6.1]: Run struct_endianness.py

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31469 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31469 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 09:36:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: Run struct_endianness.py

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31469 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: CI passes with the next commit that adjusts the tests -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31469 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 09:29:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: Run struct_endianness.py

by osmith

Attention is currently required from: osmith. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31469 ) Change subject: Run struct_endianness.py ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31469 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: Rename OSMO_AUTH_ALG_XOR to OSMO_AUTH_ALG_XOR_3G

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31453 ) Change subject: Rename OSMO_AUTH_ALG_XOR to OSMO_AUTH_ALG_XOR_3G ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: osmo-hlr tests didn't pass anymore with this change. Fixed for master: * https://gerrit.osmocom.org/c/osmo-hlr/+/31458 Making the latest release compatible with this change: * https://gerrit.osmocom.org/q/topic:osmo-hlr-1.6.1 Do you want me to make new 1.5.0 and 1.4.0 version as well? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I446e54d0ddf4a18c46ee022b1249af73552e3ce1 Gerrit-Change-Number: 31453 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 09:28:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: Bump version: 1.6.0.2-42f8 → 1.6.1

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/31468 to look at the new patch set (#2). Change subject: Bump version: 1.6.0.2-42f8 → 1.6.1 ...................................................................... Bump version: 1.6.0.2-42f8 → 1.6.1 Change-Id: I6a74dccada51f13c6c3a9f3fe08c1df2e9c2811b --- M debian/changelog 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/68/31468/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I6a74dccada51f13c6c3a9f3fe08c1df2e9c2811b Gerrit-Change-Number: 31468 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: Run struct_endianness.py

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31469 ) Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 (cherry picked from commit 62e5c1b2c77f150de3b6fab37d84a65ee30b3449) --- M include/osmocom/mslookup/mdns_rfc.h 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/69/31469/1 diff --git a/include/osmocom/mslookup/mdns_rfc.h b/include/osmocom/mslookup/mdns_rfc.h index 364b4d3..28ed1a2 100644 --- a/include/osmocom/mslookup/mdns_rfc.h +++ b/include/osmocom/mslookup/mdns_rfc.h @@ -71,7 +71,7 @@ uint16_t nscount; /* Number of authority records */ uint16_t arcount; /* Number of additional records */ #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint16_t id; uint8_t qr:1, opcode:4, aa:1, tc:1, rd:1; uint8_t ra:1, z:3, rcode:4; -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31469 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: Bump version: 1.6.0.1-785f → 1.6.1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31468 ) Change subject: Bump version: 1.6.0.1-785f → 1.6.1 ...................................................................... Bump version: 1.6.0.1-785f → 1.6.1 Change-Id: I6a74dccada51f13c6c3a9f3fe08c1df2e9c2811b --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/68/31468/1 diff --git a/debian/changelog b/debian/changelog index 89b5aed..3828ae0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-hlr (1.6.1) unstable; urgency=medium + + * tests: adjust to XOR-3G rename in libosmocore + + -- Oliver Smith <osmith(a)sysmocom.de> Thu, 23 Feb 2023 10:12:11 +0100 + osmo-hlr (1.6.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I6a74dccada51f13c6c3a9f3fe08c1df2e9c2811b Gerrit-Change-Number: 31468 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.6.1]: tests: adjust to XOR-3G rename in libosmocore

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31467 ) Change subject: tests: adjust to XOR-3G rename in libosmocore ...................................................................... tests: adjust to XOR-3G rename in libosmocore Fix forward compatibility to current master of libosmocore / future versions where the value_string for OSMO_AUTH_ALG_XOR has been changed. Adjust the tests so they pass with both the old and the new version. Related: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 Change-Id: I391b1a9b52e1969172aba9d4a1cc5792fc077fe1 --- M tests/test_subscriber.ctrl M tests/test_subscriber.vty M tests/testsuite.at 3 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/67/31467/1 diff --git a/tests/test_subscriber.ctrl b/tests/test_subscriber.ctrl index ff26d4c..e827662 100644 --- a/tests/test_subscriber.ctrl +++ b/tests/test_subscriber.ctrl @@ -677,9 +677,6 @@ SET 113 subscriber.by-imsi-901991234567891.aud2g xor,c01ffedc1cadaeac1d1f1edacac1ab0a SET_REPLY 113 subscriber.by-imsi-901991234567891.aud2g OK -GET 114 subscriber.by-imsi-901991234567891.aud2g -GET_REPLY 114 subscriber.by-imsi-901991234567891.aud2g XOR,c01ffedc1cadaeac1d1f1edacac1ab0a - SET 115 subscriber.by-imsi-901991234567891.aud2g none SET_REPLY 115 subscriber.by-imsi-901991234567891.aud2g OK diff --git a/tests/test_subscriber.vty b/tests/test_subscriber.vty index fe7499c..cfbcd8b 100644 --- a/tests/test_subscriber.vty +++ b/tests/test_subscriber.vty @@ -160,7 +160,7 @@ ID: 101 IMSI: 123456789023000 MSISDN: 423 - 2G auth: XOR +... KI=deaf0ff1ced0d0dabbedd1ced1cef00d OsmoHLR# subscriber imsi 123456789023000 update aud2g comp128v1 ki BeefedCafeFaceAcedAddedDecadeFee diff --git a/tests/testsuite.at b/tests/testsuite.at index 65f90b4..dde7d8b 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -27,7 +27,12 @@ cat $abs_srcdir/db/db_test.ok > expout cat $abs_srcdir/db/db_test.err > experr sqlite3 db_test.db < $abs_top_srcdir/sql/hlr.sql -AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [experr]) + +# Compatibility with libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 +$abs_top_builddir/tests/db/db_test >out 2>err +sed -i "s/XOR-3G,/XOR,/g" err + +AT_CHECK([cat out; cat err >&2], [], [expout], [experr]) AT_CLEANUP # AT_SKIP_IF: disable for old sqlite versions, because the way we dump tables in the test doesn't work with it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.6.1 Gerrit-Change-Id: I391b1a9b52e1969172aba9d4a1cc5792fc077fe1 Gerrit-Change-Number: 31467 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in pysim[master]: docs: Document the file-specific commands for ADF.USIM/EF.EST

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31466 ) Change subject: docs: Document the file-specific commands for ADF.USIM/EF.EST ...................................................................... docs: Document the file-specific commands for ADF.USIM/EF.EST Change-Id: Iddba9f25ba957f03ca25628a7742fe40fd79c030 --- M docs/shell.rst 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/31466/1 diff --git a/docs/shell.rst b/docs/shell.rst index 801d2f4..c1f37af 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -555,6 +555,14 @@ ~~~~~~~~~~~~~~~~~~~~~~~~ Read + decode all EF.ARR records in flattened, human-friendly form. +ADF.USIM/EF.EST: est_service_enable +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Enables a single service in EF.EST. Requires service number as argument. + +ADF.USIM/EF.EST: est_service_disable +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Disables a single service in EF.EST. Requires service number as argument. + EF.IMSI: update_imsi_plmn ~~~~~~~~~~~~~~~~~~~~~~~~~ Change the PLMN part (MCC+MNC) of the IMSI. Requires a single argument consisting of 5/6 digits of -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iddba9f25ba957f03ca25628a7742fe40fd79c030 Gerrit-Change-Number: 31466 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in pysim[master]: 31.102: EF.EST enables/disables services; name commands accordingly

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31465 ) Change subject: 31.102: EF.EST enables/disables services; name commands accordingly ...................................................................... 31.102: EF.EST enables/disables services; name commands accordingly EF.EST is the *enabled* services table. Let's call the shell commands enable and disable, rather than activate/deactivate. Change-Id: Iacbdab42bc08e2be38ad7233d903fa7cda0d95b6 --- M pySim/ts_31_102.py 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/31465/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 3edc6e3..dc2a4d8 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -749,12 +749,12 @@ def __init__(self): super().__init__() - def do_est_service_activate(self, arg): - """Activate a service within EF.UST""" + def do_est_service_enable(self, arg): + """Enable a service within EF.UST""" self._cmd.card.update_est(int(arg), 1) - def do_est_service_deactivate(self, arg): - """Deactivate a service within EF.UST""" + def do_est_service_disable(self, arg): + """Disable a service within EF.UST""" self._cmd.card.update_est(int(arg), 0) # TS 31.102 Section 4.2.48 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iacbdab42bc08e2be38ad7233d903fa7cda0d95b6 Gerrit-Change-Number: 31465 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023