February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 7: (4 comments) File src/libosmo-mgcp/mgcp_network.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3938): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/57a639d9_07e6f831 PS7, Line 704: switch(msgb_length(msg)) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3938): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/823be48c_18a84724 PS7, Line 704: switch(msgb_length(msg)) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3938): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/0fa5952d_5db58e73 PS7, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3938): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/da58ea4d_8e1fb81c PS7, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 14:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 7: (3 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/fa54e85d_492da4ca PS6, Line 704: if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr)) { > Not criticial, but you could even have a switch case here: switch(msgb_length(msg)) Done https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/867cbdb8_cbaab96b PS6, Line 705: /* Abort early in case the input format (TS 101318) already > Abort sounds like failing here. "Do nothing in case" would be far more informative imho. Done https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/793d9ef9_edf5f9e7 PS6, Line 1250: } else if ((rtp_end->rfc5993_hr_convert || > Sounds like we want to have some function and put all this conditions together? It starts to be diff […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 14:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format

by dexter

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 to look at the new patch set (#7). Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... mgcp_sdp: add fmtp string to define HR GSM RTP format There are two different RTP HR GSM formats defined (TS 101.318 and RFC5993). Lets add an fmtp parameter In order to select between the two formats (and convert if necessary) via MGCP/SDP. Unfortunately there is no official fmtp string defined, so we have to define an osmocom specific string. Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Related: OS#5688 --- M include/osmocom/mgcp/mgcp_common.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_sdp.c 4 files changed, 103 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/14/31214/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_pcu_ericsson: add comment about uplink blocks

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31475 ) Change subject: trau_pcu_ericsson: add comment about uplink blocks ...................................................................... Patch Set 1: (2 comments) File include/osmocom/trau/trau_pcu_ericsson.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3936): https://gerrit.osmocom.org/c/libosmo-abis/+/31475/comment/d5445862_1afb9af8 PS1, Line 286: * RBS only supported CS1 and CS2 on 16K I.460 subslots. CS1 and CS2 were not supported due to the bandwith limitation 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3936): https://gerrit.osmocom.org/c/libosmo-abis/+/31475/comment/2013481a_9214623e PS1, Line 287: * of the 16k subslots. In order to support higher bandwith, in particular EDGE a new CCU implementation was 'bandwith' may be misspelled - perhaps 'bandwidth'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35b9a35c9b583378559daa400e105537338ee68a Gerrit-Change-Number: 31475 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 23 Feb 2023 11:42:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_pcu_ericsson: add comment about uplink blocks

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31475 ) Change subject: trau_pcu_ericsson: add comment about uplink blocks ...................................................................... trau_pcu_ericsson: add comment about uplink blocks While testing each uplink block (CS1-C4, MCS1-MCS9) indvidually some specific behaviour was observed. Related: OS#5198 Change-Id: I35b9a35c9b583378559daa400e105537338ee68a --- M include/osmocom/trau/trau_pcu_ericsson.h 1 file changed, 37 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/75/31475/1 diff --git a/include/osmocom/trau/trau_pcu_ericsson.h b/include/osmocom/trau/trau_pcu_ericsson.h index 03a446f..e04da0a 100644 --- a/include/osmocom/trau/trau_pcu_ericsson.h +++ b/include/osmocom/trau/trau_pcu_ericsson.h @@ -277,4 +277,27 @@ * value back. The timing adjustment is performed immediately within the same frame by appending or removing bits * at the end. This delays or advances the timing of the subsequent frame. * - * The procedure is very similar to the one described in: GSM 08.60, section 4.6.1.2 */ + * The procedure is very similar to the one described in: GSM 08.60, section 4.6.1.2 + * + * + * Usable coding schemes in uplink + * =============================== + * To understand which coding schemes are usable one must understand that the first CCU implementation for Ericssson + * RBS only supported CS1 and CS2 on 16K I.460 subslots. CS1 and CS2 were not supported due to the bandwith limitation + * of the 16k subslots. In order to support higher bandwith, in particular EDGE a new CCU implementation was + * introduced. This newer implementation uses full 64K E1 timeslots and has full EDGE support MCS1-MCS9. + * + * Interestingly though, the newer CCU implementation seems to lack support for CS3-CS4. At least it was not possible + * To receive any CS3 or CS4 blocks from the CCU, while CS1 and CS2 work fine. In case the PCU is instructed to use + * CS3 or CS4 in downlink nothing is received. Since the CCU also demoulates noise and even sends the demodulation + * results back to the PCU there should have been at least some invalid CS3 and CS4 blocks in the demodulation results + * from time to time but also here no CS3 or CS4 blocks were observed. This leads to the vague assumption that the GPRS + * part of the CCU presumably never got updated and only EDGE support was added. + * + * It was also discovered that CS1 and CS2 only appear when the CCU is instructed to receive GMSK only + * (ER_UL_CHMOD_NB_GMSK). When the CCU is instructed to receive GMSK and PSK (ER_UL_CHMOD_NB_UNKN) CS2 does not appear. + * EGPRS related blocks (CS_OR_HDR_HDR1-3) appear in both situations. Since CS1 also plays a role in EGPRS it might be + * that the CCU is filtering non EDGE related blocks when ER_UL_CHMOD_NB_UNKN is used. + * + * The observations above were made with an RRUS 02 B3 + */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35b9a35c9b583378559daa400e105537338ee68a Gerrit-Change-Number: 31475 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.5.1]: Run struct_endianness.py

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31471 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.5.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31471 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 11:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.5.1]: Run struct_endianness.py

by osmith

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31471 ) Change subject: Run struct_endianness.py ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.5.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31471 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.5.1]: Run struct_endianness.py

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31471 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: CI failure is expected, passes in next commit where tests are adjusted -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.5.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31471 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 11:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: build-old-tags: tags_to_ignore: add osmo-hlr

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31474 ) Change subject: build-old-tags: tags_to_ignore: add osmo-hlr ...................................................................... build-old-tags: tags_to_ignore: add osmo-hlr Add the osmo-hlr releases where tests are not foward-compatible to the related libosmocore change. Fixup releases 1.6.1 and 1.5.1 have been made that are foward compatible. Related: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 Change-Id: Ia772c9e823e494fdfce179da58735d3e6cee8e95 --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/31474/1 diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index b6e6138..5f0d04d 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -68,6 +68,11 @@ echo "1.2.0" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc echo "1.2.1" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc ;; + osmo-hlr) + echo "1.4.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + echo "1.5.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + echo "1.6.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + ;; osmo-mgw) echo "1.3.0" # testsuite echo "1.4.0" # testsuite -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia772c9e823e494fdfce179da58735d3e6cee8e95 Gerrit-Change-Number: 31474 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-hlr[osmith/1.5.1]: Run struct_endianness.py

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31471 ) Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 (cherry picked from commit 62e5c1b2c77f150de3b6fab37d84a65ee30b3449) --- M include/osmocom/mslookup/mdns_rfc.h 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/71/31471/1 diff --git a/include/osmocom/mslookup/mdns_rfc.h b/include/osmocom/mslookup/mdns_rfc.h index 9d6be5a..320bd68 100644 --- a/include/osmocom/mslookup/mdns_rfc.h +++ b/include/osmocom/mslookup/mdns_rfc.h @@ -71,7 +71,7 @@ uint16_t nscount; /* Number of authority records */ uint16_t arcount; /* Number of additional records */ #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint16_t id; uint8_t qr:1, opcode:4, aa:1, tc:1, rd:1; uint8_t ra:1, z:3, rcode:4; -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.5.1 Gerrit-Change-Id: I4294a18871214b70cef267fcaaaaada42cb61bf9 Gerrit-Change-Number: 31471 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023