February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: i460_mux: add define constant for maximum number of subchannels

by daniel

Attention is currently required from: dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31456 ) Change subject: i460_mux: add define constant for maximum number of subchannels ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3a3782927c7dcbc873223d56129f291c04fee26 Gerrit-Change-Number: 31456 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:39:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm: add missing features to osmo_bts_features_names[]

by dexter

Attention is currently required from: Max, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31488 ) Change subject: gsm: add missing features to osmo_bts_features_names[] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Gerrit-Change-Number: 31488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: Max <suraev(a)alumni.ntnu.no> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:38:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm: add missing features to osmo_bts_features_names[]

by msuraev

Attention is currently required from: Max, fixeria, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31488 ) Change subject: gsm: add missing features to osmo_bts_features_names[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Gerrit-Change-Number: 31488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: Max <suraev(a)alumni.ntnu.no> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in libosmo-abis[master]: trau_pcu_ericsson: add testvectors for MCS1-MCS8

by dexter

Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 ) Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ...................................................................... Patch Set 2: (1 comment) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/8ccd2b97_24bc8c7a PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav); > That's a lot of duplicated code. […] I just thought that this wouldn't matter since its just a unit test, but if you think that it is necessary to change it, I will change it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7e7e35930a373c9db74faef24f6c404eb5516278 Gerrit-Change-Number: 31454 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:36:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: build-old-tags: tags_to_ignore: add osmo-hlr

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31474 ) Change subject: build-old-tags: tags_to_ignore: add osmo-hlr ...................................................................... build-old-tags: tags_to_ignore: add osmo-hlr Add the osmo-hlr releases where tests are not foward-compatible to the related libosmocore change. Fixup releases 1.6.1 and 1.5.1 have been made that are foward compatible. Related: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 Change-Id: Ia772c9e823e494fdfce179da58735d3e6cee8e95 --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index b6e6138..5f0d04d 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -68,6 +68,11 @@ echo "1.2.0" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc echo "1.2.1" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc ;; + osmo-hlr) + echo "1.4.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + echo "1.5.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + echo "1.6.0" # testsuite: libosmocore I446e54d0ddf4a18c46ee022b1249af73552e3ce1 + ;; osmo-mgw) echo "1.3.0" # testsuite echo "1.4.0" # testsuite -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia772c9e823e494fdfce179da58735d3e6cee8e95 Gerrit-Change-Number: 31474 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: build-old-tags: tags_to_ignore: add osmo-hlr

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31474 ) Change subject: build-old-tags: tags_to_ignore: add osmo-hlr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia772c9e823e494fdfce179da58735d3e6cee8e95 Gerrit-Change-Number: 31474 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by fixeria

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/fbb63162_597ddab9 PS4, Line 44: osmo_bts_features_descs You also need to update this array. https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/93f614ca_9e7e164f PS4, Line 52: osmo_bts_features_names You also need to update this array. Looks like it's a common problem, see also: https://gerrit.osmocom.org/c/libosmocore/+/31488 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:29:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm: add missing features to osmo_bts_features_names[]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31488 ) Change subject: gsm: add missing features to osmo_bts_features_names[] ...................................................................... gsm: add missing features to osmo_bts_features_names[] Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Fixes: 812dfbf3a756088ef8ae083044c690783ef84067 --- M src/gsm/bts_features.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/31488/1 diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 1cc3c26..1e041c7 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -82,5 +82,7 @@ { BTS_FEAT_DYN_TS_SDCCH8, "DYN_TS_SDCCH8" }, { BTS_FEAT_ACCH_TEMP_OVP, "ACCH_TEMP_OVP" }, { BTS_FEAT_OSMUX, "OSMUX" }, + { BTS_FEAT_VBS, "VBS" }, + { BTS_FEAT_VGCS, "VGCS" }, {} }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Gerrit-Change-Number: 31488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_pcu_ericsson_test: fix comment, CS2 blocks are not CRC protected

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31470 ) Change subject: trau_pcu_ericsson_test: fix comment, CS2 blocks are not CRC protected ...................................................................... trau_pcu_ericsson_test: fix comment, CS2 blocks are not CRC protected Change-Id: Ifeed7bc961266e0fcfb1a837257b83fca2a69da1 --- M tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c index 6c28269..60c7b0f 100644 --- a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c +++ b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c @@ -1190,7 +1190,7 @@ * the TRAU frame. */ }; - /* TRAU frame with valid CS2 block and correct CRC */ + /* TRAU frame with valid CS2 block */ const ubit_t bits_cs2[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifeed7bc961266e0fcfb1a837257b83fca2a69da1 Gerrit-Change-Number: 31470 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_pcu_ericsson_test: fix comment, CS2 blocks are not CRC protected

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31470 ) Change subject: trau_pcu_ericsson_test: fix comment, CS2 blocks are not CRC protected ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifeed7bc961266e0fcfb1a837257b83fca2a69da1 Gerrit-Change-Number: 31470 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:26:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023