February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: mobile: log state/event details on error

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31492 ) Change subject: mobile: log state/event details on error ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I24a4635e9a9a0984c0e1036e8b6ea19b08a06223 Gerrit-Change-Number: 31492 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 24 Feb 2023 10:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm: ensure completeness of osmo_bts_features_{descs,names}[]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31491 ) Change subject: gsm: ensure completeness of osmo_bts_features_{descs,names}[] ...................................................................... gsm: ensure completeness of osmo_bts_features_{descs,names}[] It already happened several times [1][2] that new features were added to enum osmo_bts_features, but the osmo_bts_features_{descs,names}[] were left unchanged. Let's add static_assert()s to prevent this. Change-Id: I8e3b7d3996e9f3e16c6d4e0d1d406fa538d5e9be Related: [1] f4f5d54ea2cb47a51aeaec2b5fb990664755900a Related: [2] 18c6a8183f92915e77368ecffb1cbf7f555453a3 --- M include/osmocom/gsm/bts_features.h M src/gsm/bts_features.c 2 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/31491/1 diff --git a/include/osmocom/gsm/bts_features.h b/include/osmocom/gsm/bts_features.h index d6eb246..cf1db4a 100644 --- a/include/osmocom/gsm/bts_features.h +++ b/include/osmocom/gsm/bts_features.h @@ -7,7 +7,7 @@ /* N. B: always add new features to the end of the list (right before _NUM_BTS_FEAT) to avoid breaking compatibility with BTS compiled against earlier version of this header. Also make sure that the description strings - osmo_bts_features_descs[] in gsm_data.c are also updated accordingly! */ + osmo_bts_features_{descs,names}[] in bts_features.c are also updated accordingly! */ enum osmo_bts_features { BTS_FEAT_HSCSD, BTS_FEAT_GPRS, diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 1e041c7..b6cd82e 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -16,6 +16,7 @@ * GNU General Public License for more details. */ +#include <osmocom/core/utils.h> #include <osmocom/gsm/bts_features.h> const struct value_string osmo_bts_features_descs[] = { @@ -49,6 +50,9 @@ { 0, NULL } }; +/* Ensure that all BTS_FEAT_* entries are present in osmo_bts_features_descs[] */ +osmo_static_assert(ARRAY_SIZE(osmo_bts_features_descs) == _NUM_BTS_FEAT + 1, _bts_features_descs); + /*! return description string of a BTS feature (osmo_bts_features_descs). * To get the plain feature name, use osmo_bts_features_name() instead. */ const char *osmo_bts_feature_name(enum osmo_bts_features feature) @@ -86,3 +90,6 @@ { BTS_FEAT_VGCS, "VGCS" }, {} }; + +/* Ensure that all BTS_FEAT_* entries are present in osmo_bts_features_names[] */ +osmo_static_assert(ARRAY_SIZE(osmo_bts_features_names) == _NUM_BTS_FEAT + 1, _bts_features_names); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e3b7d3996e9f3e16c6d4e0d1d406fa538d5e9be Gerrit-Change-Number: 31491 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: update comment

by dexter

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/31490 ) Change subject: bts_features: update comment ...................................................................... bts_features: update comment The name of the coresponding .c file has changes. Als there are now two arrays to update. Change-Id: Ia59a0eff4e3a164d1d57e5ed5878f9e71a8603e1 --- M include/osmocom/gsm/bts_features.h 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31490/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia59a0eff4e3a164d1d57e5ed5878f9e71a8603e1 Gerrit-Change-Number: 31490 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: update comment

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31490 ) Change subject: bts_features: update comment ...................................................................... bts_features: update comment The name of the coresponding .c file has changes. Als there are now two arrays to update. Change-Id: Ia59a0eff4e3a164d1d57e5ed5878f9e71a8603e1 --- M include/osmocom/gsm/bts_features.h 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31490/1 diff --git a/include/osmocom/gsm/bts_features.h b/include/osmocom/gsm/bts_features.h index 1fb5b22..8a877a7 100644 --- a/include/osmocom/gsm/bts_features.h +++ b/include/osmocom/gsm/bts_features.h @@ -7,7 +7,7 @@ /* N. B: always add new features to the end of the list (right before _NUM_BTS_FEAT) to avoid breaking compatibility with BTS compiled against earlier version of this header. Also make sure that the description strings - osmo_bts_features_descs[] in gsm_data.c are also updated accordingly! */ + osmo_bts_features_descs/names[] in bts_features.c are also updated accordingly! */ enum osmo_bts_features { BTS_FEAT_HSCSD, BTS_FEAT_GPRS, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia59a0eff4e3a164d1d57e5ed5878f9e71a8603e1 Gerrit-Change-Number: 31490 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by dexter

Attention is currently required from: laforge, fixeria, pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 6: (2 comments) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/fe6a8226_7fe6176a PS4, Line 44: osmo_bts_features_descs > You also need to update this array. Done https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/7958f2a9_52aaf5e9 PS4, Line 52: osmo_bts_features_names > You also need to update this array. […] Thanks. Yes, I have seen that by chance, now its fixed. ;-) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 09:49:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: i460_mux: add define constant for maximum number of subchannels

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31456 to look at the new patch set (#5). Change subject: i460_mux: add define constant for maximum number of subchannels ...................................................................... i460_mux: add define constant for maximum number of subchannels Lets get rid of the magic number in struct osmo_i460_timeslot and replace it with a define constant. Change-Id: Id3a3782927c7dcbc873223d56129f291c04fee26 Related: OS#5198 --- M include/osmocom/isdn/i460_mux.h 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/31456/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3a3782927c7dcbc873223d56129f291c04fee26 Gerrit-Change-Number: 31456 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by dexter

Attention is currently required from: laforge, pespin, dexter. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31415 to look at the new patch set (#6). Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... bts_features: Add features for HR formats (TS 101813 vs. RFC5993) Related: OS#5688 Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 --- M include/osmocom/gsm/bts_features.h M src/gsm/bts_features.c 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/31415/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: fix

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31489 ) Change subject: fix ...................................................................... Abandoned Expectantly pushed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I01a3f944279df9ec300280ba79300b772c836dab Gerrit-Change-Number: 31489 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: fix

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31489 ) Change subject: fix ...................................................................... fix Change-Id: I01a3f944279df9ec300280ba79300b772c836dab --- M src/gsm/bts_features.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/31489/1 diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 1e041c7..ab1b1b2 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -46,6 +46,9 @@ { BTS_FEAT_OSMUX, "Osmux (Osmocom RTP multiplexing)" }, { BTS_FEAT_VBS, "Voice Broadcast Service" }, { BTS_FEAT_VGCS, "Voice Group Call Service" }, + { BTS_FEAT_VBS, "Voice Broadcast Service" }, + { BTS_FEAT_SPEECH_H_V1_RTP_TX_RFC5993, "tx HR GSM RTP payload in RFC 5993 format" }, + { BTS_FEAT_SPEECH_H_V1_RTP_TX_TS101318, "tx HR GSM RTP payload in ETSI TS 101.138 (TIPHON) format" }, { 0, NULL } }; @@ -84,5 +87,7 @@ { BTS_FEAT_OSMUX, "OSMUX" }, { BTS_FEAT_VBS, "VBS" }, { BTS_FEAT_VGCS, "VGCS" }, + { BTS_FEAT_SPEECH_H_V1_RTP_TX_RFC5993, "SPEECH_F_V1_RTP_TX_RFC5993" }, + { BTS_FEAT_SPEECH_H_V1_RTP_TX_TS101318, "SPEECH_F_V1_RTP_TX_TS101318" }, {} }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I01a3f944279df9ec300280ba79300b772c836dab Gerrit-Change-Number: 31489 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm: add missing features to osmo_bts_features_names[]

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31488 ) Change subject: gsm: add missing features to osmo_bts_features_names[] ...................................................................... gsm: add missing features to osmo_bts_features_names[] Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Fixes: 812dfbf3a756088ef8ae083044c690783ef84067 --- M src/gsm/bts_features.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 1cc3c26..1e041c7 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -82,5 +82,7 @@ { BTS_FEAT_DYN_TS_SDCCH8, "DYN_TS_SDCCH8" }, { BTS_FEAT_ACCH_TEMP_OVP, "ACCH_TEMP_OVP" }, { BTS_FEAT_OSMUX, "OSMUX" }, + { BTS_FEAT_VBS, "VBS" }, + { BTS_FEAT_VGCS, "VGCS" }, {} }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff47a79d611cd1c2d23ac5b4d53dca27e402821 Gerrit-Change-Number: 31488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023