Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31519 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31519
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31519
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:13:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/31524 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/31524
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31524
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:13:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/31527 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/31527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31527
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:12:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31522 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31522
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31522
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:12:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31520 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31520
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:12:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/31525 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/31525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-smlc
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31525
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:11:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/gtphub/gtphub_main.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/31523/comment/9f958608_cc279dbd
PS1, Line 357: rc = telnet_init_default(osmo_gtphub_ctx, 0, OSMO_VTY_PORT_GTPHUB);
The second parameter of telnet_init_default() is void *, so it's better to use NULL, not 0.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31523
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31521 )
Change subject: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31521
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a
Gerrit-Change-Number: 31521
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:08:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31517 )
Change subject: doc: Adapt to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31517
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ae5a7169d864e5dbd052437addd167ffa2c510d
Gerrit-Change-Number: 31517
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:07:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31508 )
Change subject: debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd84afcd035bdca9aabb4ea2b91c1227c4786da7
Gerrit-Change-Number: 31508
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:05:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment