February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M examples/sccp_demo_user.c M stp/stp_main.c M tests/vty/ss7_asp_vty_test.c 3 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/16/31516/1 diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index df6c9af..be8d243 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -285,8 +285,7 @@ } } - rc = telnet_init_dynif(NULL, NULL, config_file ? vty_get_bind_addr() : local_address, - 2324+client); + rc = telnet_init_default(NULL, NULL, 2324+client); if (rc < 0) { perror("Error binding VTY port"); exit(1); diff --git a/stp/stp_main.c b/stp/stp_main.c index 569cf8e..01d1865 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -243,7 +243,7 @@ exit(1); } - rc = telnet_init_dynif(tall_stp_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_STP); + rc = telnet_init_default(tall_stp_ctx, NULL, OSMO_VTY_PORT_STP); if (rc < 0) { perror("Error binding VTY port\n"); exit(1); diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index 80ce3ec..5423f6f 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -182,7 +182,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42043); + rc = telnet_init_default(root_ctx, NULL, 42043); if (rc < 0) return 2; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31515 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M tests/ipa_proxy_test.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/15/31515/1 diff --git a/tests/ipa_proxy_test.c b/tests/ipa_proxy_test.c index da99f01..6c486bd 100644 --- a/tests/ipa_proxy_test.c +++ b/tests/ipa_proxy_test.c @@ -45,7 +45,7 @@ vty_init(&vty_info); ipa_proxy_vty_init(); - telnet_init(tall_test, NULL, IPA_PROXY_TEST_TELNET_PORT); + telnet_init_default(tall_test, NULL, IPA_PROXY_TEST_TELNET_PORT); LOGP(DIPA_PROXY_TEST, LOGL_NOTICE, "entering main loop\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31515 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 25 Feb 2023 14:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: GSMTAP: add missing parameter docstrings

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31512 ) Change subject: GSMTAP: add missing parameter docstrings ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I774b89e0358bdcf7c71c7fd9c9940f634a7d3822 Gerrit-Change-Number: 31512 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 25 Feb 2023 14:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: utils: use built-in static_assert() if available

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31496 ) Change subject: utils: use built-in static_assert() if available ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Surprisingly, while I expected build failures in openbsc. […] https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 gtp: use OSMO_ASSERT() in gtp_new() -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ca34bc14c05e8c38c721d7df33feb1c6c41c76e Gerrit-Change-Number: 31496 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 25 Feb 2023 11:17:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn.c: fix 'No newline at end of file'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31510 ) Change subject: gtp/gsn.c: fix 'No newline at end of file' ...................................................................... gtp/gsn.c: fix 'No newline at end of file' git complains if it's missing, vim adds it automatically. Change-Id: I3b4808a76da89e65b934d818e7ca280bc0651483 --- M gtp/gsn.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/10/31510/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index ce66244..9776b28 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -593,4 +593,4 @@ timeout->tv_usec = 0; /* dummy API, deprecated. Return a huge timer to do nothing */ return 0; -} \ No newline at end of file +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b4808a76da89e65b934d818e7ca280bc0651483 Gerrit-Change-Number: 31510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: use OSMO_ASSERT() in gtp_new()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 ) Change subject: gtp: use OSMO_ASSERT() in gtp_new() ...................................................................... gtp: use OSMO_ASSERT() in gtp_new() When using built-in static_assert() [1], gcc v12.2.1 fails: In file included from gsn.c:27: gsn.c: In function 'gtp_new': gsn.c:444:54: error: expression in static assertion is not constant 444 | osmo_static_assert(gtp_T_defs[0].default_val != 0, first_default_val_not_zero); | ^ The reason is likely that gtp_T_defs[] is not const, so it cannot be assert()ed statically. With the current osmo_static_assert() implementation, this assert does nothing. One can change the gtp_T_defs[0].default_val to 0 and the code will still compile. Change-Id: Ia8af1736b63d501661046fe70befe5bbabc1045a Related: [1] libosmocore.git I5ca34bc14c05e8c38c721d7df33feb1c6c41c76e --- M gtp/gsn.c 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/11/31511/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index 9776b28..8b3ea3a 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -441,7 +441,7 @@ /* Initialize timers: */ (*gsn)->tdef = gtp_T_defs; /* Small hack to properly reset tdef for old clients not using the tdef_group: */ - osmo_static_assert(gtp_T_defs[0].default_val != 0, first_default_val_not_zero); + OSMO_ASSERT(gtp_T_defs[0].default_val != 0); if (gtp_T_defs[0].val == 0) osmo_tdefs_reset((*gsn)->tdef); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia8af1736b63d501661046fe70befe5bbabc1045a Gerrit-Change-Number: 31511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: debian/control: fix typo

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31509 ) Change subject: debian/control: fix typo ...................................................................... debian/control: fix typo Change-Id: Ia9f99016dcf2a9584b59a253d19f391e8f5e5abb --- M debian/control 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/31509/1 diff --git a/debian/control b/debian/control index feb988b..8a1aaa2 100644 --- a/debian/control +++ b/debian/control @@ -253,7 +253,7 @@ (at least) other programs that are developed in the sphere of Free Software / Open Source mobile communication. . - This package contains the documentation for the libosmoisdnm library. + This package contains the documentation for the libosmoisdn library. Package: libosmovty9 Section: libs -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia9f99016dcf2a9584b59a253d19f391e8f5e5abb Gerrit-Change-Number: 31509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31508 ) Change subject: debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc ...................................................................... debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc Change-Id: Icd84afcd035bdca9aabb4ea2b91c1227c4786da7 --- M debian/control 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/31508/1 diff --git a/debian/control b/debian/control index 9632b7e..feb988b 100644 --- a/debian/control +++ b/debian/control @@ -143,7 +143,9 @@ libosmocoding-doc, libosmogsm-doc, libosmoisdn-doc, - libosmovty-doc + libosmovty-doc, + libosmoctrl-doc, + libosmogb-doc Description: Documentation for the Osmo Core library This is part of the libosmocore "meta"-library. The libosmocore library contains various utility functions that were originally developed as part of -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd84afcd035bdca9aabb4ea2b91c1227c4786da7 Gerrit-Change-Number: 31508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[XL] Change in libosmocore[master]: doxygen: also generate documentation for libosmo{sim,usb}

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31507 to look at the new patch set (#2). Change subject: doxygen: also generate documentation for libosmo{sim,usb} ...................................................................... doxygen: also generate documentation for libosmo{sim,usb} We do have API documentation for all libraries, excepte these two. Change-Id: I2ec5803bc219b9ceaf0d52d41a03ab78f580e689 --- M .gitignore A Doxyfile.sim.in A Doxyfile.usb.in M Makefile.am M configure.ac M debian/control A debian/libosmosim-doc.doc-base A debian/libosmosim-doc.install A debian/libosmousb-doc.doc-base A debian/libosmousb-doc.install 10 files changed, 3,573 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/31507/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ec5803bc219b9ceaf0d52d41a03ab78f580e689 Gerrit-Change-Number: 31507 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023