February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: trau_pcu_ericsson: add comment about uplink blocks

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31475 ) Change subject: trau_pcu_ericsson: add comment about uplink blocks ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35b9a35c9b583378559daa400e105537338ee68a Gerrit-Change-Number: 31475 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in libosmo-abis[master]: trau_pcu_ericsson: add testvectors for MCS1-MCS8

by fixeria

Attention is currently required from: msuraev, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 ) Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ...................................................................... Patch Set 2: (1 comment) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/1127ba21_02a4373a PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav); > I just thought that this wouldn't matter since its just a unit test, but if you think that it is nec […] The usual approach would be grouping all test vectors into an array, and simply iterating over it in a loop, like many unit tests do. The current code looks more like a result of `-funroll-loops` :P -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7e7e35930a373c9db74faef24f6c404eb5516278 Gerrit-Change-Number: 31454 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_sock: print OML alerts from PCU

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31499 ) Change subject: pcu_sock: print OML alerts from PCU ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31499/comment/693f0ba2_ffcea193 PS2, Line 691: LOGP Use `LOG_BTS`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id32553556356c2affe32e47ae1c3ae6a514efdce Gerrit-Change-Number: 31499 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix sourcecode formatting

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31498 ) Change subject: timeslot_fsm: fix sourcecode formatting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1cfd377cd8014e42aa45f9f0da664598ee88e02d Gerrit-Change-Number: 31498 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:20:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

by fixeria

Attention is currently required from: neels, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497 ) Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect ...................................................................... Patch Set 2: (4 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/0a901719_39feab04 PS2, Line 802: ts->fi->state == TS_ST_PDCH Could you clarify why checking the FSM state is necessary? It's a bit weird to see code checking `fi->state` before sending an event. The FSM itself should take care of handling events in different states. https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/ea0d7c3d_136a90a1 PS2, Line 935: struct gsm_bts_trx_ts *ts; This variable should be moved to the inner for-loop. https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/3074cb99_b60f9c88 PS2, Line 973: gsm_bts_trx_num As I already commented on one of your previous patches, using `gsm_bts_trx_num()` in a loop is not a good idea. Better iterate over the `&bts->trx_list` directly, like you did in `pcu_tx_e1_ccu_ind()`. https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/28e6e22b_01c1f963 PS2, Line 976: 8 ARRAY_SIZE(trx->ts) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Gerrit-Change-Number: 31497 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:19:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc.in: add missing libosmogsm

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 ) Change subject: libosmo-pfcp.pc.in: add missing libosmogsm ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ie1c92d251af6a3e42759ff0da0d3693356b5e1d3 Gerrit-Change-Number: 31504 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 21:24:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in osmo-upf[master]: add unique_ids_test.c

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31482 ) Change subject: add unique_ids_test.c ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: looks like this patch should resolve the problem: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 Gerrit-Change-Number: 31482 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 24 Feb 2023 18:21:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc.in: add missing libosmogsm

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 to look at the new patch set (#2). Change subject: libosmo-pfcp.pc.in: add missing libosmogsm ...................................................................... libosmo-pfcp.pc.in: add missing libosmogsm We use osmo_apn_from_str() and osmo_apn_to_str(), defined in libosmogsm, since this commit: "fix coding of Network Instance IE" 8368e7d5d59140fc77b890493a47a08cd644e2f8 I9d67464ef0f92b0512cfd6e48d203f8828a82a19 Since libosmo-pfcp merely calls the two functions and none of libosmogsm is exposed in the libosmo-pfcp API, it suffices to use Requires.private in the .pc file. Change-Id: Ie1c92d251af6a3e42759ff0da0d3693356b5e1d3 --- M libosmo-pfcp.pc.in 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/04/31504/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ie1c92d251af6a3e42759ff0da0d3693356b5e1d3 Gerrit-Change-Number: 31504 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc.in: add missing libosmogsm

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 ) Change subject: libosmo-pfcp.pc.in: add missing libosmogsm ...................................................................... libosmo-pfcp.pc.in: add missing libosmogsm We use osmo_apn_from_str() and osmo_apn_to_str(), defined in libosmogsm, since this commit: "fix coding of Network Instance IE" 8368e7d5d59140fc77b890493a47a08cd644e2f8 I9d67464ef0f92b0512cfd6e48d203f8828a82a19 Change-Id: Ie1c92d251af6a3e42759ff0da0d3693356b5e1d3 --- M libosmo-pfcp.pc.in 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/04/31504/1 diff --git a/libosmo-pfcp.pc.in b/libosmo-pfcp.pc.in index 0ed5160..cafbdd3 100644 --- a/libosmo-pfcp.pc.in +++ b/libosmo-pfcp.pc.in @@ -6,6 +6,6 @@ Name: Osmocom PFCP library Description: C Utility Library that implements the PFCP protocol and endpoint Version: @VERSION@ -Requires: libosmo-gtlv, libosmocore, talloc +Requires: libosmo-gtlv, libosmogsm, libosmocore, talloc Libs: -L${libdir} -losmo-pfcp Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ie1c92d251af6a3e42759ff0da0d3693356b5e1d3 Gerrit-Change-Number: 31504 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 13: (2 comments) File src/ericsson-rbs/er_ccu_l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4006): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/8fc7f3d7_a93e0314 PS13, Line 241: "afn_ul=%u (computed) != afn_ul=%u (sync-ind) => delta=%u \n", afn_ul, unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4006): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/a709947f_7452d4c0 PS13, Line 246: "afn_dl=%u (computed) != afn_dl=%u (sync-ind) => delta=%u \n", afn_dl, unnecessary whitespace before a quoted newline -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 17:31:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023