February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-uecups[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/31527 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M daemon/main.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/daemon/main.c b/daemon/main.c index e5a8147..c023351 100644 --- a/daemon/main.c +++ b/daemon/main.c @@ -234,7 +234,7 @@ exit(2); } - rc = telnet_init_dynif(g_daemon, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_UECUPS); + rc = telnet_init_default(g_daemon, NULL, OSMO_VTY_PORT_UECUPS); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/31527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31527 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-sip-connector[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/31524 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/main.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/main.c b/src/main.c index 3385e37..6b711d7 100644 --- a/src/main.c +++ b/src/main.c @@ -147,8 +147,7 @@ exit(1); } - rc = telnet_init_dynif(tall_mncc_ctx, NULL, - vty_get_bind_addr(), OSMO_VTY_PORT_MNCC_SIP); + rc = telnet_init_default(tall_mncc_ctx, NULL, OSMO_VTY_PORT_MNCC_SIP); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/31524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31524 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-iuh[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31519 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/tests/hnb-test.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c index 2c73fed..de75186 100644 --- a/src/tests/hnb-test.c +++ b/src/tests/hnb-test.c @@ -950,7 +950,7 @@ vty_init(&vty_info); hnbtest_vty_init(); - rc = telnet_init_dynif(NULL, NULL, vty_get_bind_addr(), 2324); + rc = telnet_init_default(NULL, NULL, 2324); if (rc < 0) { perror("Error binding VTY port"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31519 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-hnodeb[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/31518 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/osmo-hnodeb/main.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 304ad1c..e724791 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -268,7 +268,7 @@ exit(1); } - rc = telnet_init_dynif(tall_hnb_ctx, g_hnb, vty_get_bind_addr(), OSMO_VTY_PORT_HNODEB); + rc = telnet_init_default(tall_hnb_ctx, g_hnb, OSMO_VTY_PORT_HNODEB); if (rc < 0) { perror("Error binding VTY port"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/31518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31518 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in libosmo-abis[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31515 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M tests/ipa_proxy_test.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/ipa_proxy_test.c b/tests/ipa_proxy_test.c index da99f01..6c486bd 100644 --- a/tests/ipa_proxy_test.c +++ b/tests/ipa_proxy_test.c @@ -45,7 +45,7 @@ vty_init(&vty_info); ipa_proxy_vty_init(); - telnet_init(tall_test, NULL, IPA_PROXY_TEST_TELNET_PORT); + telnet_init_default(tall_test, NULL, IPA_PROXY_TEST_TELNET_PORT); LOGP(DIPA_PROXY_TEST, LOGL_NOTICE, "entering main loop\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31515 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: msuraev. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 2: (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/31516/comment/6b123123_21f3ba1a PS1, Line 288: rc = telnet_init_default(NULL, NULL, 2324+client); > It's better to put space around + for readability. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 19:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 to look at the new patch set (#2). Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M examples/sccp_demo_user.c M stp/stp_main.c M tests/vty/ss7_asp_vty_test.c 3 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/16/31516/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 ) Change subject: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy ...................................................................... lib/icmpv6.h: run struct_endianness.py to make Jenkins happy Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c --- M lib/icmpv6.h 1 file changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/32/31532/1 diff --git a/lib/icmpv6.h b/lib/icmpv6.h index 4b4dc37..ee5ef29 100644 --- a/lib/icmpv6.h +++ b/lib/icmpv6.h @@ -44,10 +44,9 @@ uint8_t res:6, m:1, o:1; -#else - uint8_t m:1, - o:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t o:1, m:1, res:6; #endif uint16_t router_lifetime; uint32_t reachable_time; @@ -72,10 +71,9 @@ uint8_t res:6, a:1, l:1; -#else - uint8_t l:1, - a:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t l:1, a:1, res:6; #endif uint32_t valid_lifetime; uint32_t preferred_lifetime; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c Gerrit-Change-Number: 31532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: make the testsuite dir writable by all users

by fixeria

Attention is currently required from: osmith, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31424 ) Change subject: ttcn3-pgw-test: make the testsuite dir writable by all users ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > If the problem is in access to "$VOL_BASE_DIR/pgw-tester/" than why not simply "chmod -R 777 $VOL_BA […] Done. File ttcn3-pgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/31424/comment/404e444f_69b… PS1, Line 23: chmod 777 $(find $VOL_BASE_DIR -type d) > why not "chmod -R 777 $VOL_BASE_DIR" instead, so the files can also be modified? Doing what Max suggested should be enough. Other dirs don't really need to be writable. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Gerrit-Change-Number: 31424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 08:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: make the testsuite dir writable by all users

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31424 to look at the new patch set (#2). Change subject: ttcn3-pgw-test: make the testsuite dir writable by all users ...................................................................... ttcn3-pgw-test: make the testsuite dir writable by all users When running jenkins.sh as root or any other user with UID different than UID=1000 of the 'osmocom' user we have in open5gs-{master,latest} images, programs spawned by osmo-uecups-daemon (e.g. ping) may fail to start. In such cases, osmo-uecups-daemon reports unexpected program termination with exit code=512. This is happening because the stdout and stderr of a spawned program are being redirected to "$VOL_BASE_DIR/pgw-tester/TESTCASE.prog.std{out,err}", for which the 'osmocom' user needs to have write permissions. Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Related: OS#5913 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/24/31424/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Gerrit-Change-Number: 31424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023