February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: GSMTAP: add missing parameter docstrings

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31512 ) Change subject: GSMTAP: add missing parameter docstrings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I774b89e0358bdcf7c71c7fd9c9940f634a7d3822 Gerrit-Change-Number: 31512 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 21:45:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Transition to use of 'telnet_init_default'

by fixeria

Attention is currently required from: arehbein, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 21:11:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by fixeria

Attention is currently required from: arehbein, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 21:11:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: msuraev. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 1: (1 comment) File src/gtphub/gtphub_main.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/31523/comment/df55074c_6b3ee762 PS1, Line 357: rc = telnet_init_default(osmo_gtphub_ctx, 0, OSMO_VTY_PORT_GTPHUB); > The second parameter of telnet_init_default() is void *, so it's better to use NULL, not 0. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 20:16:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 to look at the new patch set (#2). Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/gtphub/gtphub_main.c M src/sgsn/sgsn_main.c 2 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/23/31523/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-bts[master]: doc: Adapt to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31517 ) Change subject: doc: Adapt to use of 'telnet_init_default' ...................................................................... doc: Adapt to use of 'telnet_init_default' Related: OS#5809 Change-Id: I1ae5a7169d864e5dbd052437addd167ffa2c510d --- M doc/manuals/chapters/architecture.adoc M doc/startup.txt 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/doc/manuals/chapters/architecture.adoc b/doc/manuals/chapters/architecture.adoc index 128ed59..ca3a1e3 100644 --- a/doc/manuals/chapters/architecture.adoc +++ b/doc/manuals/chapters/architecture.adoc @@ -82,7 +82,7 @@ | bts-specific | bts_model_phy_instance_set_defaults() | Called for every PHY Instance created | common | bts_controlif_setup() | Initialization of Control Interface | bts-specific | bts_model_ctrl_cmds_install() | Install model-specific control interface commands -| common | telnet_init() | Initialization of telnet interface +| common | telnet_init_default() | Initialization of telnet interface | common | pcu_sock_init() | Initialization of PCU socket | common | main() | Installation of signal handlers | common | abis_open() | Start of the A-bis connection to BSC diff --git a/doc/startup.txt b/doc/startup.txt index 816e76b..46c526a 100644 --- a/doc/startup.txt +++ b/doc/startup.txt @@ -21,7 +21,7 @@ | bts-specific | bts_model_phy_instance_set_defaults() | Called for every PHY Instance created | common | bts_controlif_setup() | Initialization of Control Interface | bts-specific | bts_model_ctrl_cmds_install() -| common | telnet_init() | Initialization of telnet interface +| common | telnet_init_default() | Initialization of telnet interface | common | pcu_sock_init() | Initialization of PCU socket | common | main() | Installation of signal handlers | common | abis_open() | Start of the A-bis connection to BSC -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1ae5a7169d864e5dbd052437addd167ffa2c510d Gerrit-Change-Number: 31517 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-msc[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31521 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/osmo-msc/msc_main.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 0f1047b..c87749d 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -683,8 +683,7 @@ DEBUGP(DMNCC, "Using internal MNCC handler.\n"); /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_msc_ctx, &msc_network, - vty_get_bind_addr(), OSMO_VTY_PORT_MSC); + rc = telnet_init_default(tall_msc_ctx, &msc_network, OSMO_VTY_PORT_MSC); if (rc < 0) return 2; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31521 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-smlc[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/31525 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/osmo-smlc/smlc_main.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-smlc/smlc_main.c b/src/osmo-smlc/smlc_main.c index a2724b6..f2944f0 100644 --- a/src/osmo-smlc/smlc_main.c +++ b/src/osmo-smlc/smlc_main.c @@ -262,7 +262,7 @@ } /* Start telnet interface after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_smlc_ctx, g_smlc, vty_get_bind_addr(), OSMO_VTY_PORT_SMLC); + rc = telnet_init_default(tall_smlc_ctx, g_smlc, OSMO_VTY_PORT_SMLC); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/31525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31525 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-mgw[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31520 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/osmo-mgw/mgw_main.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index b9a36dd..5a62e95 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -360,8 +360,7 @@ return rc; /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_mgw_ctx, NULL, - vty_get_bind_addr(), OSMO_VTY_PORT_MGW); + rc = telnet_init_default(tall_mgw_ctx, NULL, OSMO_VTY_PORT_MGW); if (rc < 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31520 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31522 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 1ab24c3..3033b15 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -283,7 +283,7 @@ exit(1); } - rc = telnet_init_dynif(tall_cli_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCAP_CLIENT); + rc = telnet_init_default(tall_cli_ctx, NULL, OSMO_VTY_PORT_PCAP_CLIENT); if (rc < 0) { LOGP(DCLIENT, LOGL_ERROR, "Failed to bind telnet interface\n"); exit(1); diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 3b73b81..484b51d 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -294,7 +294,7 @@ exit(1); } - rc = telnet_init_dynif(tall_srv_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCAP_SERVER); + rc = telnet_init_default(tall_srv_ctx, NULL, OSMO_VTY_PORT_PCAP_SERVER); if (rc < 0) { LOGP(DCLIENT, LOGL_ERROR, "Failed to bind telnet interface\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31522 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023