Attention is currently required from: neels, arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> what would be the proper way?
Having each python app/file creating those specific files register them to be cleaned up, and not being done blindly by the lib (who is not really creating them), as presented here.
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31529 )
Change subject: Interleaving for CSD
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I wonder where that "f96" naming in the function comes from.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6b16c2d0d7febf3883da662b2c7fec543335de12
Gerrit-Change-Number: 31529
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment