Attention is currently required from: osmith, neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31506 )
Change subject: ttcn3-ggsn-test-ogs: update open5gs-{smf,upf} config files
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> i'm curious why the many changes to commented-out lines ... […]
This is how the config files in open5gs evolved over the years. Similar to I27adbab6a6b95ddf4c6d39803e4f7dd079f11a4c, the idea here is to make our config files up to date with the upstream, so that it's easier to diff them.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic92d73e93b47abb4fae99fc9bece0c93bf9b91ef
Gerrit-Change-Number: 31506
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria, msuraev, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 )
Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8
......................................................................
Patch Set 3:
(1 comment)
File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/888763a1_5a4faae8
PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav);
> Since I receive a lot of criticism regarding the code duplication I will clean this up in a follow u […]
It's not about "optimization", but about code maintainability and readability. So if N times the same thing happens, it's easier to read and maintain if it's one fucntion, rather than somebody having to look at N copies and trying to identify if they really do all the same thing or differ in some subtle way.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31454
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7e7e35930a373c9db74faef24f6c404eb5516278
Gerrit-Change-Number: 31454
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 )
Change subject: GSMTAP: allow configuring src IP for log messages
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/bd8f8c87_143ccbba
PS2, Line 7: configuring src IP for log messages
Can you explain how might this be useful on practice?
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/356b03ad_081eadb5
PS2, Line 180: logging source
I am sorry, but to me it looks like a wrong direction. You're adding a general parameter, which only applies to GSMTAP target(s). The naming `logging source` is also quite unspecific: source what? IMO, it should be added as an optional parameter of the `log gsmtap` command:
log gsmtap [HOSTNAME] [SRCADDR]
It's also unlikely that unsetting the source address is useful. Why would you want to unset that?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 )
Change subject: gtp: use OSMO_ASSERT() in gtp_new()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Note that this needs to be backported to the last releases (it seems we usually do the last 2 releas […]
I am afraid we won't be able to merge the libosmocore patch as-is, even if we backport this patch and tag a patch release. The general rule is that it should still be possible to compile old apps against new libosmocore. But we can make it configurable at compile-time (disabled by default) and use for development builds.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia8af1736b63d501661046fe70befe5bbabc1045a
Gerrit-Change-Number: 31511
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31118 )
Change subject: Work around coverity false positives in macros
......................................................................
Work around coverity false positives in macros
We have some macros that may at times have signed arguments, and at
other times unsigned. Checking for <= 0 is not a bug in this case.
Let's typecast any unsigned arguments to signed int to work around.
Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479
Closes: CID#272993, CID#272992 (and many others)
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 44a9d5e..8c4dcce 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -495,9 +495,9 @@
*
* These macros convert from n to the other representations:
*/
-#define ALG_A5_NR_TO_RSL(A5_N) ((A5_N) >= 0 ? (A5_N)+1 : 0)
+#define ALG_A5_NR_TO_RSL(A5_N) ((int)(A5_N) >= 0 ? (A5_N)+1 : 0)
#define ALG_A5_NR_TO_BSSAP(A5_N) ALG_A5_NR_TO_RSL(A5_N)
-#define ALG_A5_NR_TO_PERM_ALG_BITS(A5_N) ((A5_N) >= 0 ? 1<<(A5_N) : 0)
+#define ALG_A5_NR_TO_PERM_ALG_BITS(A5_N) ((int)(A5_N) >= 0 ? 1<<(A5_N) : 0)
/* Up to 16 SI2quater are multiplexed; each fits 3 EARFCNS, so the practical maximum is 3*16.
* The real maximum that fits in a total of 16 SI2quater rest octets also depends on the bits left by other SI2quater
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479
Gerrit-Change-Number: 31118
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31118 )
Change subject: Work around coverity false positives in macros
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479
Gerrit-Change-Number: 31118
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 10:12:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment