February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity: add libgtpnl

by fixeria

Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31133 ) Change subject: coverity: add libgtpnl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I534b8a550061e52d4c5ab95ad98e146a77f386bc Gerrit-Change-Number: 31133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 11:13:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 ) Change subject: Add SI10 support ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 11:13:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: Add SI10 support

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31039 ) Change subject: Add SI10 support ...................................................................... Add SI10 support Related: OS#5783 Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab --- M doc/manuals/abis/rsl.adoc M src/common/rsl.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/abis/rsl.adoc b/doc/manuals/abis/rsl.adoc index ab1d5e7..081bf98 100644 --- a/doc/manuals/abis/rsl.adoc +++ b/doc/manuals/abis/rsl.adoc @@ -192,6 +192,7 @@ | 0x06 | RSL_SYSTEM_INFO_6 | 0x0d | RSL_SYSTEM_INFO_5bis | 0x0e | RSL_SYSTEM_INFO_5ter +| 0x0f | RSL_SYSTEM_INFO_10 | 0x47 | RSL_EXT_MEAS_ORDER | 0x48 | RSL_MEAS_INFO |=== diff --git a/src/common/rsl.c b/src/common/rsl.c index 91af6cb..64ffcb8 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -72,6 +72,7 @@ RSL_SYSTEM_INFO_6, RSL_SYSTEM_INFO_5bis, RSL_SYSTEM_INFO_5ter, + RSL_SYSTEM_INFO_10, RSL_EXT_MEAS_ORDER, RSL_MEAS_INFO, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab Gerrit-Change-Number: 31039 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: Add SI10 support

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31039 ) Change subject: Add SI10 support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab Gerrit-Change-Number: 31039 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 01 Feb 2023 11:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by msuraev

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 ) Change subject: Add SI10 support ...................................................................... Patch Set 10: (2 comments) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/31036/comment/df072470_cb058901 PS9, Line 1144: #elif OSMO_IS_BIG_ENDIAN > > (and CI should complain about it, I'll look into why it doesn't run automatically.) […] Done https://gerrit.osmocom.org/c/libosmocore/+/31036/comment/771530e6_a25aa027 PS9, Line 1144: #elif OSMO_IS_BIG_ENDIAN > > (and CI should complain about it, I'll look into why it doesn't run automatically.) […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 11:10:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31036 to look at the new patch set (#10). Change subject: Add SI10 support ...................................................................... Add SI10 support Add data structures and checks for System information Type 10. Related: OS#5783 Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/sysinfo.c 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/31036/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: coverity: add libgtpnl

by osmith

Attention is currently required from: laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31133 ) Change subject: coverity: add libgtpnl ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm surprised osmo-ggsn built without it so far. […] -> https://gerrit.osmocom.org/c/osmo-ci/+/31139 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I534b8a550061e52d4c5ab95ad98e146a77f386bc Gerrit-Change-Number: 31133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 11:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: coverity: build osmo-ggsn with --enable-gtp-linux

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31139 ) Change subject: coverity: build osmo-ggsn with --enable-gtp-linux ...................................................................... coverity: build osmo-ggsn with --enable-gtp-linux Change-Id: I5b240dbfe2369a5a54ab6115a8780cf9cc36b537 --- M coverity/build_Osmocom.sh 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/39/31139/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index d3d11d8..3bf9d4b 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -79,7 +79,9 @@ build_default libosmo-pfcp build_default libosmo-sccp build_default libsmpp34 -build_default osmo-ggsn +build_default libgtpnl +build_default osmo-ggsn \ + --enable-gtp-linux build_default osmo-gbproxy build_default osmo-iuh build_default osmo-pcu \ @@ -126,7 +128,6 @@ build_default osmo-pcap build_default osmo-e1d build_default osmo-e1-recorder -build_default libgtpnl build_default osmo-upf # OS#5886: doesn't build -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b240dbfe2369a5a54ab6115a8780cf9cc36b537 Gerrit-Change-Number: 31139 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: ansible/osmocom-jenkins-slave: add libnftables-dev

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31132 ) Change subject: ansible/osmocom-jenkins-slave: add libnftables-dev ...................................................................... ansible/osmocom-jenkins-slave: add libnftables-dev Install libnftables-dev, so osmo-upf can build successfully in the coverity jenkins job. Change-Id: Id72ce8ed5b662085a16f56756f8f93627834d2e2 --- M ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml index 1cfb715..8faab77 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml @@ -66,6 +66,7 @@ - libgnutls28-dev - libgps-dev - libgsm1-dev + - libnftables-dev - libnl-3-dev - libnl-route-3-dev - libmnl-dev -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id72ce8ed5b662085a16f56756f8f93627834d2e2 Gerrit-Change-Number: 31132 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 10:54:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023