February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity: disable building osmo-isdntap
by osmith 01 Feb '23

01 Feb '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31135 ) Change subject: coverity: disable building osmo-isdntap ...................................................................... coverity: disable building osmo-isdntap As it doesn't seem to build properly with default dahdi-linux, disable it for now. Related: OS#5886 Change-Id: Icb5cf7517a2ba0f3abb1d44337677f9502069ec6 --- M coverity/build_Osmocom.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/35/31135/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index fe22351..d3d11d8 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -128,7 +128,10 @@ build_default osmo-e1-recorder build_default libgtpnl build_default osmo-upf -build_default osmo-isdntap + +# OS#5886: doesn't build +# build_default osmo-isdntap + build_default osmo-uecups build_default osmo-remsim \ --with-usbdropdir=$prefix/usr/lib/pcsc/drivers \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb5cf7517a2ba0f3abb1d44337677f9502069ec6 Gerrit-Change-Number: 31135 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity: check if sdcc is installed
by osmith 01 Feb '23

01 Feb '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31137 ) Change subject: coverity: check if sdcc is installed ...................................................................... coverity: check if sdcc is installed Check at the start if sdcc is installed, as it's required to build libusrp. It might not be installed when testing locally. Change-Id: I226f439f7eff657d01c667aae464c080b91d5a82 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/31137/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 399b1e5..2c69356 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -2,6 +2,8 @@ . $(realpath common.sh) BASEDIR=source-Osmocom +osmo_cmd_require sdcc + # How to add a new project: # * add it to the list below # * add it to build_Osmocom.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I226f439f7eff657d01c667aae464c080b91d5a82 Gerrit-Change-Number: 31137 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-e1d[master]: DAHDI trunkdev support
by laforge 01 Feb '23

01 Feb '23

Attention is currently required from: manawyrm, laforge, tnt, pespin. Hello Jenkins Builder, manawyrm, tnt, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 to look at the new patch set (#7). Change subject: DAHDI trunkdev support ...................................................................... DAHDI trunkdev support DAHDI trunkdev is a newly-introduced 'virtual trunk' character device which is used instead of a real hardware driver. This means that an application (such as osmo-e1d) can implement a virtual E1 trunk and receive and transmit E1 frame data which is exposed to DAHDI users just like the data from a real physical E1 span. In order to build DAHDI trunkdev support into osmo-e1d, you will need a special fork of dahdi containing the required support, currently the laforge/trunkdev branch of the following repository: https://gitea.osmocom.org/retronetworking/dahdi-linux Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 --- M configure.ac M include/osmocom/octoi/octoi.h M src/Makefile.am A src/dahdi_trunkdev.c M src/e1d.h M src/e1oip.c M src/intf_line.c M src/log.c M src/log.h M src/octoi/octoi.c M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_fsm.c M src/octoi/octoi_srv_vty.c M src/octoi/octoi_vty.h M src/vty.c 15 files changed, 490 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/68/30068/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 Gerrit-Change-Number: 30068 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: DAHDI trunkdev support
by Jenkins Builder 01 Feb '23

01 Feb '23

Attention is currently required from: manawyrm, tnt, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30068 ) Change subject: DAHDI trunkdev support ...................................................................... Patch Set 6: (1 comment) File src/vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3159): https://gerrit.osmocom.org/c/osmo-e1d/+/30068/comment/a4a503f2_b6fb0c1b PS6, Line 310: if (!intf) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 Gerrit-Change-Number: 30068 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 10:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: DAHDI trunkdev support
by laforge 01 Feb '23

01 Feb '23

Attention is currently required from: manawyrm, tnt, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30068 ) Change subject: DAHDI trunkdev support ...................................................................... Patch Set 6: (1 comment) File src/log.c: https://gerrit.osmocom.org/c/osmo-e1d/+/30068/comment/ea723a41_4979f2e2 PS5, Line 41: [DTRUNK] = { > DTRUNKDEV would match better the terminology used here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 Gerrit-Change-Number: 30068 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 10:20:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: DAHDI trunkdev support
by laforge 01 Feb '23

01 Feb '23

Attention is currently required from: manawyrm, laforge, tnt. Hello Jenkins Builder, manawyrm, tnt, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 to look at the new patch set (#6). Change subject: DAHDI trunkdev support ...................................................................... DAHDI trunkdev support DAHDI trunkdev is a newly-introduced 'virtual trunk' character device which is used instead of a real hardware driver. This means that an application (such as osmo-e1d) can implement a virtual E1 trunk and receive and transmit E1 frame data which is exposed to DAHDI users just like the data from a real physical E1 span. In order to build DAHDI trunkdev support into osmo-e1d, you will need a special fork of dahdi containing the required support, currently the laforge/trunkdev branch of the following repository: https://gitea.osmocom.org/retronetworking/dahdi-linux Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 --- M configure.ac M include/osmocom/octoi/octoi.h M src/Makefile.am A src/dahdi_trunkdev.c M src/e1d.h M src/e1oip.c M src/intf_line.c M src/log.c M src/log.h M src/octoi/octoi.c M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_fsm.c M src/octoi/octoi_srv_vty.c M src/octoi/octoi_vty.h M src/vty.c 15 files changed, 491 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/68/30068/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 Gerrit-Change-Number: 30068 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

1 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods
by laforge 01 Feb '23

01 Feb '23

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: (2 comments) File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/0391820c_ea1d01e8 PS12, Line 56: debug("Testing decode of %s" % name) > Not really critical (for tests), just a tip: documentation of the Python's logging framework recomme […] changed. https://gerrit.osmocom.org/c/pysim/+/24012/comment/72cf4684_09bbde0b PS12, Line 160: for c in classes: > Can be done a bit simpler: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 09:53:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods
by laforge 01 Feb '23

01 Feb '23

Attention is currently required from: laforge, dexter. laforge has uploaded a new patch set (#13) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... filesystem: add unit tests for encoder/decoder methods Lets add test vectors for the per-record/per-file encode/decode of our various classes for the Elementary Files. We keep the test vectors as class variables of the respective EF-classes to ensure implementation and test vectors are next to each other. The test classes then iterate over all EF subclasses and execute the decode/encode functions using the test vectors from the class variables. Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Related: OS#4963 --- M pySim/gsm_r.py M pySim/ts_102_221.py M pySim/ts_31_102.py M pySim/ts_31_102_telecom.py M pySim/ts_31_103.py M pySim/ts_51_011.py A tests/test_files.py 7 files changed, 523 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/24012/13 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bts[master]: pcu_sock: use ARRAY_SIZE rather then magic number
by dexter 01 Feb '23

01 Feb '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31127 ) Change subject: pcu_sock: use ARRAY_SIZE rather then magic number ...................................................................... pcu_sock: use ARRAY_SIZE rather then magic number Lets use ARRAY_SIZE instead of magic number (8) to determine the number of timeslots to iterate. Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 --- M src/common/pcu_sock.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index b7ec048..8f8b3af 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -203,7 +203,7 @@ return; } - for (tn = 0; tn < 8; tn++) { + for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 Gerrit-Change-Number: 31127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation
by keith 01 Feb '23

01 Feb '23

Attention is currently required from: fixeria. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... Patch Set 2: (2 comments) File src/libmsc/transaction.c: https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/8e6a083b_e064df77 PS1, Line 165: %sfor > missing space between '%s' and 'for' Actually done intentionally, because osmo_hexdump() seems to add a space at the end. If I add the "missing" space then the log line will contain two spaces. https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/4fe15bb1_ac4f8812 PS1, Line 165: 0x%x > 0x04x to ensure consistent formatting I'm guessing you mean 0x%04x, although I don't understand why. It's 4 octets anyway, no? - the logging macro often logging callref uses: ..... LOGP(subsys, level, \ "trans(%s %s callref-0x%x tid-%u%s) " fmt, \ .... But I trust your request, I hope I have it right. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 02:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log February 2023