February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: e1_input: add define constant for full subslot (whole E1 timeslot)

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31254 ) Change subject: e1_input: add define constant for full subslot (whole E1 timeslot) ...................................................................... e1_input: add define constant for full subslot (whole E1 timeslot) The struct gsm_e1_subslot has a memeber e1_ts_ss, which describes the I.460 subslot to use inside an E1 timeslot. This is usually just an integer number (e.g. 0,1,2,3 for a line with 4 16kbps subslots). However it is also possible to use no subslots at all. This is encoded by setting e1_ts_ss to 0xff. When this magic number is used somewhere in the code it is not immediately obvious what it means, so lets add a define constant. Change-Id: I62725420d1cb2803b87fe5aa5e6ca1f3740be9eb Related: OS#5198 --- M include/osmocom/abis/e1_input.h 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/54/31254/1 diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 8e7f20b..91bf181 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -148,12 +148,14 @@ struct msgb *pending_msg; }; +#define E1_SUBSLOT_FULL 0xff + struct gsm_e1_subslot { /* Number of E1 link */ uint8_t e1_nr; /* Number of E1 TS inside E1 link */ uint8_t e1_ts; - /* Sub-slot within the E1 TS, 0xff if full TS */ + /* Sub-slot within the E1 TS, 0xff (E1_SUBSLOT_FULL) if full TS */ uint8_t e1_ts_ss; }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I62725420d1cb2803b87fe5aa5e6ca1f3740be9eb Gerrit-Change-Number: 31254 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: obs: git.py: fix f-string

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31253 ) Change subject: obs: git.py: fix f-string ...................................................................... obs: git.py: fix f-string Change-Id: Iaaedf019012d77e4a385054532d1d10659ef8e76 --- M scripts/obs/lib/git.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/31253/1 diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py index db1509b..13c2216 100644 --- a/scripts/obs/lib/git.py +++ b/scripts/obs/lib/git.py @@ -94,8 +94,8 @@ ret = ls_remote.output.split("\t")[0] if not ret: - lib.exit_error_cmd(ls_remote, f"failed to find head commit for" - "{project} in output") + lib.exit_error_cmd(ls_remote, "failed to find head commit for" + f" {project} in output") return ret -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaaedf019012d77e4a385054532d1d10659ef8e76 Gerrit-Change-Number: 31253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: add libosmo-pfcp, libgtpnl

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31252 ) Change subject: release-tarball: add libosmo-pfcp, libgtpnl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4096c21352366c16167efce5c2a97f4e04c1addb Gerrit-Change-Number: 31252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 15:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: add libosmo-pfcp, libgtpnl

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31252 ) Change subject: release-tarball: add libosmo-pfcp, libgtpnl ...................................................................... release-tarball: add libosmo-pfcp, libgtpnl Change-Id: I4096c21352366c16167efce5c2a97f4e04c1addb --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/52/31252/1 diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index b66b9ea..8c41783 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -11,8 +11,10 @@ OSMO_GIT_URL="https://git.osmocom.org" OSMO_RELEASE_REPOS=" libasn1c + libgtpnl libosmo-abis libosmo-netif + libosmo-pfcp libosmo-sccp libosmocore libsmpp34 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4096c21352366c16167efce5c2a97f4e04c1addb Gerrit-Change-Number: 31252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: add missing cd /build

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31247 ) Change subject: release-tarball: add missing cd /build ...................................................................... release-tarball: add missing cd /build Fix for: upload: no tarballs generated, nothing to do. Change-Id: I047546b26f379c5302d8558b92b77e4fa311a0a0 --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 40f8c5e..e49c03b 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -370,6 +370,7 @@ done done +cd /build remove_temp_dir upload echo "done!" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I047546b26f379c5302d8558b92b77e4fa311a0a0 Gerrit-Change-Number: 31247 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: support git submodules

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31248 ) Change subject: release-tarball: support git submodules ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e9ef6d976ae8cf2bfb4f3c410e6b2cb3ca7841 Gerrit-Change-Number: 31248 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 13:22:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: remove PARALLEL_MAKE variable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31250 ) Change subject: release-tarball: remove PARALLEL_MAKE variable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie74ee6976759f9634503b21e964e93efcc925679 Gerrit-Change-Number: 31250 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 13:22:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: fix osmo-trx 1.5.0

by pespin

Attention is currently required from: osmith, Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31249 ) Change subject: release-tarball: fix osmo-trx 1.5.0 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: This sounds like should be fixed in osmo-trx, I see no reason having to pass --enable-mstrx mandatorily to have a tarball. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2f067409f98119d4e35cf86cc2c816fc3c19e3f5 Gerrit-Change-Number: 31249 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 13:22:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: add var to use list from jenkins

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31251 ) Change subject: release-tarball: add var to use list from jenkins ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9af310c24aa65c21cc4bd365d3df7804cba02df7 Gerrit-Change-Number: 31251 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 13:20:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: release-tarball: add missing cd /build

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31247 ) Change subject: release-tarball: add missing cd /build ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I047546b26f379c5302d8558b92b77e4fa311a0a0 Gerrit-Change-Number: 31247 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 13:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023