February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: laforge, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 9: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/2d6631a4_960f0991 PS8, Line 9: MMEDIATE > IMMEDIATE Done File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/d014da2e_6a2dedca PS8, Line 283: itsself > itself Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 17:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: laforge, pespin, fixeria. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#9). Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... bts: add IMMEDIATE ASSIGNMENT via PCH transmission In situations where the PCU is co-located to the BSC, the IMMEDIATE ASSIGNMENT for downlink TBFs must be sent via RSL and the BSC also must instruct the BTS to transmit the IMMEDIATE ASSIGNMENT via PCH instead of AGCH. Eventually the BSC must sent a confirmation message (follow-up patch) where the TLLI is used as an identifer. Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h M src/bts.cpp M src/bts.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 38 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/31145/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: receive E1 connection parameters

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31174 ) Change subject: pcu_l1_if: receive E1 connection parameters ...................................................................... Patch Set 4: (5 comments) File src/pcu_l1_if.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/d29f0c80_f731a1e3 PS1, Line 34: struct gsm_e1_subslot; > where does this come from? #include <osmocom/abis/e1_input. […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/27b545f5_f1338c1a PS1, Line 182: int pcu_l1if_get_ccu_conn_pars(struct gsm_e1_subslot *e1_link, uint8_t pdch_ts, uint8_t pdch_trx_no); > please keep same param names other functions. None has the pdch_ prefix. Done File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/ef2c11f7_aaa7f5d4 PS1, Line 81: struct gsm_e1_subslot e1_link; > is inherited by osmo-bsc you mean you are introducing this same problem now in osmo-pcu? I'm not rea […] I don't see it as a problem, but sure we can rename it. https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/cec1abd4_b7786e4d PS1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) { > So we are further spreading the use of hardcoded values. […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/64fcd4eb_16547c37 PS1, Line 1027: e1_ccu_conn_pars = talloc_zero(tall_pcu_ctx, struct e1_ccu_conn_pars); > Yes, it my be the only place, but still it makes it more difficult for people trying to understand t […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f926b023205a9ecf78d8a8586d6ac21cc73eb0a Gerrit-Change-Number: 31174 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 17:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bsc_subscriber_conn_fsm: use subslot 0 in case of E1 full subslot

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31258 ) Change subject: bsc_subscriber_conn_fsm: use subslot 0 in case of E1 full subslot ...................................................................... bsc_subscriber_conn_fsm: use subslot 0 in case of E1 full subslot In classic E1 based GSM networks the audio is usually transfered through 16bkps I.460 subslots while 4 16kbps subslots are multiplexed into one E1 timeslot. However, there may be setups where still 16kbps subslots are used, but with 1 instead of 4 channels per timeslot. In those cases the bit offset is 0, while the rate is still 16kbps. Change-Id: I0d2bc44acaa8e5a28cccfdf7cfb945bf14a4ed30 Related: OS#5198 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/31258/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index a19be0c..5d4bb51 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -721,9 +721,15 @@ /* use dynamic RTPBRIDGE endpoint allocation in MGW */ epname = mgcp_client_rtpbridge_wildcard(mgcp_client); else { + uint8_t i460_bit_offs; + if (for_lchan->ts->e1_link.e1_ts_ss == E1_SUBSLOT_FULL) + i460_bit_offs = 0; + else + i460_bit_offs = for_lchan->ts->e1_link.e1_ts_ss*2; + epname = mgcp_client_e1_epname(conn, mgcp_client, for_lchan->ts->e1_link.e1_nr, for_lchan->ts->e1_link.e1_ts, 16, - for_lchan->ts->e1_link.e1_ts_ss*2); + i460_bit_offs); } conn->user_plane.mgw_endpoint = -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0d2bc44acaa8e5a28cccfdf7cfb945bf14a4ed30 Gerrit-Change-Number: 31258 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bts_trx_vty: use define constant E1_SUBSLOT_FULL instead magic number

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31257 ) Change subject: bts_trx_vty: use define constant E1_SUBSLOT_FULL instead magic number ...................................................................... bts_trx_vty: use define constant E1_SUBSLOT_FULL instead magic number Change-Id: I0be228d4473215c6bd36c668e0e10e64965732e7 --- M src/osmo-bsc/bts_trx_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/31257/1 diff --git a/src/osmo-bsc/bts_trx_vty.c b/src/osmo-bsc/bts_trx_vty.c index 118feca..84de9c5 100644 --- a/src/osmo-bsc/bts_trx_vty.c +++ b/src/osmo-bsc/bts_trx_vty.c @@ -69,7 +69,7 @@ e1_link->e1_nr = atoi(line); e1_link->e1_ts = atoi(ts); if (!strcmp(ss, "full")) - e1_link->e1_ts_ss = 255; + e1_link->e1_ts_ss = E1_SUBSLOT_FULL; else e1_link->e1_ts_ss = atoi(ss); } @@ -773,7 +773,7 @@ if (!e1_link->e1_ts) return; - if (e1_link->e1_ts_ss == 255) + if (e1_link->e1_ts_ss == E1_SUBSLOT_FULL) vty_out(vty, "%se1 line %u timeslot %u sub-slot full%s", prefix, e1_link->e1_nr, e1_link->e1_ts, VTY_NEWLINE); else -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0be228d4473215c6bd36c668e0e10e64965732e7 Gerrit-Change-Number: 31257 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ggsn[master]: debian/libgtp6.shlibs: new file

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31256 ) Change subject: debian/libgtp6.shlibs: new file ...................................................................... debian/libgtp6.shlibs: new file List the most recent library version where new symbols where added, so debian properly upgrades libgtp6 when upgrading osmo-sgsn from the version that is currently in Debian to a version from the Osmocom repositories. Closes: OS#5318 Change-Id: Ida5dae4655c0acaeb377bc9d556a2ac333bca10a --- A debian/libgtp6.shlibs 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/56/31256/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ida5dae4655c0acaeb377bc9d556a2ac333bca10a Gerrit-Change-Number: 31256 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ggsn[master]: debiN/libgtp6.shlibs: new file

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31256 ) Change subject: debiN/libgtp6.shlibs: new file ...................................................................... debiN/libgtp6.shlibs: new file List the most recent library version where new symbols where added, so debian properly upgrades libgtp6 when upgrading osmo-sgsn from the version that is currently in Debian to a version from the Osmocom repositories. Closes: OS#5318 Change-Id: Ida5dae4655c0acaeb377bc9d556a2ac333bca10a --- A debian/libgtp6.shlibs 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/56/31256/1 diff --git a/debian/libgtp6.shlibs b/debian/libgtp6.shlibs new file mode 100644 index 0000000..43d45e7 --- /dev/null +++ b/debian/libgtp6.shlibs @@ -0,0 +1,2 @@ +# Most recent version of the package that added new symbols (OS#5318) +libgtp 6 libgtp6 (>= 1.8.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ida5dae4655c0acaeb377bc9d556a2ac333bca10a Gerrit-Change-Number: 31256 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libasn1c[master]: debian/control: replace, conflict: osmo-libasn1c

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/31255 ) Change subject: debian/control: replace, conflict: osmo-libasn1c ...................................................................... debian/control: replace, conflict: osmo-libasn1c In debian, this Osmocom fork of libasn1c is packaged as osmo-libasn1c. Add related Replaces: and Conflicts: to debian/control, so there is no error when installing osmo-libasn1c from Debian first, then configuring the Osmocom package repositories and trying to install libasn1c from there. Fix for: Preparing to unpack .../08-libasn1c1_0.9.34.1.71cb.202302010006_amd64.deb ... Unpacking libasn1c1:amd64 (0.9.34.1.71cb.202302010006) ... dpkg: error processing archive /tmp/apt-dpkg-install-8zK3sm/08-libasn1c1_0.9.34.1.71cb.202302010006_amd64.deb (--unpack): trying to overwrite '/usr/lib/x86_64-linux-gnu/libasn1c.so.1.0.1', which is also in package osmo-libasn1c1:amd64 0.9.32-1+b1 dpkg-deb: error: paste subprocess was killed by signal (Broken pipe) Related: OS#5318 Related: https://salsa.debian.org/debian-mobcom-team/osmo-libasn1c/-/blob/master/deb… Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages Change-Id: I5116df35b5819c22a184057cdf6ed756974d6388 --- M debian/control 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/55/31255/1 diff --git a/debian/control b/debian/control index 3b392be..8b71f81 100644 --- a/debian/control +++ b/debian/control @@ -1,4 +1,6 @@ Source: libasn1c +Conflicts: osmo-libasn1c +Replaces: osmo-libasn1c Section: libs Priority: extra Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> @@ -11,6 +13,8 @@ Homepage: https://projects.osmocom.org/projects/libasn1c Package: libasn1c1 +Conflicts: osmo-libasn1c1 +Replaces: osmo-libasn1c1 Section: libs Architecture: any Multi-Arch: same @@ -19,6 +23,8 @@ Description: asn1c runtime code as shared library Package: libasn1c-dbg +Conflicts: osmo-libasn1c-dbg +Replaces: osmo-libasn1c-dbg Section: debug Architecture: any Multi-Arch: same @@ -26,6 +32,8 @@ Description: asn1c runtime code as shared library Package: libasn1c-dev +Conflicts: osmo-libasn1c-dev +Replaces: osmo-libasn1c-dev Section: libdevel Architecture: any Multi-Arch: same -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I5116df35b5819c22a184057cdf6ed756974d6388 Gerrit-Change-Number: 31255 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: e1_input: add define constant for full subslot (whole E1 timeslot)

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31254 ) Change subject: e1_input: add define constant for full subslot (whole E1 timeslot) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I62725420d1cb2803b87fe5aa5e6ca1f3740be9eb Gerrit-Change-Number: 31254 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 15:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: obs: git.py: fix f-string

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31253 ) Change subject: obs: git.py: fix f-string ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaaedf019012d77e4a385054532d1d10659ef8e76 Gerrit-Change-Number: 31253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Feb 2023 15:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023