Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31422 )
Change subject: ttcn3-pgw-test: update open5gs-{nrf,smf,upf} config files
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-pgw-test/open5gs-smf.yaml:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3825):
https://gerrit.osmocom.org/c/docker-playground/+/31422/comment/f73a5ce4_a67…
PS1, Line 235: # - Use SCP if SCP avaiable. Otherwise NRF is used.
'avaiable' may be misspelled - perhaps 'available'?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I27adbab6a6b95ddf4c6d39803e4f7dd079f11a4c
Gerrit-Change-Number: 31422
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 20 Feb 2023 17:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31413 )
Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test
......................................................................
Patch Set 1:
(2 comments)
File open5gs-latest/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/31413/comment/f1b64eb1_f44…
PS1, Line 34: crate
> create
Done, see also: https://gerrit.osmocom.org/c/docker-playground/+/31421.
https://gerrit.osmocom.org/c/docker-playground/+/31413/comment/cc7e61b5_41d…
PS1, Line 35: ARG username=osmocom
> what's the advantage of making this an argument, instead of just hardcoding a username?
I don't know as I simply copied these lines from open5gs-master/Dockerfile :)
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079
Gerrit-Change-Number: 31413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 17:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/31413
to look at the new patch set (#2).
Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test
......................................................................
open5gs-latest: add osmocom user for ttcn3-pgw-test
In ttcn3-pgw-test we're running open5gs-upfd as a non-root user.
We do have this user in open5gs-master, but not in open5gs-latest.
Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079
Related: OS#5913
---
M open5gs-latest/Dockerfile
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/31413/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079
Gerrit-Change-Number: 31413
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31420
to look at the new patch set (#2).
Change subject: rlcmac: ul_tbf: Answer Pkt Ul Ack/Nack poll with Pkt Ctrl Ack
......................................................................
rlcmac: ul_tbf: Answer Pkt Ul Ack/Nack poll with Pkt Ctrl Ack
Related: OS#5500
Change-Id: I833d0f189c06d093ce9bd4c36c37024cf5cb6446
---
M include/osmocom/gprs/rlcmac/rlcmac_enc.h
M include/osmocom/gprs/rlcmac/tbf_ul.h
M src/rlcmac/rlcmac.c
M src/rlcmac/rlcmac_enc.c
M src/rlcmac/sched.c
M src/rlcmac/tbf_ul.c
M tests/rlcmac/rlcmac_prim_test.c
M tests/rlcmac/rlcmac_prim_test.err
M tests/rlcmac/rlcmac_prim_test.ok
9 files changed, 119 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/20/31420/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I833d0f189c06d093ce9bd4c36c37024cf5cb6446
Gerrit-Change-Number: 31420
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 1:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/db63200b_f2722efe
PS1, Line 1261: resp_msg->len != GSM_HR_BYTES + 1
> makes sense to use OSMO_UNLIKELY here
You can actually have 1 conditional block level less, all of it under UNLIKELY:
if (OSMO_UNLIKELY(osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_SPEECH_H_V1_RFC5993) && resp_msg->len != GSM_HR_BYTES + 1) {
...
}
Then you can do early return on each case, and everything looks way simplier.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 16:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment