Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 )
Change subject: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3
Gerrit-Change-Number: 31407
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 19:21:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31351 )
Change subject: rlcmac: Handle SI13 from L1CTL
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31351/comment/1ddca99e_d44a0b84
PS3, Line 307: memcpy
We may want to memcmp() the given *si13 with the existing SI13 (if si13_available) before trying to decode potentially unchanged bitstream.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31351
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ifaddf0e6e5cad7ea25672804c83c254579874813
Gerrit-Change-Number: 31351
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 19:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31424 )
Change subject: ttcn3-pgw-test: make all directories writable by all users
......................................................................
ttcn3-pgw-test: make all directories writable by all users
When running jenkins.sh as root or any other user with UID different
than UID=1000 of the 'osmocom' user we have in open5gs-{master,latest}
images, programs spawned by osmo-uecups-daemon (e.g. ping) may fail to
start. In such cases, osmo-uecups-daemon reports unexpected program
termination with exit code=512. This is happening because the
stdout and stderr of a spawned program are being redirected to
"$VOL_BASE_DIR/pgw-tester/TESTCASE.prog.std{out,err}", for which
the 'osmocom' user needs to have write permissions.
A simple solution is to run 'chmod 777' on all subdirs of $VOL_BASE_DIR.
Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648
Related: OS#5913
---
M ttcn3-pgw-test/jenkins.sh
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/24/31424/1
diff --git a/ttcn3-pgw-test/jenkins.sh b/ttcn3-pgw-test/jenkins.sh
index 58cfbbd..0b9f36d 100755
--- a/ttcn3-pgw-test/jenkins.sh
+++ b/ttcn3-pgw-test/jenkins.sh
@@ -19,6 +19,9 @@
cp upfd.sh $VOL_BASE_DIR/pgw/
cp upfd-setup.sh $VOL_BASE_DIR/pgw/
+# make all directories writable by all users
+chmod 777 $(find $VOL_BASE_DIR -type d)
+
network_create
network_replace_subnet_in_configs
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648
Gerrit-Change-Number: 31424
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/31422
to look at the new patch set (#2).
Change subject: ttcn3-pgw-test: update open5gs-{nrf,smf,upf} config files
......................................................................
ttcn3-pgw-test: update open5gs-{nrf,smf,upf} config files
As stated in the ticket, both open5gs-{nrf,smf} daemons refuse to
start since build #326 because of the following error:
[sbi] ERROR: TLS enabled but no server key (../lib/sbi/context.c:186)
The problem is that the recent open5gs (v2.6.0-39-g22be888 at the
moment of writing) is attempting to employ TLS verification for SBI
even if it's not explicitly configured in the config files.
commit 05fbaf69587488e53b5e741a9ada9f9fa5749322
Author: Sukchan Lee <acetcom(a)gmail.com>
Date: Sat Feb 18 10:58:29 2023 +0900
[SBI] HTTP2-TLS verification - ConfFile Changed
Our config files are slightly outdated, so let's take a chance
to update them and specify the missing TLS params. Check out
open5gs-{nrf,smf,upf}.yaml from the latest git version.
The updated files are confirmed to work with both:
* latest release for Debian v2.5.8, and
* latest git version v2.6.0-39-g22be888.
Change-Id: I27adbab6a6b95ddf4c6d39803e4f7dd079f11a4c
Related: OS#5913
---
M ttcn3-pgw-test/open5gs-nrf.yaml
M ttcn3-pgw-test/open5gs-smf.yaml
M ttcn3-pgw-test/open5gs-upf.yaml
3 files changed, 750 insertions(+), 174 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/31422/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I27adbab6a6b95ddf4c6d39803e4f7dd079f11a4c
Gerrit-Change-Number: 31422
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31423 )
Change subject: L1 IF: Use enums from libosmocore
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31423/comment/f08bf114_8d397022
PS1, Line 770: info_ind->nse_timer[NS_TOUT_TNS_BLOCK], info_ind->nse_timer[NS_TOUT_TNS_BLOCK_RETRIES],
> for stuff related to PCUIF, you need to add new definitions in pcu_l1_if. […]
So here we want definition redundancy, but in the other cases we don't. Wouldn't it also be better here to just use defs that already exist and serve our purpose?
I don't quite understand why this case would be different since it's also data passed on the same interface level
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40ffbfe34591133f514967dbc1c0a62540c52a7a
Gerrit-Change-Number: 31423
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 18:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment