February 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: open5gs-latest: install missing packages for ttcn3-pgw-test

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31412 ) Change subject: open5gs-latest: install missing packages for ttcn3-pgw-test ...................................................................... open5gs-latest: install missing packages for ttcn3-pgw-test These are present in open5gs-master, but missing in open5gs-latest. Change-Id: Ic9227033d65d621e7f6c5e196a9a8d6a1b73d5da Related: OS#5913 --- M open5gs-latest/Dockerfile 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index 683f7c7..870a170 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -11,6 +11,11 @@ apt-get install -y --no-install-recommends \ ca-certificates \ gnupg \ + iproute2 \ + iputils-ping \ + libcap2-bin \ + net-tools \ + sudo \ wget RUN echo "deb [signed-by=$OPEN5GS_KEY] $OPEN5GS_REPO/ ./" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic9227033d65d621e7f6c5e196a9a8d6a1b73d5da Gerrit-Change-Number: 31412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: osmo-uecups-latest: install missing iputils-ping

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31411 ) Change subject: osmo-uecups-latest: install missing iputils-ping ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia1b9124f09203c7dcf6d26dee78b09d5a139a04f Gerrit-Change-Number: 31411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:21:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-latest: install missing packages for ttcn3-pgw-test

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31412 ) Change subject: open5gs-latest: install missing packages for ttcn3-pgw-test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic9227033d65d621e7f6c5e196a9a8d6a1b73d5da Gerrit-Change-Number: 31412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:21:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm0808_dec_channel_type: fix dec of ch_rate_type

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31408 ) Change subject: gsm0808_dec_channel_type: fix dec of ch_rate_type ...................................................................... gsm0808_dec_channel_type: fix dec of ch_rate_type According to 3GPP TS 48.008 V16.0.0 § 3.2.2.11, the "Channel and rate type" fills the whole octet 4, so don't cut it off. This fixes decoding of e.g. GSM0808_SIGN_FULL_PREF_NO_CHANGE, which I noticed while writing a test. Related: OS#5911 Change-Id: Ib5fba18eb82736c4f52f315ae1197159b7090e69 --- M src/gsm/gsm0808_utils.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index 11e86b8..d8c275a 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -573,7 +573,7 @@ ct->ch_indctr = (*elem) & 0x0f; elem++; - ct->ch_rate_type = (*elem) & 0x0f; + ct->ch_rate_type = *elem; elem++; switch (ct->ch_indctr) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5fba18eb82736c4f52f315ae1197159b7090e69 Gerrit-Change-Number: 31408 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: tests: add test_gsm0808_enc_dec_channel_type_sign

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31409 ) Change subject: tests: add test_gsm0808_enc_dec_channel_type_sign ...................................................................... tests: add test_gsm0808_enc_dec_channel_type_sign Verify that we have the spare byte when encoding the signalling type. Related: OS#5911 Change-Id: Ied6e451d2e884412104cd9d530d0cd1b39f17f27 --- M tests/gsm0808/gsm0808_test.c 1 file changed, 40 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index a03f276..9a6de1e 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -1199,6 +1199,33 @@ msgb_free(msg); } +static void test_gsm0808_enc_dec_channel_type_sign(void) +{ + struct gsm0808_channel_type enc_ct = { + .ch_indctr = GSM0808_CHAN_SIGN, + .ch_rate_type = GSM0808_SIGN_FULL_PREF_NO_CHANGE, + }; + struct gsm0808_channel_type dec_ct = {}; + struct msgb *msg; + uint8_t ct_enc_expected[] = { GSM0808_IE_CHANNEL_TYPE, + 0x03, 0x03, 0x1a, 0x00 + }; + uint8_t rc_enc; + int rc_dec; + + msg = msgb_alloc(1024, "output buffer"); + rc_enc = gsm0808_enc_channel_type(msg, &enc_ct); + OSMO_ASSERT(rc_enc == 5); + OSMO_ASSERT(memcmp(ct_enc_expected, msg->data, msg->len) == 0); + + rc_dec = gsm0808_dec_channel_type(&dec_ct, msg->data + 2, msg->len - 2); + OSMO_ASSERT(rc_dec == 2); + OSMO_ASSERT(enc_ct.ch_indctr == dec_ct.ch_indctr); + OSMO_ASSERT(enc_ct.ch_rate_type == dec_ct.ch_rate_type); + + msgb_free(msg); +} + static void test_gsm0808_dec_channel_type_err(void) { struct gsm0808_channel_type ct; @@ -2684,6 +2711,7 @@ test_gsm0808_enc_dec_channel_type_data(); test_gsm0808_enc_dec_channel_type_data_asym_pref(); test_gsm0808_enc_dec_channel_type_speech(); + test_gsm0808_enc_dec_channel_type_sign(); test_gsm0808_dec_channel_type_err(); test_gsm0808_enc_dec_encrypt_info(); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ied6e451d2e884412104cd9d530d0cd1b39f17f27 Gerrit-Change-Number: 31409 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-trx[master]: Run struct_endianness.py

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31400 ) Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I7d571a042009a3d1befb71fdd490fdef39368066 --- M Transceiver52M/proto_trxd.h 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index d72cfdd..c250a74 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -48,9 +48,8 @@ reserved:1, version:4; #elif OSMO_IS_BIG_ENDIAN - uint8_t version:4, - reserved:1, - tn:3; +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t version:4, reserved:1, tn:3; #endif uint32_t fn; /* big endian */ } __attribute__ ((packed)); @@ -86,9 +85,8 @@ modulation:4, idle:1; #elif OSMO_IS_BIG_ENDIAN - uint8_t idle:1, - modulation:4, - tsc:3; +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t idle:1, modulation:4, tsc:3; #endif int16_t ci; /* big endian, in centiBels */ } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7d571a042009a3d1befb71fdd490fdef39368066 Gerrit-Change-Number: 31400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: make all directories writable by all users

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31424 ) Change subject: ttcn3-pgw-test: make all directories writable by all users ...................................................................... Patch Set 1: (1 comment) File ttcn3-pgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/31424/comment/9f8ac82d_c16… PS1, Line 23: chmod 777 $(find $VOL_BASE_DIR -type d) why not "chmod -R 777 $VOL_BASE_DIR" instead, so the files can also be modified? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Gerrit-Change-Number: 31424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:16:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in docker-playground[master]: ttcn3-pgw-test: update open5gs-{nrf,smf,upf} config files

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31422 ) Change subject: ttcn3-pgw-test: update open5gs-{nrf,smf,upf} config files ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I27adbab6a6b95ddf4c6d39803e4f7dd079f11a4c Gerrit-Change-Number: 31422 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-latest: add osmocom user for ttcn3-pgw-test

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31413 ) Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Gerrit-Change-Number: 31413 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: log osmo_fsm timeouts

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31433 to look at the new patch set (#4). Change subject: log osmo_fsm timeouts ...................................................................... log osmo_fsm timeouts set osmo_fsm_log_timeouts(true); Change-Id: Ic1ca03f06fbdef5a3fbe503e4414a780eb3e0fcc --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/33/31433/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic1ca03f06fbdef5a3fbe503e4414a780eb3e0fcc Gerrit-Change-Number: 31433 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023