February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: jobs/gerrit-pipeline-endianness: new job

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31418 ) Change subject: jobs/gerrit-pipeline-endianness: new job ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie12ef58905e5cdf1fb6816b59efb65c0e56b5e8d Gerrit-Change-Number: 31418 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:51:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-bsc-nat[master]: DO NOT MERGE: test struct_endianness CI

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/31416 ) Change subject: DO NOT MERGE: test struct_endianness CI ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/31416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I91625b54ab2698504340f627c8473e2967868f6d Gerrit-Change-Number: 31416 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: add vty statsd support

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31298 ) Change subject: mobile: add vty statsd support ...................................................................... mobile: add vty statsd support Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 --- M src/host/layer23/src/common/vty.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index 48d07b3..396d4cc 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -44,6 +44,7 @@ #include <osmocom/bb/mobile/gsm480_ss.h> #include <osmocom/bb/mobile/gsm411_sms.h> #include <osmocom/vty/telnet_interface.h> +#include <osmocom/vty/stats.h> #include <osmocom/vty/misc.h> bool l23_vty_reading = false; @@ -536,6 +537,9 @@ if (app_supp_opt & L23_OPT_TAP) l23_vty_init_gsmtap(); + if (app_supp_opt & L23_OPT_VTY) + osmo_stats_vty_add_cmds(); + install_node(&ms_node, config_write_ms_node_cb); install_element(MS_NODE, &cfg_ms_layer2_cmd); install_element(MS_NODE, &cfg_ms_shutdown_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 Gerrit-Change-Number: 31298 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: add vty statsd support

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31298 ) Change subject: mobile: add vty statsd support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 Gerrit-Change-Number: 31298 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:49:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Run struct_endianness.py

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31403 ) Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 --- M src/host/gprsdecode/rlcmac.h M src/host/layer23/include/osmocom/bb/common/sim.h 2 files changed, 49 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/gprsdecode/rlcmac.h b/src/host/gprsdecode/rlcmac.h index 2381d77..41c0dec 100644 --- a/src/host/gprsdecode/rlcmac.h +++ b/src/host/gprsdecode/rlcmac.h @@ -2,6 +2,7 @@ #include <stdint.h> #include <stdbool.h> +#include <osmocom/core/endian.h> #define OLD_TIME 2000 @@ -16,10 +17,16 @@ }; struct gprs_lime { +#if OSMO_IS_LITTLE_ENDIAN uint8_t li:6, m:1, e:1; uint8_t used; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t e:1, m:1, li:6; + uint8_t used; +#endif } __attribute__ ((packed)); struct gprs_frag { diff --git a/src/host/layer23/include/osmocom/bb/common/sim.h b/src/host/layer23/include/osmocom/bb/common/sim.h index 321baf4..35b48f4 100644 --- a/src/host/layer23/include/osmocom/bb/common/sim.h +++ b/src/host/layer23/include/osmocom/bb/common/sim.h @@ -18,6 +18,7 @@ #pragma once #include <osmocom/gsm/protocol/gsm_04_08.h> +#include <osmocom/core/endian.h> /* 9.2 commands */ #define GSM1111_CLASS_GSM 0xa0 @@ -211,6 +212,7 @@ } __attribute__ ((packed)); struct gsm1111_response_mfdf_gsm { +#if OSMO_IS_LITTLE_ENDIAN uint8_t file_char; uint8_t num_df; uint8_t num_ef; @@ -229,10 +231,24 @@ rfu5:3, unblk2_init:1; uint8_t more_data[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t file_char; + uint8_t num_df; + uint8_t num_ef; + uint8_t num_codes; + uint8_t rfu1; + uint8_t chv1_init:1, rfu2:3, chv1_remain:4; + uint8_t unblk1_init:1, rfu3:3, unblk1_remain:4; + uint8_t chv2_init:1, rfu4:3, chv2_remain:4; + uint8_t unblk2_init:1, rfu5:3, unblk2_remain:4; + uint8_t more_data[0]; +#endif } __attribute__ ((packed)); /* Section 9.2.1 (response to selecting EF) */ struct gsm1111_response_ef { +#if OSMO_IS_LITTLE_ENDIAN uint16_t rfu1; uint16_t file_size; uint16_t file_id; @@ -250,6 +266,20 @@ rfu4:5; uint8_t length; uint8_t structure; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint16_t rfu1; + uint16_t file_size; + uint16_t file_id; + uint8_t tof; + uint8_t inc_allowed; + uint8_t acc_read:4, acc_update:4; + uint8_t acc_inc:4, rfu2:4; + uint8_t acc_reha:4, acc_inval:4; + uint8_t rfu4:5, ru_inval:1, rfu3:1, not_inval:1; + uint8_t length; + uint8_t structure; +#endif } __attribute__ ((packed)); /* Section 10.3.17 */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 Gerrit-Change-Number: 31403 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Cosmetic: fix encoding of ui-experiment/font.h

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31402 ) Change subject: Cosmetic: fix encoding of ui-experiment/font.h ...................................................................... Cosmetic: fix encoding of ui-experiment/font.h Remove characters 0x80 - 0xff from comments in this source file, as they can't be parsed as UTF-8. This causes struct_endianness.py to error on the file, git and gerrit can't display a proper diff and treat it as binary file, etc. Related: OS#5884 Change-Id: I0daebccf819595ee64fb4c9713a4f0ce219c58be --- M src/target/ui-experiment/font.h 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/ui-experiment/font.h b/src/target/ui-experiment/font.h index 5dc6eae..c75a0f8 100644 --- a/src/target/ui-experiment/font.h +++ b/src/target/ui-experiment/font.h Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0daebccf819595ee64fb4c9713a4f0ce219c58be Gerrit-Change-Number: 31402 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: steve-m <steve(a)steve-m.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Cosmetic: fix encoding of ui-experiment/font.h

by fixeria

Attention is currently required from: osmith, steve-m. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31402 ) Change subject: Cosmetic: fix encoding of ui-experiment/font.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0daebccf819595ee64fb4c9713a4f0ce219c58be Gerrit-Change-Number: 31402 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: steve-m <steve(a)steve-m.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: steve-m <steve(a)steve-m.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 08:24:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-master: fix comment in Dockerfile

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31421 ) Change subject: open5gs-master: fix comment in Dockerfile ...................................................................... open5gs-master: fix comment in Dockerfile Change-Id: I34577dd39051f429af8257afe075f22b20cfdfe4 Related: OS#5913 --- M open5gs-master/Dockerfile 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index 54c7fd1..878c655 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -16,7 +16,7 @@ net-tools && \ apt-get clean -# crate user +# create a user ARG username=osmocom RUN useradd -m --uid=1000 ${username} && \ echo "${username} ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/${username} && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I34577dd39051f429af8257afe075f22b20cfdfe4 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: osmo-uecups-latest: install missing iputils-ping

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31411 ) Change subject: osmo-uecups-latest: install missing iputils-ping ...................................................................... osmo-uecups-latest: install missing iputils-ping ping is needed for ttcn3-pgw-test. In the case of osmo-uecups-master it's available from the parent $DISTRO-build image, but for the -latest it needs to be installed by the inherited image itself. Change-Id: Ia1b9124f09203c7dcf6d26dee78b09d5a139a04f Related: OS#5913 --- M osmo-uecups-latest/Dockerfile 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/osmo-uecups-latest/Dockerfile b/osmo-uecups-latest/Dockerfile index a46ce06..9546720 100644 --- a/osmo-uecups-latest/Dockerfile +++ b/osmo-uecups-latest/Dockerfile @@ -9,6 +9,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + iputils-ping \ osmo-uecups && \ apt-get clean \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia1b9124f09203c7dcf6d26dee78b09d5a139a04f Gerrit-Change-Number: 31411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-latest: add osmocom user for ttcn3-pgw-test

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31413 ) Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test ...................................................................... open5gs-latest: add osmocom user for ttcn3-pgw-test In ttcn3-pgw-test we're running open5gs-upfd as a non-root user. We do have this user in open5gs-master, but not in open5gs-latest. Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Related: OS#5913 --- M open5gs-latest/Dockerfile 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index 870a170..7c385e2 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -30,3 +30,9 @@ apt-get install -y \ mongodb-org \ open5gs + +# create a user +ARG username=osmocom +RUN useradd -m --uid=1000 ${username} && \ + echo "${username} ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/${username} && \ + chmod 0440 /etc/sudoers.d/${username} -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Gerrit-Change-Number: 31413 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023