February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 ) Change subject: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED ...................................................................... rlcmac: tbf_ul: Allow sending UL data if in state FINISHED This can happen for instance if MS sent al the data but PCU didn't receive it all (some it was lost) so it can still keep asking the MS to submit data. In this case, the MS shall attempt retransmit of some unacked data. Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3 --- M src/rlcmac/tbf_ul.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 993f694..ce7ac1f 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -133,7 +133,8 @@ return false; st = gprs_rlcmac_tbf_ul_state(ul_tbf); - return (st == GPRS_RLCMAC_TBF_UL_ST_FLOW); + return (st == GPRS_RLCMAC_TBF_UL_ST_FLOW || + st == GPRS_RLCMAC_TBF_UL_ST_FINISHED); } static int gprs_rlcmac_ul_tbf_update_window(struct gprs_rlcmac_ul_tbf *ul_tbf, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3 Gerrit-Change-Number: 31407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Handle SI13 from L1CTL

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31351 ) Change subject: rlcmac: Handle SI13 from L1CTL ...................................................................... rlcmac: Handle SI13 from L1CTL Change-Id: Ifaddf0e6e5cad7ea25672804c83c254579874813 --- M include/osmocom/gprs/rlcmac/rlcmac_private.h M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c 3 files changed, 44 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/rlcmac/rlcmac_private.h b/include/osmocom/gprs/rlcmac/rlcmac_private.h index 80461da..e2d2494 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_private.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_private.h @@ -7,10 +7,12 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/tdef.h> +#include <osmocom/gsm/gsm48_rest_octets.h> #include <osmocom/gprs/rlcmac/rlcmac_prim.h> #include <osmocom/gprs/rlcmac/rlcmac.h> #include <osmocom/gprs/rlcmac/coding_scheme.h> +#include <osmocom/gprs/rlcmac/csn1_defs.h> /* 3GPP TS 44.064 § 8.3 TLLI assignment procedures */ #define GPRS_RLCMAC_TLLI_UNASSIGNED (0xffffffff) @@ -73,6 +75,11 @@ struct { struct gprs_rlcmac_pdch_ulc *ulc[8]; } sched; + + /* Last SI13 received from BCCH: */ + bool si13_available; + uint8_t si13[GSM_MACBLOCK_LEN]; + SI13_RestOctets_t si13ro; }; extern struct gprs_rlcmac_ctx *g_ctx; @@ -82,6 +89,7 @@ struct gprs_rlcmac_dl_tbf *gprs_rlcmac_find_dl_tbf_by_tfi(uint8_t dl_tfi); struct gprs_rlcmac_ul_tbf *gprs_rlcmac_find_ul_tbf_by_tfi(uint8_t ul_tfi); int gprs_rlcmac_handle_ccch_imm_ass(const struct gsm48_imm_ass *ia); +int gprs_rlcmac_handle_bcch_si13(const struct gsm48_system_information_type_13 *si13); int gprs_rlcmac_handle_gprs_dl_block(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, enum gprs_rlcmac_coding_scheme cs); diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index cff7c79..39e5c9e 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -299,6 +299,25 @@ return rc; } +int gprs_rlcmac_handle_bcch_si13(const struct gsm48_system_information_type_13 *si13) +{ + int rc; + + LOGRLCMAC(LOGL_DEBUG, "Rx SI13 from lower layers\n"); + memcpy(g_ctx->si13, si13, GSM_MACBLOCK_LEN); + + rc = osmo_gprs_rlcmac_decode_si13ro(&g_ctx->si13ro, si13->rest_octets, + GSM_MACBLOCK_LEN - offsetof(struct gsm48_system_information_type_13, rest_octets)); + if (rc < 0) { + LOGRLCMAC(LOGL_ERROR, "Error decoding SI13: %s\n", + osmo_hexdump((uint8_t *)si13, GSM_MACBLOCK_LEN)); + return rc; + } + + g_ctx->si13_available = true; + return rc; +} + static int gprs_rlcmac_handle_pkt_ul_ack_nack(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, const RlcMacDownlink_t *dl_block) { const Packet_Uplink_Ack_Nack_t *ack = &dl_block->u.Packet_Uplink_Ack_Nack; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 1707578..dcf4424 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -495,10 +495,16 @@ /* TODO: check if it's IMM_ASS: */ int rc; - if (rlcmac_prim->l1ctl.ccch_data_ind.data[2] == GSM48_MT_RR_IMM_ASS) + switch (rlcmac_prim->l1ctl.ccch_data_ind.data[2]) { + case GSM48_MT_RR_IMM_ASS: rc = gprs_rlcmac_handle_ccch_imm_ass((struct gsm48_imm_ass *)rlcmac_prim->l1ctl.ccch_data_ind.data); - else + break; + case GSM48_MT_RR_SYSINFO_13: + rc = gprs_rlcmac_handle_bcch_si13((struct gsm48_system_information_type_13 *)rlcmac_prim->l1ctl.ccch_data_ind.data); + break; + default: rc = -ENOTSUP; + } return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifaddf0e6e5cad7ea25672804c83c254579874813 Gerrit-Change-Number: 31351 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 ) Change subject: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3 Gerrit-Change-Number: 31407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Handle SI13 from L1CTL

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31351 ) Change subject: rlcmac: Handle SI13 from L1CTL ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifaddf0e6e5cad7ea25672804c83c254579874813 Gerrit-Change-Number: 31351 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp_sap_up(): ignore PCSTATE.ind

by pespin

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 ) Change subject: sccp_sap_up(): ignore PCSTATE.ind ...................................................................... Patch Set 4: (1 comment) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429/comment/89788ca0_75e48fb6 PS4, Line 434: LOGP(DMAIN, LOGL_DEBUG, "Ignoring: SCCP USER SAP: %s\n", osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); > this is worded a bit strange, IMHO. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I547387a5cc14ccb506be04ac785e6807fc4e6a96 Gerrit-Change-Number: 31429 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: ranap_rab_ass_test: fix use of deprecated ranap_cn_rx_co_decode()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31432 ) Change subject: ranap_rab_ass_test: fix use of deprecated ranap_cn_rx_co_decode() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iea41b027d047b2da52d0733fce4c9d75bb74fe48 Gerrit-Change-Number: 31432 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:09:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in osmo-hnbgw[master]: context map: introduce RUA and SCCP FSMs to fix leaks

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 ) Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: I find this all quite hard to review. Could you try splitting into several patches? The commit message already indicates you are doing lots of different stuff here. File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/e2433b74_007874dc PS5, Line 90: /* RUA contxt ID used in RUA messages to/from the hnb_gw. */ context File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/5cb69b97_c288360f PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" }, Drop "id-" prefix -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: add design charts for new context map FSMs

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 ) Change subject: add design charts for new context map FSMs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File doc/charts/hnbgw_context_map_fsm.dot: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430/comment/2d556788_542fcbe5 PS2, Line 2: rankdir=TB Extra indentation in this block like you did in other files may be welcome. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I661bf65d79972a732c52732934095e8bfcd99694 Gerrit-Change-Number: 31430 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 09:50:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: various comment tweaks

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31427 ) Change subject: various comment tweaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie40aa672948062282c566c90300f6e96963e05ec Gerrit-Change-Number: 31427 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 09:48:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: drop obsolete fixme comment

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31426 ) Change subject: drop obsolete fixme comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35f4cedf6f37be797dcd48e816461d3b1d9db54 Gerrit-Change-Number: 31426 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 09:46:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023