February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: pcu_l1_if: get rid of l1if checks

by pespin

Attention is currently required from: msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31362 ) Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:09:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: To me the BSC telling which phy driver to use looks really like BSC knowing about the PCU implementation, which looks wrong. I don't see what's the problem with configuring osmo-pcu through VTY to tell it to operatin in a specific mode, which in general shouldn't change for a given setup? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:08:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31439 ) Change subject: bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup ...................................................................... bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup Fix that the test was torn down too early, before DLCX messages were received from OsmoBSC. This caused a race condition that sometimes failed the test with: VirtMGW-MGCP-0(1996)@e5a096d6b4ff: Dynamic test case error: Sending data on the connection of port MGCP_CLIENT to 1999:MGCP failed. (Broken pipe) Related: OS#5787 Fixes: 7a8594a8 ("bsc: TC_ho_in_fail_mgw_mdcx_timeout: new test") Change-Id: If47fa3e0204ce841c79a67dd78a1c53d04e4a586 --- M bsc/BSC_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/31439/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 9a2718a..45968ad 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6347,6 +6347,15 @@ if (g_pars.expect_ho_fail_lchan_est) { BSSAP.receive(tr_BSSMAP_HandoverFailure); setverdict(pass); + + /* When we let MGCP MDCX run into a timeout, it's still in the + * queue and additionally after BSSAP HandoverFailure, two DLXC + * get sent. */ + if (g_pars.ignore_mgw_mdcx) { + MGCP.receive(tr_MDCX); + MGCP.receive(tr_DLCX); + MGCP.receive(tr_DLCX); + } return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If47fa3e0204ce841c79a67dd78a1c53d04e4a586 Gerrit-Change-Number: 31439 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: add new API call l1if_disconnect_pdch

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31438 ) Change subject: pcu_l1_if_phy: add new API call l1if_disconnect_pdch ...................................................................... pcu_l1_if_phy: add new API call l1if_disconnect_pdch Change-Id: I4cc72f032f0abdd5833cdd3b1fe68c69394d89a4 --- M src/pcu_l1_if.cpp M src/pcu_l1_if_phy.h 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/31438/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 2384600..346d449 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -920,6 +920,9 @@ if (pdch->is_enabled()) { pcu_tx_act_req(bts, pdch, 0); pdch->disable(); + if (the_pcu->phy_ops && the_pcu->phy_ops->l1if_disconnect_pdch + && (info_ind->flags & PCU_IF_FLAG_SYSMO)) + the_pcu->phy_ops->l1if_disconnect_pdch(bts->trx[trx_nr].fl1h); } } } diff --git a/src/pcu_l1_if_phy.h b/src/pcu_l1_if_phy.h index 4187fbd..02bc158 100644 --- a/src/pcu_l1_if_phy.h +++ b/src/pcu_l1_if_phy.h @@ -22,6 +22,10 @@ uint8_t *data, uint8_t len); int (*l1if_close_pdch)(void *obj); + /* Sompe PHYs require to disconnect the PDCH explicitly. This instructs the driver to release the resources + * while keeping the context alive until the PDCH is connected again using l1if_connect_pdch(). */ + int (*l1if_disconnect_pdch)(void *obj); + /* PHY initialization: This callback is called once in the early startup phase before the config file is * parsed. It is intended for preliminary initialization such as adding VTY confg options or calling library * initialization functions. The callback may be set to NULL in case no initialization is needed. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cc72f032f0abdd5833cdd3b1fe68c69394d89a4 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in osmo-pcu[master]: pcu_l1_if: get rid of l1if checks

by dexter

Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31362 ) Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... Patch Set 2: (2 comments) File src/osmo-bts-litecell15/lc15_l1_if.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31362/comment/cc282015_d645c2c9 PS1, Line 343: LOGP(DL1IF, LOGL_ERROR, "no fl1h context, tosseing mac block for TS=%u...\n", ts); > typo: tossing Done File src/osmo-bts-oc2g/oc2g_l1_if.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31362/comment/4b14cdf6_17b6a8cc PS1, Line 342: LOGP(DL1IF, LOGL_ERROR, "no fl1h context, tosseing mac block for TS=%u...\n", ts); > same Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 11:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-pcu[master]: pcu_l1_if: get rid of l1if checks

by dexter

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 to look at the new patch set (#2). Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... pcu_l1_if: get rid of l1if checks At the moment we check for the presence of l1if and skip calling the driver related function. Instead, the driver function should check the presence of l1if. Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 --- M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/osmobts_sock.c M src/pcu_l1_if.cpp 5 files changed, 52 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/62/31362/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[L] Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > what? I thought it was clear (at least to me) that the backend was to be selected using osmo-pcu VTY […] Hmm. sounds too simple to me. But then the user must configure the BTS type in osmo-bsc and osmo-pcu. When the BSC just tells the PCU which PHY to use things would be much easier. No need to configure anything at the PCU side. Just set up the PDCH and the E1 lines in osmo-bsc and thats it. To signal which PHY to use I would just add another primitive that is sent once on startup. It would essentially contain just an integer. I don't want to cram it in the info-ind since info-ind is sent multiple times. Also the flags in info-ind are not so suitable since they are limited. I didn't implement anything in that regard yet. Whats your idea on this? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in libosmo-abis[master]: e1_input: cleanup TS resources when timeslot type is changed

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31323 ) Change subject: e1_input: cleanup TS resources when timeslot type is changed ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icf84816460b8ceba43601594bcf504306606f4ed Gerrit-Change-Number: 31323 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 10:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Fix null ptr access in dl_tbf object

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31437 ) Change subject: rlcmac: Fix null ptr access in dl_tbf object ...................................................................... rlcmac: Fix null ptr access in dl_tbf object Fixes: Coverity CID#310022 Change-Id: I3817d9e77a440682fa2c538e0fbee295ffdbcfff --- M src/rlcmac/rlcmac.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/37/31437/1 diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index b273b68..260749c 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -404,7 +404,7 @@ dl_tbf = gprs_rlcmac_find_dl_tbf_by_tfi(rlc_dec.tfi); if (!dl_tbf) { - LOGPTBFDL(dl_tbf, LOGL_INFO, "Rx DL data for unknown dl_tfi=%u\n", data_hdr->tfi); + LOGRLCMAC(LOGL_INFO, "Rx DL data for unknown dl_tfi=%u\n", data_hdr->tfi); return -ENOENT; } LOGPTBFDL(dl_tbf, LOGL_DEBUG, "Rx new DL data\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3817d9e77a440682fa2c538e0fbee295ffdbcfff Gerrit-Change-Number: 31437 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_dl: Fix msgb null ptr access if dl block contains several...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31436 ) Change subject: rlcmac: tbf_dl: Fix msgb null ptr access if dl block contains several LLC frames ...................................................................... rlcmac: tbf_dl: Fix msgb null ptr access if dl block contains several LLC frames Fixes: Coverity CID#310023 Change-Id: I627724fda5b9ffcf13433ea69af908d725e94299 --- M src/rlcmac/tbf_dl.c 1 file changed, 23 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/36/31436/1 diff --git a/src/rlcmac/tbf_dl.c b/src/rlcmac/tbf_dl.c index 7fb4be9..3861cae 100644 --- a/src/rlcmac/tbf_dl.c +++ b/src/rlcmac/tbf_dl.c @@ -154,29 +154,29 @@ uint8_t len = blk->len; const struct gprs_rlcmac_rlc_block_info *rdbi = &blk->block_info; enum gprs_rlcmac_coding_scheme cs = blk->cs_last; - struct osmo_gprs_rlcmac_prim *rlcmac_prim; - - struct gprs_rlcmac_rlc_llc_chunk frames[16], *frame; + struct gprs_rlcmac_rlc_llc_chunk frames[16]; int i, num_frames = 0; int rc = 0; LOGPTBFDL(dl_tbf, LOGL_DEBUG, "Assembling frames: (len=%d)\n", len); - if (!dl_tbf->llc_rx_msg) { - rlcmac_prim = gprs_rlcmac_prim_alloc_grr_unitdata_ind( - dl_tbf->tbf.gre->tlli, NULL, GPRS_RLCMAC_LLC_PDU_MAX_LEN); - dl_tbf->llc_rx_msg = rlcmac_prim->oph.msg; - dl_tbf->llc_rx_msg->l3h = dl_tbf->llc_rx_msg->tail; - } else { - rlcmac_prim = msgb_rlcmac_prim(dl_tbf->llc_rx_msg); - } - num_frames = gprs_rlcmac_rlc_data_from_dl_data(rdbi, cs, data, &frames[0], ARRAY_SIZE(frames)); /* create LLC frames */ for (i = 0; i < num_frames; i++) { - frame = frames + i; + struct gprs_rlcmac_rlc_llc_chunk *frame = &frames[i]; + struct osmo_gprs_rlcmac_prim *rlcmac_prim; + + if (!dl_tbf->llc_rx_msg) { + rlcmac_prim = gprs_rlcmac_prim_alloc_grr_unitdata_ind(dl_tbf->tbf.gre->tlli, + NULL, + GPRS_RLCMAC_LLC_PDU_MAX_LEN); + dl_tbf->llc_rx_msg = rlcmac_prim->oph.msg; + dl_tbf->llc_rx_msg->l3h = dl_tbf->llc_rx_msg->tail; + } else { + rlcmac_prim = msgb_rlcmac_prim(dl_tbf->llc_rx_msg); + } if (frame->length) { LOGPTBFDL(dl_tbf, LOGL_DEBUG, "Frame %d " -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I627724fda5b9ffcf13433ea69af908d725e94299 Gerrit-Change-Number: 31436 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023