February 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: trau_pcu_ericsson_test: replace 64K CS1/CS2 testvectors

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31440 ) Change subject: trau_pcu_ericsson_test: replace 64K CS1/CS2 testvectors ...................................................................... trau_pcu_ericsson_test: replace 64K CS1/CS2 testvectors The CS1/CS2 testvectors for the 64K TRAU frame decoder are valid but the contained MAC block consits of noise. At the time when the test data was sampled it was not possible to get TRAU frames with valid content from the CCU. This has changed, so lets update the testvectors with ones that contain valid data. Change-Id: I0b8aef1ce1eca5b10601a0a655f7e3b00915d3cc Related: OS#5198 --- M tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c M tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok 2 files changed, 101 insertions(+), 85 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/40/31440/1 diff --git a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c index 986ab79..6c28269 100644 --- a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c +++ b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c @@ -1140,8 +1140,7 @@ int rc; struct er_gprs_trau_frame frame; - /* TRAU frame with CS1 block and correct CRC. CS1 one data itsself is - * noise. */ + /* TRAU frame with valid CS1 block and correct CRC */ const ubit_t bits_cs1[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, @@ -1152,44 +1151,46 @@ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 1, 0, 1, 1, 0, 0, - 0, 1, 0, 0, 1, 0, 0, 0, - 0, 0, 0, 1, 0, 1, 1, 1, - 1, 0, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 0, 1, 1, 1, 1, 0, - 1, 1, 1, 0, 1, 1, 1, 0, - 1, 0, 1, 0, 0, 1, 1, 1, - 1, 0, 1, 0, 0, 0, 1, 0, - 1, 0, 0, 1, 1, 0, 0, 1, - 1, 1, 1, 1, 0, 0, 0, 1, - 1, 0, 1, 0, 1, 1, 1, 0, - 0, 0, 1, 1, 0, 1, 0, 1, - 1, 0, 1, 1, 0, 0, 0, 1, + 0, 1, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, - 0, 0, 1, 1, 0, 1, 0, 1, - 1, 0, 0, 1, 1, 1, 0, 1, - 1, 1, 1, 0, 0, 1, 1, 1, - 0, 1, 1, 1, 0, 0, 1, 0, - 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 1, 1, 1, 1, 1, - 0, 0, 0, 0, 0, 0, 0, 1, - 1, 0, 1, 0, 1, 0, 1, 0, - 0, 1, 1, 0, 1, 1, 0, 1, - 1, 0, 0, 0, 1, 1, 0, 0, - 0, 1, 1, 1, 1, 0, 0, 0, - 1, 1, 1, 0, 0, 0, 0, 1, - 0, 0, 0, 0, 0, 0, 0, 1, - 1, 0, 0, 1, 1, 1, 0, 0, - 0, 0, 1, 1, 0, 1, 0, 1, - 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 0, 1, 1, 1, 0, 0, + 0, 0, 0, 0, 1, 0, 1, 1, + 1, 0, 0, 0, 0, 0, 0, 1, + 0, 0, 0, 0, 1, 0, 1, 0, + 1, 0, 1, 1, 1, 0, 1, 0, + 0, 0, 1, 1, 1, 0, 1, 1, + 0, 1, 1, 1, 1, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 0, 0, + 0, 1, 1, 1, 1, 1, 0, 1, + 0, 1, 1, 0, 1, 0, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, + /* [...] shortened since decode won't access filler bits after + * the TRAU frame. */ }; + /* TRAU frame with valid CS2 block and correct CRC */ const ubit_t bits_cs2[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, @@ -1199,52 +1200,51 @@ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 1, 0, 1, 0, 1, 1, 1, 0, - 1, 1, 0, 1, 0, 0, 0, 0, - 0, 0, 0, 1, 1, 0, 1, 0, - 1, 0, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, - 0, 0, 1, 1, 1, 1, 0, 1, - 1, 1, 1, 0, 1, 1, 1, 1, - 1, 0, 1, 0, 0, 0, 0, 1, - 0, 1, 0, 1, 1, 0, 0, 0, - 0, 0, 0, 1, 0, 0, 0, 0, - 0, 1, 0, 0, 0, 0, 1, 0, - 1, 1, 0, 0, 1, 1, 1, 0, - 1, 0, 1, 0, 0, 0, 0, 0, - 0, 1, 0, 1, 0, 1, 1, 1, - 0, 1, 0, 0, 1, 1, 1, 1, - 1, 0, 0, 0, 0, 0, 0, 0, - 1, 1, 0, 0, 1, 0, 0, 1, - 1, 0, 1, 1, 0, 1, 0, 1, - 0, 0, 1, 0, 0, 1, 1, 0, - 0, 0, 0, 1, 0, 1, 0, 1, - 0, 0, 1, 0, 0, 0, 0, 0, - 1, 0, 0, 1, 0, 0, 1, 0, - 0, 0, 0, 1, 1, 0, 1, 1, - 0, 0, 0, 1, 1, 1, 0, 0, - 1, 0, 0, 0, 1, 1, 0, 0, - 0, 0, 1, 1, 1, 0, 0, 0, + 1, 0, 1, 0, 1, 1, 0, 1, + 1, 1, 0, 1, 0, 1, 1, 1, + 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 0, 1, 0, 0, - 0, 1, 1, 1, 1, 1, 1, 0, - 1, 0, 0, 1, 1, 1, 0, 1, - 1, 0, 0, 1, 0, 1, 1, 1, - 0, 0, 0, 1, 1, 0, 1, 1, - 0, 1, 0, 0, 0, 1, 1, 1, - 0, 1, 0, 0, 1, 1, 1, 1, - 0, 1, 0, 1, 0, 0, 1, 0, - 0, 1, 1, 1, 0, 1, 1, 1, - 0, 0, 0, 0, 0, 0, 1, 0, - 1, 0, 0, 1, 1, 0, 1, 1, - 1, 1, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 0, 1, 1, 1, 0, 0, + 0, 0, 0, 0, 0, 0, 1, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + 1, 0, 0, 0, 0, 0, 1, 0, + 0, 1, 0, 0, 1, 0, 0, 0, + 0, 0, 1, 0, 1, 1, 1, 0, + 1, 1, 1, 0, 0, 1, 0, 0, + 1, 1, 1, 0, 1, 0, 0, 1, + 1, 1, 1, 0, 1, 0, 1, 1, + 1, 0, 0, 1, 1, 0, 1, 1, + 1, 1, 0, 1, 1, 0, 1, 1, + 1, 1, 0, 1, 1, 0, 1, 1, + 1, 0, 0, 1, 1, 0, 0, 0, + 1, 1, 0, 1, 1, 0, 1, 0, + 1, 0, 0, 1, 1, 0, 1, 1, + 0, 0, 0, 0, 0, 0, 1, 1, + 0, 0, 0, 1, 1, 0, 1, 1, + 1, 1, 0, 1, 1, 0, 1, 0, + 1, 1, 0, 1, 1, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 1, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 1, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + 0, 1, 0, 0, 0, 1, 0, 0, + 1, 1, 1, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 1, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 1, 1, + 0, 1, 0, 1, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 1, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, + 1, 1, 1, 1, 1, 1, 1, 1, /* [...] shortened since decode won't access filler bits after * the TRAU frame. */ }; diff --git a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok index 6d93eed..3d9666c 100644 --- a/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok +++ b/tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok @@ -2521,23 +2521,23 @@ ccu_data_ind.tav=00 ccu_data_ind.dbe=0 ccu_data_ind.cs_hdr=1 - ccu_data_ind.gprs.rx_lev=0 - ccu_data_ind.gprs.est_acc_del_dev=3 - ccu_data_ind.u.gprs.block_qual=7 - ccu_data_ind.u.gprs.parity_ok=0 + ccu_data_ind.gprs.rx_lev=63 + ccu_data_ind.gprs.est_acc_del_dev=0 + ccu_data_ind.u.gprs.block_qual=0 + ccu_data_ind.u.gprs.parity_ok=1 ccu_data_ind.u.data_len=23 - ccu_data_ind.data=dd9517653ed6b1367eb0e69e3b9df90356d9c6781c02e6 + ccu_data_ind.data=40074275717b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b ==> er_gprs_trau_frame_decode_64k_FT_DATA_test (CS2) - ccu_data_ind.tav=01 + ccu_data_ind.tav=02 ccu_data_ind.dbe=0 ccu_data_ind.cs_hdr=2 - ccu_data_ind.gprs.rx_lev=0 + ccu_data_ind.gprs.rx_lev=63 ccu_data_ind.gprs.est_acc_del_dev=0 - ccu_data_ind.u.gprs.block_qual=5 - ccu_data_ind.u.gprs.parity_ok=0 + ccu_data_ind.u.gprs.block_qual=0 + ccu_data_ind.u.gprs.parity_ok=1 ccu_data_ind.u.data_len=34 - ccu_data_ind.data=f3de176a2008cd15a8cb074cb692a1122461e3c470f8bff8e5a6638bcb2bb903653f + ccu_data_ind.data=00010449d09d5c5e676f6f676c6503636f6d0000010001881c802b2b2b2b2b2b2b00 ==> er_gprs_trau_frame_decode_64k_FT_DATA_test (AB) ccu_data_ind.tav=01 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b8aef1ce1eca5b10601a0a655f7e3b00915d3cc Gerrit-Change-Number: 31440 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[L] Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by laforge

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > To me the BSC telling which phy driver to use looks really like BSC knowing about the PCU implementa […] well, in the classic (12.21 based) information model, the BSC knows everything and it spreads its knowledge to the BTSs. And in case of BTS-colocated PCU, the BTS then passes things to the PCU (see how the NSVC are configured in osmo-bsc.cfg). In general I also like that, as it reduces the amount of things an operator needs to configure on each and every of their (potentially many) remote sites. We might also get back to fixeria's idea in the meeting today: have separte binaries like osmo-pcu-{rbs,sysmo,...} to avoid the problem. Many alternatives, I'm not deep enough into the topic to have a clear idea. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 14:18:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by laforge

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 14 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 14:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in osmo-hnbgw[master]: context map: introduce RUA and SCCP FSMs to fix leaks

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 ) Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/ce2ee4d9_2f263045 PS5, Line 22: enum map_rua_fsm_event { not critical, but this is where the ISO/OSI style request/indication naming could be useful to clearly see the direction of such an "event". the _RX_ are indications telling the FSM that something happens. Just like SCCP_DISC, HNB_LINK_LOST. Where TX_RANAP_MSG and _EV_PLEASE_DISCONNECT are requests to the FSM. File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/3a993d43_7a99de14 PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" }, > AFAIK the messages are called "id-Connect" in RUA, including the "id-", whatever the meaning may be No, the procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9.1.x. That "id-" some artefact of the asn.1 syntax, so they have differnt names for the identifier from the type name. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 14:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: log tweak

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31428 ) Change subject: log tweak ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > not sure we want that 'id-' prefix. That's just an artefact of auto-generated asn. […] The procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9.1.x. That "id-" some artefact of the asn.1 syntax, so they have differnt names for the identifier from the type name. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib6f8c46355d4748089e59c80fc1c8c736c887a26 Gerrit-Change-Number: 31428 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 14:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in osmo-hnbgw[master]: context map: introduce RUA and SCCP FSMs to fix leaks

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 ) Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: > I find this all quite hard to review. […] Maybe I can spend yet another hour to see if I can split off very simple things. But to split is essentially asking to re-implement this from scratch. Not sure if we have enough hours left to spend on this topic for that. Another idea is maybe i can place comments here in gerrit for each patch chunk? i did initially have two patches, one adding the FSMs and one moving from oph to ranap msgb, but that was a bunch of new code being added, then changed again *a lot* in the patch following right after that. Squashing them made the patch volume shrink *a lot*, and makes *a lot* more sense when reading the code. I spent many hours on keeping the two patches separate, and it was a complete waste of time in the end, so I'm a bit frustrated with trying to do big refactoring in small patches now. It's like asking to build a new house while some rotten moldy house is still standing in its place -- the new doors and windows will simply not fit in the old walls. I would encourage to review by following the message pipeline: - See that rua_to_scu() is now extremely simple. - See that the osmo_scu_prim composition for SCCP messages has moved from hnbgw_rua.c to context_map_sccp.c, and follow the path of rua_to_scu() to osmo_sccp_user_sap_down(). - Notice that everything connection-oriented feeds into FSM events, and that their data arg is in OTC_SELECT. The FSM charts are looking pretty complex too, not sure if it helps but I uploaded them for convenience: https://people.osmocom.org/neels/veY1eiNg/hnbgw_context_map.png https://people.osmocom.org/neels/veY1eiNg/hnbgw_context_map_fsm.png File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/6418a045_cd84cdc8 PS5, Line 90: /* RUA contxt ID used in RUA messages to/from the hnb_gw. */ > context thx File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/945c7fef_a77231fe PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" }, > Drop "id-" prefix AFAIK the messages are called "id-Connect" in RUA, including the "id-", whatever the meaning may be -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 13:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31439 ) Change subject: bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If47fa3e0204ce841c79a67dd78a1c53d04e4a586 Gerrit-Change-Number: 31439 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:48:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if: cosmetic: remove whitespace after *

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31169 ) Change subject: pcu_l1_if: cosmetic: remove whitespace after * ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idd1abdfb8df4df58271025c7a808a692d9d86af7 Gerrit-Change-Number: 31169 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use only the term "direct PHY access"

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31361 ) Change subject: pcu_l1_if: use only the term "direct PHY access" ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e Gerrit-Change-Number: 31361 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: add new API call l1if_disconnect_pdch

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31438 ) Change subject: pcu_l1_if_phy: add new API call l1if_disconnect_pdch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: So you are adding a new API but I see it used nowhere? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cc72f032f0abdd5833cdd3b1fe68c69394d89a4 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:44:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023