December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[osmith/1.4.0]: systemd: remove RestartPreventExitStatus=1

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35315?usp=email ) Change subject: systemd: remove RestartPreventExitStatus=1 ...................................................................... Abandoned needs more discussion, see https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I061206a6f61abddfa698a4ce809afcbdf0cbce9c Gerrit-Change-Number: 35315 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) ...................................................................... Abandoned needs more discussion, see https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Gerrit-Change-Number: 35314 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks for testing this. I will prepare new releases for osmo-bts and osmo-bsc then. > either drop backwards compatibility with PCUIFv < 12 (see https://cgit.osmocom.org/osmo-pcu/commit/?id=46140948d9800bca6a7b4299f08b25…), or keep it compatible with v10 and v11, but carefully check that it can actually work with v10 and v12. I didn't realize earlier that not only the patch drops backwards compat for PCUIFv11 as the commit message says, but also it adds a "if (info_ind->version != PCU_IF_VERSION) {" check so starting with this patch, there will be no more backwards compatibility to pcuif. I'll add this patch to osmo-pcu v1.4.0 then, given that the mixing the versions is not tested and will also not be supported anymore once we tag a new release from master. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 12:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: TBF status: Fix VTY output text

by jolly

Attention is currently required from: osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email ) Change subject: TBF status: Fix VTY output text ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7 Gerrit-Change-Number: 35317 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 12:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This patch breaks compatibility with osmo-bts v1.7.1 (current latest tag). […] Even if we make osmo-pcu v1.4.0 compatible with osmo-bts v1.7.1 and osmo-bsc v1.11.0 by lifting the primitive size checking, this would still be pretty useless because we **need to know the BTS type** in order for dummy block generation to work properly (https://gerrit.osmocom.org/c/osmo-pcu/+/35319). I think we would have to: * tag patch releases for both osmo-bts and osmo-bsc, so that both of them would speak the PCUIFv12 and indicate a BTS type to osmo-pcu; * either drop backwards compatibility with PCUIFv < 12 (see https://cgit.osmocom.org/osmo-pcu/commit/?id=46140948d9800bca6a7b4299f08b25…), or keep it compatible with v10 and v11, but carefully check that it can actually work with v10 and v12. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Gerrit-Change-Number: 35314 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:16:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname() ...................................................................... stream_cli: Introduce API osmo_stream_srv_get_sockname() Similar to what osmo_stream_srv_link and osmo_stream_cli already have. Change-Id: I171befd1fdf40c3cbb3fc7e4c3eedf82128b0712 Related: SYS#5580 --- M TODO-RELEASE M include/osmocom/netif/stream.h M src/stream_srv.c 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index ecfd3ae..492c205 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmocore >1.9.0 working osmo_sock_init2_multiaddr2() without setting flag OSMO_SOCK_F_BIND libosmocore >1.9.0 use osmo_sock_multiaddr_get_name_buf() +libosmo-netif added osmo_stream_srv_get_sockname() \ No newline at end of file diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 681f9ec..2e6aa97 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -64,6 +64,7 @@ void osmo_stream_srv_set_closed_cb(struct osmo_stream_srv *conn, int (*closed_cb)(struct osmo_stream_srv *conn)); void *osmo_stream_srv_get_data(struct osmo_stream_srv *conn); struct osmo_stream_srv_link *osmo_stream_srv_get_master(struct osmo_stream_srv *conn); +const char *osmo_stream_srv_get_sockname(const struct osmo_stream_srv *conn); struct osmo_fd *osmo_stream_srv_get_ofd(struct osmo_stream_srv *srv); int osmo_stream_srv_get_fd(const struct osmo_stream_srv *srv); void osmo_stream_srv_destroy(struct osmo_stream_srv *conn); diff --git a/src/stream_srv.c b/src/stream_srv.c index f5a0b42..0dca10a 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -836,6 +836,19 @@ return conn->data; } +/*! \brief Get the stream server socket description. + * \param[in] cli Stream Server to examine + * \returns Socket description or NULL in case of error */ +const char *osmo_stream_srv_get_sockname(const struct osmo_stream_srv *conn) +{ + static char buf[OSMO_STREAM_MAX_ADDRS * OSMO_SOCK_NAME_MAXLEN]; + + osmo_sock_multiaddr_get_name_buf(buf, sizeof(buf), + osmo_stream_srv_get_fd(conn), conn->srv->proto); + + return buf; +} + /*! \brief Get Osmocom File Descriptor of the stream server * \param[in] conn Stream Server * \returns Pointer to \ref osmo_fd */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I171befd1fdf40c3cbb3fc7e4c3eedf82128b0712 Gerrit-Change-Number: 35286 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses ...................................................................... stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses This is used by API callers, and internally to log connected/disconnected events. Related: SYS#5581 Change-Id: I249ee7cad824cf971faabe06d10de2426c1b0c8b --- M TODO-RELEASE M src/stream_cli.c 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 2346129..ecfd3ae 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,5 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.9.0 working osmo_sock_init2_multiaddr2() without setting flag OSMO_SOCK_F_BIND \ No newline at end of file +libosmocore >1.9.0 working osmo_sock_init2_multiaddr2() without setting flag OSMO_SOCK_F_BIND +libosmocore >1.9.0 use osmo_sock_multiaddr_get_name_buf() diff --git a/src/stream_cli.c b/src/stream_cli.c index 4f2963d..1b9994c 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -685,9 +685,10 @@ * \returns Socket description or NULL in case of error */ char *osmo_stream_cli_get_sockname(const struct osmo_stream_cli *cli) { - static char buf[OSMO_SOCK_NAME_MAXLEN]; + static char buf[OSMO_STREAM_MAX_ADDRS * OSMO_SOCK_NAME_MAXLEN]; - osmo_sock_get_name_buf(buf, OSMO_SOCK_NAME_MAXLEN, osmo_stream_cli_get_fd(cli)); + osmo_sock_multiaddr_get_name_buf(buf, sizeof(buf), + osmo_stream_cli_get_fd(cli), cli->proto); return buf; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I249ee7cad824cf971faabe06d10de2426c1b0c8b Gerrit-Change-Number: 35285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I249ee7cad824cf971faabe06d10de2426c1b0c8b Gerrit-Change-Number: 35285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023