December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: This patch breaks compatibility with osmo-bts v1.7.1 (current latest tag). ``` DL1IF ERROR pcu_l1_if.cpp:1349 Received 1006 bytes on PCU Socket, but primitive pcu_prim->u.info_ind size is 1007, discarding ``` We shall not merge it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I171befd1fdf40c3cbb3fc7e4c3eedf82128b0712 Gerrit-Change-Number: 35286 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:00:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I249ee7cad824cf971faabe06d10de2426c1b0c8b Gerrit-Change-Number: 35285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:59:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in libosmo-netif[master]: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the ...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email ) Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full set of addresses ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/94dbeaa3_aa9e85bf PS2, Line 88: 2 + 6 + 1 add a comment explaining what these are for? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I216502a9aeafe638940f110bc9fddf2504b2ac3a Gerrit-Change-Number: 35287 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I171befd1fdf40c3cbb3fc7e4c3eedf82128b0712 Gerrit-Change-Number: 35286 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:50:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I249ee7cad824cf971faabe06d10de2426c1b0c8b Gerrit-Change-Number: 35285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:47:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info() ...................................................................... Patch Set 3: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/7818fc04_c1955318 PS2, Line 2694: n_addrs > You can't do that since *pinfo_cnt is an in param containing the size of the array, so *pinfo_cnt ma […] ah right! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e1c84526b006baff435bbbca49dc6cf7d201cf5 Gerrit-Change-Number: 35276 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:36:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

by pespin

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info() ...................................................................... Patch Set 3: (3 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/2dbe5821_0f929f93 PS2, Line 2660: [out] > [in,out] (see https://www.doxygen.nl/manual/commands. […] Ah I thought one had to set out there, thanks. https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/ac9e18cc_623851fa PS2, Line 2668: g > f Done https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/90c3cbac_394d50c9 PS2, Line 2694: n_addrs > this might be simpler if you only count to *pinfo_cnt? You can't do that since *pinfo_cnt is an in param containing the size of the array, so *pinfo_cnt may be smaller than n_addrs. Hence they need to be kept separate. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e1c84526b006baff435bbbca49dc6cf7d201cf5 Gerrit-Change-Number: 35276 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info() ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/95100efe_c3e3f57e PS2, Line 2660: [out] > [in,out] (see https://www.doxygen.nl/manual/commands. […] Done https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/6ed42327_e7f7bd23 PS2, Line 2668: g > f Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e1c84526b006baff435bbbca49dc6cf7d201cf5 Gerrit-Change-Number: 35276 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 10:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-ci[master]: coverity: add job to check for failed uploads

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35267?usp=email ) Change subject: coverity: add job to check for failed uploads ...................................................................... coverity: add job to check for failed uploads Related: SYS#6685 Change-Id: Ideabcb30f9f8f365acff2de7751eb74a2762a7a6 --- A coverity/badge_status.sh M jobs/README.adoc A jobs/coverity-status.yml 3 files changed, 85 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/coverity/badge_status.sh b/coverity/badge_status.sh new file mode 100755 index 0000000..72fdcce --- /dev/null +++ b/coverity/badge_status.sh @@ -0,0 +1,28 @@ +#!/bin/sh -e +# Check if the coverity badge says "failed". This can happen for example if we +# use a coverity version that is no longer supported, and it doesn't fail in +# any other obvious way. (SYS#6685) + +# Download the status badge svg image, which contains the word "passed" when +# it was successful, and "failed" when it failed. +# Example: <text x="62" y="14">passed 91 new defects</text> + +BADGE="_temp/badge.svg" + +mkdir -p _temp +rm -f "$BADGE" + +wget --no-verbose -O "$BADGE" "https://scan.coverity.com/projects/7523/badge.svg" + +if grep -q passed "$BADGE" && ! grep -q failed "$BADGE"; then + echo "Success" + exit 0 +fi + +echo +echo "ERROR: coverity failed!" +echo +echo "Find the error details here:" +echo "https://scan.coverity.com/projects/osmocom?tab=overview" +echo +exit 1 diff --git a/jobs/README.adoc b/jobs/README.adoc index c37b3bb..eb14152 100644 --- a/jobs/README.adoc +++ b/jobs/README.adoc @@ -144,5 +144,6 @@ 04:XX osmocom-release-manuals 05:XX osmocom-release-tarballs 06:XX repo-install-test + 06:XX coverity-status (runs intentionally much later than the coverity job) master-builds: to avoid complexity, these run throughout the day (H H * * *). diff --git a/jobs/coverity-status.yml b/jobs/coverity-status.yml new file mode 100644 index 0000000..cb7522e --- /dev/null +++ b/jobs/coverity-status.yml @@ -0,0 +1,46 @@ +# Check if the coverity badge says "failed". This can happen for example if we +# use a coverity version that is no longer supported, and it doesn't fail in +# any other obvious way. (SYS#6685) +- project: + name: osmocom-coverity-status + jobs: + - osmocom-coverity-status + +- job: + name: 'osmocom-coverity-status' + project-type: freestyle + defaults: global + description: | + Verify that the coverity badge says "passed" and not "failed" (SYS#6685). + <br> + <br> + <img src="https://scan.coverity.com/projects/7523/badge.svg"> + builders: + - shell: | + coverity/badge_status.sh + publishers: + - email: + recipients: 'jenkins-notifications(a)lists.osmocom.org' + notify-every-unstable-build: true + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 30 + parameters: + - string: + name: BRANCH + description: osmo-ci.git branch + default: 'origin/master' + scm: + - git: + url: https://gerrit.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins(a)osmocom.org' + branches: + - '$BRANCH' + triggers: + - timed: "H 06 * * *" + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications(a)lists.osmocom.org' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ideabcb30f9f8f365acff2de7751eb74a2762a7a6 Gerrit-Change-Number: 35267 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023