Attention is currently required from: arehbein, fixeria, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up
......................................................................
Patch Set 3:
(5 comments)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/b76ccc94_bd49d1b5
PS2, Line 18: logging/logging_test_gsmtap
> This file needs to be updated properly: […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/a19cb23e_29d84576
PS2, Line 566: logging/logging_test
> add the respective statement for `logging_test_gsmtap` here
Done
File tests/logging/logging_test_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/673690cd_7398e8ee
PS2, Line 3: 2008, 2009 by Holger Hans Peter Freyther <zecke(a)selfish.org>
> I doubt it was Holger who wrote this test
He was the spiritual author but I get your point
File tests/logging/logging_test_gsmtap.err:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7ea7b0ba_1e827898
PS2, Line 108: 0x611000000328
> I think we do patch stuff in output in some places already. […]
Thanks for the hint. It's even easier now since we're using the txqueue of osmo_io and it doesn't log any pointers.
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/60bbad5a_5646f7a1
PS2, Line 206: logging_test_gsmtap.ok
> no such file?
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468
Gerrit-Change-Number: 34967
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Dec 2023 11:03:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: arehbein, fixeria, laforge, pespin.
Hello Jenkins Builder, arehbein, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by arehbein, Code-Review+1 by laforge, Code-Review-1 by fixeria, Verified-1 by Jenkins Builder
Change subject: tests: Test gsmtap logging if write queue fills up
......................................................................
tests: Test gsmtap logging if write queue fills up
Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468
---
M tests/Makefile.am
A tests/logging/logging_test_gsmtap.c
A tests/logging/logging_test_gsmtap.err
M tests/testsuite.at
4 files changed, 421 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/34967/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468
Gerrit-Change-Number: 34967
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35377?usp=email )
Change subject: OML: Add Get Attributes for supported MOs for BTS Object Class
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35377?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I067c6bdea3c44d5a731bcfdcfe304c14629eb3db
Gerrit-Change-Number: 35377
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 18 Dec 2023 10:34:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email )
Change subject: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I49ab516c38a986520f1d3f6e26ddd20ee16688ac
Gerrit-Change-Number: 35378
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 18 Dec 2023 10:34:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email )
Change subject: OML: Add Get Attributes for supported MOs for Channel Object Class
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I56e067be9e5c17625c7da4e982b90927802f57b4
Gerrit-Change-Number: 35379
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 18 Dec 2023 10:34:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment