December 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I49ab516c38a986520f1d3f6e26ddd20ee16688ac Gerrit-Change-Number: 35378 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Dec 2023 23:20:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: migrate away from deprecated gsm48_mi_to_string

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email ) Change subject: layer23: migrate away from deprecated gsm48_mi_to_string ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: did you test this manually using osmocombb against a network? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Dec 2023 23:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: extend documentation about transports

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35388?usp=email ) Change subject: extend documentation about transports ...................................................................... extend documentation about transports By adding a description to each of the transports, we extend the manual. Change-Id: I84d926b45c97477e77a7852bc8254ce9a7614a33 --- M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py 4 files changed, 20 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/35388/1 diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index 98330a9..b660cc0 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -169,6 +169,7 @@ @staticmethod def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): - osmobb_group = arg_parser.add_argument_group('OsmocomBB Reader') + osmobb_group = arg_parser.add_argument_group('OsmocomBB Reader', description= + """Use a Calypso based cellphone running the OsmocomBB layer1 firmware and the osmocon host program to access your SIM card""") osmobb_group.add_argument('--osmocon', dest='osmocon_sock', metavar='PATH', default=None, help='Socket path for Calypso (e.g. Motorola C1XX) based reader (via OsmocomBB)') diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index 71f76e2..27a03e9 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -181,7 +181,8 @@ @staticmethod def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): - modem_group = arg_parser.add_argument_group('AT Command Modem Reader') + modem_group = arg_parser.add_argument_group('AT Command Modem Reader', description= + """Use a AT commands to access a SIM card inserted to a cellular modem""") modem_group.add_argument('--modem-device', dest='modem_dev', metavar='DEV', default=None, help='Serial port of modem for Generic SIM Access (3GPP TS 27.007)') modem_group.add_argument('--modem-baud', type=int, metavar='BAUD', default=115200, diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 762908c..878f887 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -104,6 +104,7 @@ @staticmethod def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): - pcsc_group = arg_parser.add_argument_group('PC/SC Reader') + pcsc_group = arg_parser.add_argument_group('PC/SC Reader', description= + """Use a smart card interface via the PC/SC driver middleware of your OS""") pcsc_group.add_argument('-p', '--pcsc-device', type=int, dest='pcsc_dev', metavar='PCSC', default=None, help='PC/SC reader number to use for SIM access') diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index ad800ed..fae2f30 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -247,7 +247,8 @@ @staticmethod def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): - serial_group = arg_parser.add_argument_group('Serial Reader') + serial_group = arg_parser.add_argument_group('Serial Reader', description= + """Use a classic "dumb" low-cost serial (RS232) reader to talk to your SIM card""") serial_group.add_argument('-d', '--device', metavar='DEV', default='/dev/ttyUSB0', help='Serial Device for SIM access') serial_group.add_argument('-b', '--baud', dest='baudrate', type=int, metavar='BAUD', default=9600, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84d926b45c97477e77a7852bc8254ce9a7614a33 Gerrit-Change-Number: 35388 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: docs/shell: extend the introduction part; link to video presentation

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35387?usp=email ) Change subject: docs/shell: extend the introduction part; link to video presentation ...................................................................... docs/shell: extend the introduction part; link to video presentation Change-Id: I77c30921f2b8c002c9dda244656c348c96b41f06 --- M docs/shell.rst 1 file changed, 30 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/35387/1 diff --git a/docs/shell.rst b/docs/shell.rst index d8c0967..313d6d9 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -4,7 +4,9 @@ pySim-shell is an interactive command line shell for all kind of interactions with SIM cards, including classic GSM SIM, GSM-R SIM, UICC, USIM, ISIM, HPSIM and recently even eUICC. -The interactive shell provides command for +If you're familiar with Unix/Linux shells: Think of it like *the bash for SIM cards*. + +The pySim-shell interactive shell provides commands for * navigating the on-card filesystem hierarchy * authenticating with PINs such as ADM1 @@ -16,14 +18,31 @@ * decoded reading (display file data represented in human and machine readable JSON format) * decoded writing (encode from JSON to binary format, then write) +* if your card supports it, and you have the related privileges: resizing, creating, enabling and disabling of + files + By means of using the python ``cmd2`` module, various useful features improve usability: * history of commands (persistent across restarts) * output re-direction to files on your computer -* output piping through external tools like 'grep' +* output piping through external tools like ``grep`` * tab completion of commands and SELECT-able files/directories * interactive help for all commands +A typical interactive pySim workflow would look like this: + +* starting the program, specifying which smart card interface to use to talk to the card +* verifying the PIN (if needed) or the ADM1 PIN in case you want to write/modify the card +* selecting on-card application dedicated files like ADF.USIM and navigating the tree of DFs +* reading and potentially modifying file contents, in raw binary (hex) or decoded JSON format + +Video Presentation +------------------ + +There is a `video recording of the presentation back when pySim-shell was originally released +<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>`_. While it is slightly dated, it should +still provide a good introduction. + Running pySim-shell ------------------- -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77c30921f2b8c002c9dda244656c348c96b41f06 Gerrit-Change-Number: 35387 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Introduce test TC_ue_cell_reselect_eutran_to_geran

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35386?usp=email ) Change subject: mme: Introduce test TC_ue_cell_reselect_eutran_to_geran ...................................................................... mme: Introduce test TC_ue_cell_reselect_eutran_to_geran Initial bits to be able to test SGSN Context Request+Response emulating an UE doing cell reselection from 4G to 2G. Related: OS#6294 Change-Id: I707cb8c6b39c1440db5ccc2f02d08337b38fb564 --- M library/GTP_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 258 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/35386/1 diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 06ba208..abdde1b 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -41,6 +41,33 @@ /* FIXME */ }; + private function enum2oct1_Cause_gtpc_tmpl(template GTP_Cause inp) return template OCT1 + { + if (istemplatekind(inp, "omit")) { + return omit; + } else if (istemplatekind(inp, "*")) { + return *; + } else if (istemplatekind(inp, "?")) { + return ?; + } else { + return int2oct(enum2int(valueof(inp)), 1); + } + } + template (present) Cause_gtpc tr_Cause_gtpc(template (present) GTP_Cause cause) := { + type_gtpc := '01'O, + causevalue := enum2oct1_Cause_gtpc_tmpl(cause) + } + function f_tr_Cause_gtpc(template GTP_Cause cause) return + template Cause_gtpc { + if (istemplatekind(cause, "omit")) { + return omit; + } else if (istemplatekind(cause, "*")) { + return *; + } else { + return tr_Cause_gtpc(cause); + } + } + private function f_oct_or_wc(template integer inp, integer len) return template octetstring { if (istemplatekind(inp, "omit")) { return omit; @@ -119,6 +146,18 @@ restartCounter := restart_counter } + /* Packet TMSI - 7.7.5 */ + template (value) PacketTMSI ts_PTMSI(OCT4 ptmsi) := { + type_gtpc := '05'O, + p_tmsi := ptmsi + } + + /* PTMSI Signature - 7.7.9 */ + template (value) PTMSI_Signature ts_PTMSI_sig(OCT3 ptmsi_sig) := { + type_gtpc := '0C'O, + ptmsi_Signature := ptmsi_sig + } + /* IMEI(SV) IE TS 29.060 7.7.53 */ template (value) IMEISV_gtpc ts_IMEISV(template (value) OCT8 imeisv) := { type_gtpc := '9A'O, @@ -350,7 +389,7 @@ apn_value := apn } - template (value) GSN_Address_GTPC ts_GsnAddr(octetstring ip_addr) := { + template (value) GSN_Address_GTPC ts_GsnAddr(template (value) octetstring ip_addr) := { type_gtpc := '85'O, lengthf := lengthof(ip_addr), addressf := ip_addr @@ -402,6 +441,29 @@ digits := digits, padding := 'F'H } + function f_ts_Imsi(template (omit) hexstring digits := omit) return template (omit) IMSI_gtpc { + var template (omit) IMSI_gtpc imsi; + if (istemplatekind(digits, "omit")) { + imsi := omit; + } else { + imsi := ts_Imsi(valueof(digits)); + } + return imsi; + } + template (present) IMSI_gtpc tr_Imsi(template (present) hexstring digits) := { + type_gtpc := '02'O, + digits := digits, + padding := 'F'H + } + function f_tr_Imsi(template hexstring digits := *) return template IMSI_gtpc { + if (istemplatekind(digits, "omit")) { + return omit; + } else if (istemplatekind(digits, "*")) { + return *; + } else { + return tr_Imsi(digits); + } + } function f_ts_RATType(template (omit) OCT1 ratType := omit) return template (omit) RATType { var template (omit) RATType rt; @@ -417,6 +479,17 @@ return rt; } + template (value) RoutingAreaIdentity ts_RoutingAreaIdentity(template (value) hexstring mcc_digits, + template (value) hexstring mnc_digits, + template (value) OCT2 lac, + template (value) OCT1 rac) := { + type_gtpc := '03'O, + mcc_digits := mcc_digits, + mnc_digits := mnc_digits, + lac := lac, + rac := rac + } + template (value) GeographicLocationCGI ts_GeographicLocationCGI(template (value) hexstring mcc, template (value) hexstring mnc, @@ -869,6 +942,85 @@ valueof(ts_DeletePdpRespPDU(cause, pco)), seq) } + /* SGSN Context Request - 7.5.3 */ + template (value) GTPC_PDUs ts_SGSNContextReqPDU(template (value) RoutingAreaIdentity rai, + template (value) OCT4 teic, + template (value) octetstring sgsn_addr_control, + template (omit) hexstring imsi := omit, + template (value) BIT1 msValidated := '0'B, + template (omit) TLLI tlli := omit, + template (omit) PacketTMSI ptmsi := omit, + template (omit) PTMSI_Signature ptmsi_sig := omit, + template (omit) OCT1 rat_type := omit) := { + sgsn_ContextRequest := { + + imsi := f_ts_Imsi(imsi), + routingAreaIdentity := rai, + tlli := tlli, + packetTMSI := ptmsi, + ptmsi_Signature := ptmsi_sig, + ms_Validated := { + type_gtpc := '0D'O, + msValidated := msValidated, + spare := '1111111'B + }, + teidControlPlane := { + type_gtpc := '11'O, + teidControlPlane := teic + }, + sgsn_addr_controlPlane := ts_GsnAddr(sgsn_addr_control), + alternative_sgsn_addr_controlPlane := omit, + sGSN_Number := omit, + ratType := f_ts_RATType(rat_type), + hopCounter := omit, + private_extension_gtpc := omit + } + } + template (value) Gtp1cUnitdata ts_GTPC_SGSNContextReq(GtpPeer peer, uint16_t seq, + template (value) GTPC_PDUs SGSNContextReqPDU) := { + peer := peer, + gtpc := ts_GTP1C_PDU(sgsnContextRequest, '00000000'O, valueof(SGSNContextReqPDU), seq) + } + + /* SGSN Context Response - 7.5.4 */ + template (present) GTPC_PDUs tr_SGSNContextReqPDU(template (present) GTP_Cause cause := ?, + template hexstring imsi := *) := { + sgsn_ContextResponse := { + cause := tr_Cause_gtpc(cause), + imsi := f_tr_Imsi(imsi), + teidControlPlane := *, + rabContext := *, + radioPrioritySMS := *, + radioPriority := *, + packetFlowID := *, + charging_char := *, + mm_Context := *, + pdp_Context := *, + sgsn_addr_controlPlane := *, + pdpContextPriorization := *, + radioPriority_LCS := *, + mBMS_UE_Context := *, + subscribedRFSP_Index := *, + rFSP_IndexInUse := *, + colocatedGGSN_PGW_FQDN := *, + evolvedAllocationRetentionPriorityII := *, + extendedCommonFlags := *, + ue_network_capability := *, + ue_ambr := *, + apn_ambr_nsapi := *, + signallingPriorityIndication_nsapi := *, + higher_bitrates_than_16mbps_flag := *, + selectionMode_nsapi := *, + localHomeNetworkID_nsapi := *, + uE_UsageType := *, + extendedCommonFlagsII := *, + private_extension_gtpc := * + } + } + template (present) Gtp1cUnitdata tr_GTPC_SGSNContextResp(template (present) GtpPeer peer := ?, + template (present) OCT4 teid := ?, + template (present) GTPC_PDUs SGSNContextRespPDU := ?) + := tr_GTPC_MsgType(peer, sgsnContextResponse, teid, SGSNContextRespPDU); /* GTP-C RIM */ diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index eca6b04..3373269 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -81,6 +81,7 @@ type record UeParams { hexstring imsi, charstring ue_ip, + NAS_EPS_Types.GUTI guti optional, /* TEI (Control) local side, S11 (SGW) */ OCT4 s11_teic_local, @@ -277,6 +278,7 @@ uep := { imsi := f_gen_imsi(imsi_suffix), ue_ip := "192.168.123.50", + guti := omit, s11_teic_local := '00000000'O, s11_teic_remote := omit, s5c_teic_local := '00000000'O, @@ -613,6 +615,15 @@ var template (value) E_RABSetupListCtxtSURes rab_setup_items; var octetstring esm_enc; var template (value) PDU_NAS_EPS nas; + var EPS_MobileIdentityTLV mi_tlv; + + S1AP.receive(tr_NAS_AttachAccept()) -> value rx_nas; + log("PESPIN: rx NAS_PDU: ", rx_nas); + mi_tlv := rx_nas.ePS_messages.ePS_MobilityManagement.pDU_NAS_EPS_AttachAccept.gUTI; + if (mi_tlv.ePS_MobileIdentity.ePS_MobileIdentity.typeOfIdentity != '110'B) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Rx GUTI of unexpected MI type: ", mi_tlv)); + } + g_pars.ue_pars.guti := mi_tlv.ePS_MobileIdentity.ePS_MobileIdentity.oddEvenInd_identity.guti rab_setup_it := ts_S1AP_RABSetupItemCtxtSURes(rab_id := 5, tla := oct2bit(f_inet_addr(mp_mme_ip)), @@ -1186,6 +1197,86 @@ vc_conn.done; } +/* Test UE attached to EUTRAN reselecting a GERAN cell. In this scenario, the + * new SGSN will attempt to obtain information of the UE from the old SGSN (MME) + * through Gn interface using SGSN Context Request/Response procedure (OS#6294). */ +/* TS 23.003 2.8.2.1 */ +private function guti2rai_ptmsi(in NAS_EPS_Types.GUTI guti, out RoutingAreaIdentity rai, out OCT4 ptmsi, out OCT3 ptmsi_sig) runs on ConnHdlr { + var bitstring mtmsi_bits := oct2bit(guti.mTMSI); + var bitstring ptmsi_bits; + var bitstring ptmsi_sig_bits; + + rai := valueof(ts_RoutingAreaIdentity(guti.mccDigit1 & guti.mccDigit2 & guti.mccDigit3, + guti.mncDigit3 & guti.mncDigit1 & guti.mncDigit2, + guti.mMEGI, guti.mMEC)); + /* 3GPP TS 23.003 2.8.2.0: "P-TMSI shall be of 32 bits length where the two topmost bits are + * reserved and always set to '11'. Hence, for a UE which may handover to GERAN/UTRAN (based on + * subscription and UE capabilities), the corresponding bits in the M-TMSI are set to '11'" + */ + ptmsi_bits := '11'B & substr(mtmsi_bits, 2, 6) & oct2bit(guti.mMEC) & substr(mtmsi_bits, 16, 16); + ptmsi_sig_bits := substr(mtmsi_bits, 8, 8) & oct2bit('0000'O); + ptmsi := bit2oct(ptmsi_bits); + ptmsi_sig := bit2oct(ptmsi_sig_bits); + /* TODO: The UE shall fill the remaining 2 octets of the <P-TMSI signature> according to clauses 9.1.1, 9.4.1, 10.2.1, or + * 10.5.1 of 3GPP TS.33.401 [89] , as appropriate, for RAU/Attach procedures.*/ + /* TODO: 3GPP TS 33.401 9.1.1 The 16 least significant bits available in + * the P-TMSI signature field shall be filled with the truncated NAS-token + * according to 3GPP TS 23.003 [3].The truncated NAS-token is defined as the 16 + * least significant bits of the NAS-token. + * The NAS-token is derived as specified in Annex A.9. The UE shall use the uplink NAS COUNT value that it would use + * in the next NAS message to calculate the NAS-token and increase the stored uplink NAS COUNT value by 1.*/ + /* TODO: mMEC "also copied into the 8 Most Significant Bits of the NRI field within the P-TMSI" */ +} +private function f_TC_ue_cell_reselect_eutran_to_geran(ConnHdlrPars pars) runs on ConnHdlr { + var template (value) GTPC_PDUs SGSNContextReqPDU; + var RoutingAreaIdentity rai; + var OCT4 ptmsi; + var OCT3 ptmsi_sig; + var Gtp1cUnitdata gtpc_pdu; + + f_init_handler(pars); + f_gtp_register_imsi(g_pars.ue_pars.imsi); + f_attach(); + + /* TODO: take GUTI from as_s1ap_handle_IntialCtxSetupReq() in g_pars, + * convert it to P-TMSI and pass P-TMSI below */ + guti2rai_ptmsi(g_pars.ue_pars.guti, rai, ptmsi, ptmsi_sig); + + SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, '00000000'O, f_inet_addr(mp_gn_local_ip), + ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); + GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); + + timer T := 5.0; + T.start; + alt { + [] GTP.receive(tr_GTPC_SGSNContextResp(g_gn_iface_peer, '00000000'O, + tr_SGSNContextReqPDU(GTP_CAUSE_REQUEST_ACCEPTED, + g_pars.ue_pars.imsi))) -> value gtpc_pdu { + setverdict(pass); + } + [] GTP.receive { + setverdict(fail, "unexpected GTPC message from MME"); + } + [] T.timeout { + setverdict(fail, "no SGSN Context Response from MME"); + } + } +} +testcase TC_ue_cell_reselect_eutran_to_geran() runs on MTC_CT { + var charstring id := testcasename(); + + f_init_diameter(id); + f_init_s1ap(id, 4); + f_init_gtpv2_s11(id); + f_s1ap_setup(0); + f_init_gtp(id); + + var ConnHdlrPars pars := f_init_pars(ue_idx := 0); + var ConnHdlr vc_conn; + vc_conn := f_start_handler_with_pars(refers(f_TC_ue_cell_reselect_eutran_to_geran), pars); + vc_conn.done; +} + control { execute( TC_s1ap_setup_wrong_plmn() ); execute( TC_s1ap_setup_wrong_tac() ); @@ -1195,6 +1286,7 @@ execute( TC_gn_echo_request() ); execute( TC_RIM_RAN_INF() ); execute( TC_s1ap_reset() ); + execute( TC_ue_cell_reselect_eutran_to_geran() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I707cb8c6b39c1440db5ccc2f02d08337b38fb564 Gerrit-Change-Number: 35386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: migrate away from deprecated gsm48_mi_to_string

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email ) Change subject: layer23: migrate away from deprecated gsm48_mi_to_string ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 18 Dec 2023 17:15:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-hlr[master]: ctrl: add subscriber.by-*.imsi GET-able variable

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/35383?usp=email ) Change subject: ctrl: add subscriber.by-*.imsi GET-able variable ...................................................................... ctrl: add subscriber.by-*.imsi GET-able variable There may be a need in various OsmoCNI-attached entities (for example, external SMSC implementations) to perform a mapping from known MSISDN to unknown IMSI, querying OsmoHLR subscriber db for it. Querying for subscriber.by-msisdn-*.imsi will be much more efficient (and easier on client-side implementors) than querying for subscriber.by-msisdn-*.info and fishing the IMSI out of the long multiline response, discarding all other irrelevant info. Related: OS#6312 Change-Id: Icea1a74d0c664047f46758ab4ad75508782f3d12 --- M src/ctrl.c 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/ctrl.c b/src/ctrl.c index e04195d..9555e28 100644 --- a/src/ctrl.c +++ b/src/ctrl.c @@ -426,6 +426,20 @@ return set_subscr_cs_ps_enabled(cmd, data, false); } +CTRL_CMD_DEFINE_RO(subscr_imsi, "imsi"); +static int get_subscr_imsi(struct ctrl_cmd *cmd, void *data) +{ + struct hlr_subscriber subscr; + struct hlr *hlr = data; + const char *by_selector = cmd->node; + + if (!get_subscriber(hlr->dbc, by_selector, &subscr, cmd)) + return CTRL_CMD_ERROR; + + cmd->reply = talloc_strdup(cmd, subscr.imsi); + return CTRL_CMD_REPLY; +} + CTRL_CMD_DEFINE(subscr_msisdn, "msisdn"); static int verify_subscr_msisdn(struct ctrl_cmd *cmd, const char *value, void *data) { @@ -761,6 +775,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_info_all); rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_ps_enabled); rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_cs_enabled); + rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_imsi); rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_msisdn); rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_aud2g); rc |= ctrl_cmd_install(CTRL_NODE_SUBSCR_BY, &cmd_subscr_aud3g); -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/35383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea1a74d0c664047f46758ab4ad75508782f3d12 Gerrit-Change-Number: 35383 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Channel Object Class

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Channel Object Class ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/35379/comment/bd7dd2df_2ccbfafc PS1, Line 480: if (mo->obj_class == NM_OC_RADIO_CARRIER || mo->obj_class == NM_OC_BASEB_TRANSC || maybe use a switch-statement here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I56e067be9e5c17625c7da4e982b90927802f57b4 Gerrit-Change-Number: 35379 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Dec 2023 16:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/35378/comment/7a05b671_f69719dc PS1, Line 15: Note: Only one ARFCN is reported, because hopping is not supported. > what do you mean exactly with "is not supported"? what and where is not supported? It should be clarified that _synthesizer hopping_ is not supported. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I49ab516c38a986520f1d3f6e26ddd20ee16688ac Gerrit-Change-Number: 35378 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Dec 2023 16:36:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for BTS Object Class

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35377?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for BTS Object Class ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I067c6bdea3c44d5a731bcfdcfe304c14629eb3db Gerrit-Change-Number: 35377 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Dec 2023 16:34:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023