November 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: early-IA: use the correct TRX
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35095?usp=email ) Change subject: early-IA: use the correct TRX ...................................................................... Patch Set 3: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/35095/comment/3000b245_8e7cd8de PS3, Line 1403: /* hopping is disabled. */ > What if hopping is enabled? Should we return an rsl_tx_error_report() Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id9a930e5c67122812b229dc27ea2bfe246b67611 Gerrit-Change-Number: 35095 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 13:08:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: Bump version: 1.11.0.5-67677-dirty → 1.11.1
by daniel 28 Nov '23

28 Nov '23

Attention is currently required from: osmith, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35150?usp=email ) Change subject: Bump version: 1.11.0.5-67677-dirty → 1.11.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I869eef2032d6025c8ed59a1b25192c6c5c08977e Gerrit-Change-Number: 35150 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 13:07:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625 → 1.11.0
by osmith 28 Nov '23

28 Nov '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625 → 1.11.0 ...................................................................... Bump version: 1.10.2.1-a625 → 1.11.0 Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 --- M debian/changelog M gtp/Makefile.am 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index f72d9f6..9eb37fd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-ggsn (1.11.0) unstable; urgency=medium + + [ Daniel Willmann ] + * gtp: Add net GTP cause values and a function to check for success + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 28 Nov 2023 13:38:29 +0100 + osmo-ggsn (1.10.2) unstable; urgency=medium [ Vadim Yanitskiy ] diff --git a/gtp/Makefile.am b/gtp/Makefile.am index cb32da7..99ad8bb 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -2,7 +2,7 @@ # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html # If major=current-age is increased, remember to update the dh_strip line in debian/rules! -LIBVERSION=9:0:3 +LIBVERSION=9:1:3 lib_LTLIBRARIES = libgtp.la -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625 → 1.11.0
by daniel 28 Nov '23

28 Nov '23

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625 → 1.11.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 13:07:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625 → 1.11.0
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625 → 1.11.0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 13:04:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: arehbein, fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email ) Change subject: Introduce per-BTS timers, RLC timer commands ...................................................................... Patch Set 16: Code-Review-1 (16 comments) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/805a2cc6_e0ac3ba7 PS16, Line 720: enum gprs_rlc_par { I bet this is not needed anymore and can be dropped? File src/osmo-bsc/bsc_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/709588ee_c5374837 PS16, Line 51: extern void bts_gprs_timer_groups_init(struct gsm_bts *bts); why don't you add this to a header file? https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/1ea08409_2909a72c PS16, Line 240: bts_gprs_timer_groups_init(bts); why is this put here and not in gsm_bts_alloc_register() ? File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/d8c3ec12_bf937d5a PS16, Line 235: You could submit this a a preparation patch. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/5059a9c4_d631760d PS16, Line 336: int rc = CMD_WARNING, bts_nr = atoi(argv[0]); please use separate lines. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/200c39ee_c7676da8 PS16, Line 346: if (bts->gprs.mode == BTS_GPRS_NONE) { why can't I configure gprs timers if gprs is not currently enabled? I don't see a problem with it, and several usability problems, like having to comment all timer lines if I decide to start the app with "gprs mode none". https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/07070b25_bd8b2072 PS16, Line 351: ++group; we tend to use group++ unless there's a good reason to use preinc. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/ffb743b5_be8f4972 PS16, Line 354: if (bts_write_group_timers(vty, "", bts_nr, group, T_arg, false) == CMD_WARNING) I don't really understand what are you doing here comparing against == CMD_WARNING and then doing rc = CMD_SUCCESS. File src/osmo-bsc/bts_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/fb231078_729120e6 PS12, Line 60: 3101 > I actually find this problematic. […] Simply use 3101 for T3101, and -3101 (X3101) for N3101. File src/osmo-bsc/bts_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/dde08777_91ad0b5f PS16, Line 88: for (gbtg = 0; gbtg < ARRAY_SIZE(bts_gprs_timer_template_groups); gbtg++) memcpy(&bts->timer_groups[0], bts_gprs_timer_template_groups[0], ARRAY_SIZE(bts_gprs_timer_template_groups)); File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/882fe6f8_b5ac08bf PS12, Line 253: struct abis_nm_ipacc_att_rlc_cfg > cosmetic: it's not necessary to specify the struct type here. Ack File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/c071f5c0_bce88d2d PS3, Line 1706: /* TODO (BSSGP timer patch): If argument is one of BSSGP Timers strings, then translate to > My understanding so far has been, that we have three timer groups that relate to OS#5335 (e.g. […] So if this patch is for RLC; why are you touching BSSGP lines here? File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/28ee33b2_d47d1a37 PS12, Line 56: limits.h > why including thise header? I cannot see `_MIN` or `_MAX` in new code... Ack File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/ad2e2f37_e3dc11a2 PS16, Line 37: extern void bts_gprs_timer_groups_init(struct gsm_bts *bts); don't we have headers for this? https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/165508af_c16add51 PS16, Line 38: extern void bts_grprs_tdef_groups_init(void); typo: grprs. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/b11f60da_c8b22194 PS16, Line 158: bts_grprs_tdef_groups_init(); typo: grprs. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 16 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 13:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload
by fixeria 28 Nov '23

28 Nov '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c Gerrit-Change-Number: 35082 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:46:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH
by fixeria 28 Nov '23

28 Nov '23

Attention is currently required from: falconia, jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:44:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: Bump version: 1.11.0.5-67677-dirty → 1.11.1
by osmith 28 Nov '23

28 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35150?usp=email ) Change subject: Bump version: 1.11.0.5-67677-dirty → 1.11.1 ...................................................................... Bump version: 1.11.0.5-67677-dirty → 1.11.1 Depends: osmo-ggsn I1f116e1cded135f231f22ebc9b817aebf3736fc2 Change-Id: I869eef2032d6025c8ed59a1b25192c6c5c08977e --- M TODO-RELEASE M configure.ac M contrib/osmo-sgsn.spec.in M debian/changelog M debian/control 5 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/50/35150/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index bb4f900..1c5d61f 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,2 +1 @@ #component what description / commit summary line -libgtp > 1.10 use gtp_cause_successful() diff --git a/configure.ac b/configure.ac index 6eac7c9..ddd91ab 100644 --- a/configure.ac +++ b/configure.ac @@ -46,7 +46,7 @@ PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.5.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.4.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.7.0) -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.10.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.11.0) # Enable/disable 3G aka IuPS + IuCS support? AC_ARG_ENABLE([iu], [AS_HELP_STRING([--enable-iu], [Build 3G support, aka IuPS and IuCS interfaces])], diff --git a/contrib/osmo-sgsn.spec.in b/contrib/osmo-sgsn.spec.in index 8ee0a75..7ba994f 100644 --- a/contrib/osmo-sgsn.spec.in +++ b/contrib/osmo-sgsn.spec.in @@ -34,7 +34,7 @@ %endif BuildRequires: pkgconfig(libcares) BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libgtp) >= 1.10.0 +BuildRequires: pkgconfig(libgtp) >= 1.11.0 BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.7.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.4.0 BuildRequires: pkgconfig(libosmoabis) >= 1.5.0 diff --git a/debian/changelog b/debian/changelog index 206efd4..cb629fb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +osmo-sgsn (1.11.1) unstable; urgency=medium + + [ Philipp Maier ] + * sgsn_rim: forward message based on RIM ROUTING ADDRESS + + [ Daniel Willmann ] + * sgsn_vty: Fix output in config_write_sgsn + * sgsn_vty: Correctly indent encryption cipher-plugin-path + * vty-tests: Test encryption options + * libgtp: Check for all successful create_pdp_conf causes + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 28 Nov 2023 13:32:46 +0100 + osmo-sgsn (1.11.0) unstable; urgency=medium [ Oliver Smith ] diff --git a/debian/control b/debian/control index 77af36e..aa59455 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ pkg-config, libtalloc-dev, libc-ares-dev, - libgtp-dev (>= 1.10.0), + libgtp-dev (>= 1.11.0), libosmocore-dev (>= 1.9.0), libosmo-abis-dev (>= 1.5.0), libosmo-netif-dev (>= 1.4.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I869eef2032d6025c8ed59a1b25192c6c5c08977e Gerrit-Change-Number: 35150 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625 → 1.11.0
by osmith 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625 → 1.11.0 ...................................................................... Patch Set 1: (1 comment) File gtp/Makefile.am: https://gerrit.osmocom.org/c/osmo-ggsn/+/35149/comment/f88b7008_cfe8fda8 PS1, Line 5: LIBVERSION=9:1:3 > this is wrong, a new API gtp_cause_successful() has been added. It should be LIBVERSION=10:0:4. it's a static inline function, so 9:1:3 is fine as discussed in chat > And hence not a patch release, but a minor release. done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:40:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0