November 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625 → 1.11.0
by osmith 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, osmith, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: Bump version: 1.10.2.1-a625 → 1.11.0 ...................................................................... Bump version: 1.10.2.1-a625 → 1.11.0 Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 --- M debian/changelog M gtp/Makefile.am 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/49/35149/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625-dirty → 1.10.3
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625-dirty → 1.10.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: the LIBVERSION is fine since it's a static inline, but the verison still needs to be bumped as minor, not patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests: tell PCU a more realistic BTS model
by laforge 28 Nov '23

28 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35144?usp=email ) Change subject: PCU_Tests: tell PCU a more realistic BTS model ...................................................................... PCU_Tests: tell PCU a more realistic BTS model In ts_PCUIF_INFO_default we set the bts_model member to PCU_IF_BTS_MODEL_UNSPEC. This means that the PCU will not know the BTS model and thus it is not able to comply to the specific pecularities of the BTS model that is used. In PCU_Tests.ttcn we simulate the behavior of an OsmoBTS with OsmoTRX, therefore we should set the BTS model to PCU_IF_BTS_MODEL_TRX. This will also fix the problems we have with unexpected DUMMY messages we currently receive since in an OsmoTRX based BTS model those frames will be generated by OsmoTRX and do not appear on the PCUIF interface. When the BTS model is left unspecified, then the PCU will generate those DUMMY messages and irretate the testsuite. Related: OS#6191 Change-Id: I6b516eece6acc96ebde9759bcb609197a245dd84 --- M pcu/PCU_Tests.ttcn 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index fb935d9..442d617 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -112,7 +112,7 @@ remote_port := { mp_nsconfig.nsvc[0].provider.ip.local_udp_port, 0 }, remote_addr := f_PCUIF_RemoteAddr( f_PCUIF_AF2addr_type(mp_nsconfig.nsvc[0].provider.ip.address_family), mp_nsconfig.nsvc[0].provider.ip.local_ip), - bts_model := PCU_IF_BTS_MODEL_UNSPEC + bts_model := PCU_IF_BTS_MODEL_TRX } /* Passed in RAN-INFO message from emulated neighbor using RIM */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6b516eece6acc96ebde9759bcb609197a245dd84 Gerrit-Change-Number: 35144 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625-dirty → 1.10.3
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: daniel, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625-dirty → 1.10.3 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File gtp/Makefile.am: https://gerrit.osmocom.org/c/osmo-ggsn/+/35149/comment/d56dbb2a_9ece2d04 PS1, Line 5: LIBVERSION=9:1:3 this is wrong, a new API gtp_cause_successful() has been added. It should be LIBVERSION=10:0:4. And hence not a patch release, but a minor release. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:34:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: falconia, fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:32:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: Bump version: 1.10.2.1-a625-dirty → 1.10.3
by osmith 28 Nov '23

28 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email ) Change subject: Bump version: 1.10.2.1-a625-dirty → 1.10.3 ...................................................................... Bump version: 1.10.2.1-a625-dirty → 1.10.3 Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 --- M debian/changelog M gtp/Makefile.am 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/49/35149/1 diff --git a/debian/changelog b/debian/changelog index f72d9f6..ef41e67 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-ggsn (1.10.3) unstable; urgency=medium + + [ Daniel Willmann ] + * gtp: Add net GTP cause values and a function to check for success + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 28 Nov 2023 13:28:24 +0100 + osmo-ggsn (1.10.2) unstable; urgency=medium [ Vadim Yanitskiy ] diff --git a/gtp/Makefile.am b/gtp/Makefile.am index cb32da7..99ad8bb 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -2,7 +2,7 @@ # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html # If major=current-age is increased, remember to update the dh_strip line in debian/rules! -LIBVERSION=9:0:3 +LIBVERSION=9:1:3 lib_LTLIBRARIES = libgtp.la -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1f116e1cded135f231f22ebc9b817aebf3736fc2 Gerrit-Change-Number: 35149 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests: tell PCU a more realistic BTS model
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35144?usp=email ) Change subject: PCU_Tests: tell PCU a more realistic BTS model ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6b516eece6acc96ebde9759bcb609197a245dd84 Gerrit-Change-Number: 35144 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:29:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0b37f01f4c7bb829053231339e39ab734f4c8cbc Gerrit-Change-Number: 35136 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: test_call: codecs: allow specific PT numbers [2/2]
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35141?usp=email ) Change subject: test_call: codecs: allow specific PT numbers [2/2] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I25df2ed7ad792fbe66dfd0fbf08182c9cf6cfc5b Gerrit-Change-Number: 35141 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: test_call: codecs: allow specific PT numbers [1/2]
by pespin 28 Nov '23

28 Nov '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35140?usp=email ) Change subject: test_call: codecs: allow specific PT numbers [1/2] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I618e3cf1b412985589a0c63bd76b7a60202f17b9 Gerrit-Change-Number: 35140 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:24:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0