November 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[osmith/1.9.1]: Bump version: 1.9.0.1-7d414-dirty → 1.9.1

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35143?usp=email ) Change subject: Bump version: 1.9.0.1-7d414-dirty → 1.9.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I2ce06826d6b11bcd88daa99fada77a05f740eb7a Gerrit-Change-Number: 35143 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 11:17:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[osmith/1.9.1]: logging: ensure ANSI color escape is sent in same line/before newline

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 35142 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 11:17:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[osmith/1.9.1]: logging: ensure ANSI color escape is sent in same line/before newline

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The patch is quite the usability improvement for "journalctl -a", making a backport of it as discussed in today's meeting. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 35142 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 10:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[osmith/1.9.1]: Bump version: 1.9.0.1-7d414-dirty → 1.9.1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35143?usp=email ) Change subject: Bump version: 1.9.0.1-7d414-dirty → 1.9.1 ...................................................................... Bump version: 1.9.0.1-7d414-dirty → 1.9.1 Change-Id: I2ce06826d6b11bcd88daa99fada77a05f740eb7a --- M debian/changelog M src/core/Makefile.am 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/35143/1 diff --git a/debian/changelog b/debian/changelog index c9184df..012a76d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libosmocore (1.9.1) unstable; urgency=medium + + [ Manawyrm ] + * logging: ensure ANSI color escape is sent in same line/before newline + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 28 Nov 2023 11:21:41 +0100 + libosmocore (1.9.0) unstable; urgency=medium [ Oliver Smith ] diff --git a/src/core/Makefile.am b/src/core/Makefile.am index 326c68d..109aae7 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=21:0:0 +LIBVERSION=21:1:0 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_builddir) AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) $(LIBSCTP_CFLAGS) $(LIBMNL_CFLAGS) $(URING_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I2ce06826d6b11bcd88daa99fada77a05f740eb7a Gerrit-Change-Number: 35143 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[osmith/1.9.1]: logging: ensure ANSI color escape is sent in same line/before newline

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... logging: ensure ANSI color escape is sent in same line/before newline This fixes multi-line color clobbering in logging daemons like systemd-journald, which work with single-lines only. Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Closes: OS#6249 (cherry picked from commit 11a416827dd9f2da6b7c1db0e1e83adb1e6e5cc8) --- M src/core/logging.c M tests/loggingrb/logging_test.err 2 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/35142/1 diff --git a/src/core/logging.c b/src/core/logging.c index c6774f5..dc19cf3 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -616,7 +616,15 @@ } if (target->use_color && c_subsys) { - ret = snprintf(buf + offset, rem, OSMO_LOGCOLOR_END); + /* Ensure the last color escape is sent before the newline + * (to not clobber journald, which works on single-lines only) */ + if (offset > 0 && buf[offset - 1] == '\n') { + offset--; rem++; + ret = snprintf(buf + offset, rem, OSMO_LOGCOLOR_END "\n"); + } else { + ret = snprintf(buf + offset, rem, OSMO_LOGCOLOR_END); + } + if (ret < 0) goto err; OSMO_SNPRINTF_RET(ret, rem, offset, len); diff --git a/tests/loggingrb/logging_test.err b/tests/loggingrb/logging_test.err index b59d2e8..e070561 100644 --- a/tests/loggingrb/logging_test.err +++ b/tests/loggingrb/logging_test.err @@ -1,3 +1,2 @@ -[1;31mYou should see this -[0;m[1;32mYou should see this -[0;m \ No newline at end of file +[1;31mYou should see this[0;m +[1;32mYou should see this[0;m -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 35142 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ttcn3-pcu-test/sns: fix PCUIF version number ...................................................................... ttcn3-pcu-test/sns: fix PCUIF version number The current master of OsmoPCU is now using PCUIF version number 12. However, the configuration file of the the SNS tests still sets it to 11. Related: OS#6275 Change-Id: I0b37f01f4c7bb829053231339e39ab734f4c8cbc --- M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/sns/PCU_Tests.cfg 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/36/35136/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0b37f01f4c7bb829053231339e39ab734f4c8cbc Gerrit-Change-Number: 35136 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Just to be sure, doesn't this patch break the `-latest`? […] you probably mean jenkins-sns.sh. Yes I also thing that it needs upgrading as well. When we change the version number from 11 to 12 in PCU_Tests.cfg, then the SED commandline in jenkins-sns.sh needs to be updated as well. I have updated the patch now. In any case I can see no relation to ttcn3-pcu-test-latest here. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0b37f01f4c7bb829053231339e39ab734f4c8cbc Gerrit-Change-Number: 35136 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 10:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email ) Change subject: Make BSSGP timing data configurable ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc/bts_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12664): https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/82cb6fbd_e52e7353 PS6, Line 1755: if (osmo_tdef_set(bts_bssgp->tdefs, tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0) spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6 Gerrit-Change-Number: 31882 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 10:02:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands

by arehbein

Attention is currently required from: arehbein, fixeria, laforge, neels, pespin. Hello Jenkins Builder, fixeria, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce per-BTS timers, RLC timer commands ...................................................................... Introduce per-BTS timers, RLC timer commands - Add per-BTS timer groups ('rlc' only for now, others to follow) - Add vty commands & tests for those timers Related: OS#5335 Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/vty.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_init.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/pcu_sock.c M tests/bts_features.vty M tests/nanobts_omlattr/nanobts_omlattr_test.c 12 files changed, 473 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/31878/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 16 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email ) Change subject: Make BSSGP timing data configurable ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc/bts_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12662): https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/ca036c67_466958e6 PS5, Line 1755: if (osmo_tdef_set(bts_bssgp->tdefs, tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0) spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6 Gerrit-Change-Number: 31882 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Nov 2023 09:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023