October 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[rel-1.8.1]: Bump version: 1.8.0.21-fbd0 → 1.8.1
by pespin 17 Oct '23

17 Oct '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email ) Change subject: Bump version: 1.8.0.21-fbd0 → 1.8.1 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: it's fine. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: rel-1.8.1 Gerrit-Change-Id: If84e8cf8769550c97552832c5cb97ebba830341d Gerrit-Change-Number: 34781 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:16:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: osmo_epdg_app: Fix formatting error in log string
by laforge 17 Oct '23

17 Oct '23

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email ) Change subject: osmo_epdg_app: Fix formatting error in log string ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ib8dfa40ad028f959e4816ce5056ff64d52ec647b Gerrit-Change-Number: 34742 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/DIAMETER: Add several AVPs required for SWx interface
by laforge 17 Oct '23

17 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34776?usp=email ) Change subject: library/DIAMETER: Add several AVPs required for SWx interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If31e14215fc7fb18cef12d68600b4f170bbb68af Gerrit-Change-Number: 34776 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:15:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/DIAMETER: Allow passing template as imsi param to tr_AVP_User...
by laforge 17 Oct '23

17 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34775?usp=email ) Change subject: library/DIAMETER: Allow passing template as imsi param to tr_AVP_UserNameImsi() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia525b2a1850bc80cee13717b114fec215fa84f9f Gerrit-Change-Number: 34775 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:15:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/GSUP: Add tr templates for tr_GSUP_IE_AuthTuple2G3G() and sub...
by laforge 17 Oct '23

17 Oct '23

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34774?usp=email ) Change subject: library/GSUP: Add tr templates for tr_GSUP_IE_AuthTuple2G3G() and subfields ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34774?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I39babec53f89c11b9a822939af7267aa1111dc8b Gerrit-Change-Number: 34774 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:15:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[rel-1.8.1]: Bump version: 1.8.0.21-fbd0 → 1.8.1
by laforge 17 Oct '23

17 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email ) Change subject: Bump version: 1.8.0.21-fbd0 → 1.8.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: please specifically check if the LIBVERSION increment is correct for a change that doesn't add or remove interfaces. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: rel-1.8.1 Gerrit-Change-Id: If84e8cf8769550c97552832c5cb97ebba830341d Gerrit-Change-Number: 34781 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[rel-1.8.1]: Bump version: 1.8.0.21-fbd0 → 1.8.1
by laforge 17 Oct '23

17 Oct '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email ) Change subject: Bump version: 1.8.0.21-fbd0 → 1.8.1 ...................................................................... Bump version: 1.8.0.21-fbd0 → 1.8.1 Change-Id: If84e8cf8769550c97552832c5cb97ebba830341d --- M debian/changelog M src/Makefile.am 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/81/34781/1 diff --git a/debian/changelog b/debian/changelog index 8714beb..cd1c181 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libosmo-sccp (1.8.1) unstable; urgency=medium + + * Fix counting received IPA packets in server mode + + -- Harald Welte <laforge(a)osmocom.org> Tue, 17 Oct 2023 13:11:24 +0200 + libosmo-sccp (1.8.0) unstable; urgency=medium [ Neels Hofmeyr ] diff --git a/src/Makefile.am b/src/Makefile.am index f20e193..c87848d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -25,7 +25,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=9:0:0 +LIBVERSION=9:1:0 libosmo_sigtran_la_SOURCES = sccp_sap.c sua.c m3ua.c xua_msg.c sccp_helpers.c \ sccp2sua.c sccp_scrc.c sccp_sclc.c sccp_scoc.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: rel-1.8.1 Gerrit-Change-Id: If84e8cf8769550c97552832c5cb97ebba830341d Gerrit-Change-Number: 34781 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-sccp[rel-1.8.1]: Fix counting received IPA packets in server mode
by laforge 17 Oct '23

17 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34780?usp=email ) Change subject: Fix counting received IPA packets in server mode ...................................................................... Fix counting received IPA packets in server mode When operating an IPA ASP in server mode, we were not counting the packets using the related stat item: For example: OsmoSTP# show stats Ungrouped counters: SIGTRAN Application Server Process (6)('asp-dyn-5'): Total number of packets received: 0 (0/s 0/m 0/h 0/d) Total number of packets transmitted: 235370503 (129/s 7682/m 442447/h 11342653/d) This patch adds the missing counter increment. back-port of Change-Id I75881d115b5c2c2567c4731bcf2cabe11f367117 from master Closes: SYS#6600 Change-Id: I96488e4ea10e00f5f03387e33dc58e4b5016458f --- M src/osmo_ss7_asp.c 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index 596e7ae..e1c197c 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -905,7 +905,7 @@ return -1; } msg->dst = asp; - + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: rel-1.8.1 Gerrit-Change-Id: I96488e4ea10e00f5f03387e33dc58e4b5016458f Gerrit-Change-Number: 34780 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: Fix counting received IPA packets in server mode
by laforge 17 Oct '23

17 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34779?usp=email ) Change subject: Fix counting received IPA packets in server mode ...................................................................... Fix counting received IPA packets in server mode When operating an IPA ASP in server mode, we were not counting the packets using the related stat item: For example: OsmoSTP# show stats Ungrouped counters: SIGTRAN Application Server Process (6)('asp-dyn-5'): Total number of packets received: 0 (0/s 0/m 0/h 0/d) Total number of packets transmitted: 235370503 (129/s 7682/m 442447/h 11342653/d) This patch adds the missing counter increment. Change-Id: I75881d115b5c2c2567c4731bcf2cabe11f367117 Closes: SYS#6600 --- M src/osmo_ss7_asp.c 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index 1ba0a43..0662085 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -753,7 +753,7 @@ return -1; } msg->dst = asp; - + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I75881d115b5c2c2567c4731bcf2cabe11f367117 Gerrit-Change-Number: 34779 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[rel-1.8.1]: Fix counting received IPA packets in server mode
by pespin 17 Oct '23

17 Oct '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34780?usp=email ) Change subject: Fix counting received IPA packets in server mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: rel-1.8.1 Gerrit-Change-Id: I96488e4ea10e00f5f03387e33dc58e4b5016458f Gerrit-Change-Number: 34780 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0