October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: csd_bs: force rate adaptation mode for CSD calls to V.110

by laforge

Attention is currently required from: manawyrm. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34748?usp=email ) Change subject: csd_bs: force rate adaptation mode for CSD calls to V.110 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5b3e5649fe071636f1becddfbfee06f9175a5f17 Gerrit-Change-Number: 34748 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

[S] Change in libosmocore[master]: gsm48_ie.c: add 3.1kHz audio bearer capability for CSD calls

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34744?usp=email ) Change subject: gsm48_ie.c: add 3.1kHz audio bearer capability for CSD calls ...................................................................... gsm48_ie.c: add 3.1kHz audio bearer capability for CSD calls GSM48_BCAP_ITCAP_3k1_AUDIO should be handled just like fax or unregistricted digital CSD calls. The transfer capability just indicates that an (external) interworking function should convert the call into an analog modem call on the network edge. The CSD call is still regular V.110/RLP non-transparent data. Change-Id: I44b76be0f6a891bc1d8f55ede1ef140ea0a19e3d --- M src/gsm/gsm48_ie.c 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 0cdcb7c..7de1f98 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -233,6 +233,7 @@ } break; case GSM_MNCC_BCAP_UNR_DIG: + case GSM_MNCC_BCAP_AUDIO: case GSM_MNCC_BCAP_FAX_G3: i = 1; while (!(lv[i] & 0x80)) { @@ -334,6 +335,7 @@ lv[i] |= 0x80; /* last IE of octet 3 etc */ break; case GSM48_BCAP_ITCAP_UNR_DIG_INF: + case GSM48_BCAP_ITCAP_3k1_AUDIO: case GSM48_BCAP_ITCAP_FAX_G3: lv[i++] |= 0x80; /* last IE of octet 3 etc */ /* octet 4 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I44b76be0f6a891bc1d8f55ede1ef140ea0a19e3d Gerrit-Change-Number: 34744 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

[S] Change in libosmocore[master]: gsm48_ie.c: change bearer cap structure in outgoing CSD calls

by laforge

Attention is currently required from: manawyrm. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34746?usp=email ) Change subject: gsm48_ie.c: change bearer cap structure in outgoing CSD calls ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieb5bca3d3578abd28e18808752e1c312ce7c4ce0 Gerrit-Change-Number: 34746 Gerrit-PatchSet: 4 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:21:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

[S] Change in libosmocore[master]: gsm48_ie.c: add 3.1kHz audio bearer capability for CSD calls

by laforge

Attention is currently required from: manawyrm. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34744?usp=email ) Change subject: gsm48_ie.c: add 3.1kHz audio bearer capability for CSD calls ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I44b76be0f6a891bc1d8f55ede1ef140ea0a19e3d Gerrit-Change-Number: 34744 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:21:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hss: Add missing test in expected-results.xml

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34764?usp=email ) Change subject: hss: Add missing test in expected-results.xml ...................................................................... hss: Add missing test in expected-results.xml Change-Id: I890bcd2f8ffa74e43b5a593dbf8547af5fccd40d --- M hss/expected-results.xml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/hss/expected-results.xml b/hss/expected-results.xml index 8e8d1df..f9b5c97 100644 --- a/hss/expected-results.xml +++ b/hss/expected-results.xml @@ -1,4 +1,5 @@ <?xml version="1.0"?> <testsuite name='Titan' tests='1' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HSS_Tests' name='TC_ulr_ula' time='MASKED'/> + <testcase classname='HSS_Tests' name='TC_ulr_ula_subscr_op_det_barring_7' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I890bcd2f8ffa74e43b5a593dbf8547af5fccd40d Gerrit-Change-Number: 34764 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: osmo_epdg_app: Fix formatting error in log string

by laforge

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email ) Change subject: osmo_epdg_app: Fix formatting error in log string ...................................................................... Patch Set 1: (1 comment) File src/osmo_epdg_app.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742/comment/fbda929f_d2ad… PS1, Line 8: ~n From https://riak.com/posts/technical/introducing-lager-a-new-logging-framework-… > Also notice that you don’t need to stick a newline on the end of the log message. Lager automatically (and happily) does that for you. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ib8dfa40ad028f959e4816ce5056ff64d52ec647b Gerrit-Change-Number: 34742 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Oct 2023 11:20:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email to look at the new patch set (#4). Change subject: Introduce EPDG_Tests testsuite ...................................................................... Introduce EPDG_Tests testsuite Relted: OS#6204 Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 --- M Makefile A epdg/EPDG_Tests.cfg A epdg/EPDG_Tests.default A epdg/EPDG_Tests.ttcn A epdg/gen_links.sh A epdg/regen_makefile.sh M library/DIAMETER_Templates.ttcn M library/GSUP_Types.ttcn 8 files changed, 748 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/34778/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: WIP

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34782?usp=email ) Change subject: WIP ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b9b45eb4eed88ea5c1ba2b870c03b04f7f4c3b2 Gerrit-Change-Number: 34782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 8 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce EPDG_Tests testsuite ...................................................................... Introduce EPDG_Tests testsuite Relted: OS#6204 Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 --- M Makefile A epdg/EPDG_Tests.cfg A epdg/EPDG_Tests.default A epdg/EPDG_Tests.ttcn A epdg/gen_links.sh A epdg/regen_makefile.sh M library/DIAMETER_Templates.ttcn M library/GSUP_Types.ttcn 8 files changed, 629 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/34778/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: WIP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34782?usp=email ) Change subject: WIP ...................................................................... WIP Change-Id: I3b9b45eb4eed88ea5c1ba2b870c03b04f7f4c3b2 --- M epdg/EPDG_Tests.ttcn M library/DIAMETER_Templates.ttcn 2 files changed, 128 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/34782/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 69a3d9b..2006632 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -316,6 +316,26 @@ } } +/* Diameter SWx SAR + SAA. */ +private altstep as_DIA_SWx_SA_success() runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; + var template (omit) AVP avp; + var octetstring sess_id; + [] SWx.receive(tr_DIA_SWx_SAR(g_pars.imsi)) -> value rx_dia { + avp := f_DIAMETER_get_avp(rx_dia, c_AVP_Code_BASE_NONE_Session_Id); + sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); + /* Send SAA to translator; expect it to show up on GSUP side */ + SWx.send(ts_DIA_SWx_SAA(g_pars.imsi, + sess_id := sess_id, + hbh_id := rx_dia.hop_by_hop_id, + ete_id := rx_dia.end_to_end_id)); + setverdict(pass); + } + [] SWx.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter msg rx: ", rx_dia)); + } +} + /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; @@ -337,8 +357,25 @@ setverdict(pass); } +/* GSUP LU Req + Resp, triggers SWx SAR + SAA (Server Assignment). */ +private function f_GSUP_LU_success() runs on EPDG_ConnHdlr { + var GSUP_PDU rx_gsup; + var template octetstring destination_name := *; + GSUP.send(ts_GSUP_UL_REQ(g_pars.imsi)); + as_DIA_SWx_SA_success(); + /* Expect a positive response back to the translator; expect AIA */ + alt { + [] GSUP.receive(tr_GSUP_UL_RES(g_pars.imsi, destination_name)); + [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); + } + } + setverdict(pass); +} + private function f_TC_authinfo_normal(charstring id) runs on EPDG_ConnHdlr { f_GSUP_AI_success(); + f_GSUP_LU_success(); } testcase TC_authinfo_normal() runs on MTC_CT { diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index cb010d7..100159c 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -1031,7 +1031,7 @@ } } -/* TS 29.272 7.3.36 Service-Selection (refers to RFC 5778) */ +/* Service-Selection, TS 29.272 7.3.36, TS 29.273 5.2.3.5, (RFC 5778) */ template (present) GenericAVP tr_AVP_ServiceSelection(template (present) charstring apn := ?) := { avp := { avp_header := tr_DIA_Hdr(c_AVP_Code_MIPv6_NONE_Service_Selection), @@ -2258,6 +2258,24 @@ } } +/* Server-Assignment-Type, 3GPP TS 29.273 8.2.3.12, 3GPP TS 29.229 6.3.15 */ +template (present) GenericAVP tr_AVP_3GPP_ServerAssignmentType(template (present) CxDx_3GPP_Server_Assignment_Type t := ?) := { + avp := { + avp_header := tr_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_Server_Assignment_Type), + avp_data := { + avp_CxDx_3GPP_Server_Assignment_Type := t + } + } +} +template (value) GenericAVP ts_AVP_3GPP_ServerAssignmentType(template (value) CxDx_3GPP_Server_Assignment_Type t) := { + avp := { + avp_header := ts_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_Server_Assignment_Type), + avp_data := { + avp_CxDx_3GPP_Server_Assignment_Type := t + } + } +} + /***************************** * SWx 3GPP TS 29.273 *****************************/ @@ -2364,4 +2382,67 @@ ts_AVP_3GPP_SIPNumAuthDataItems(1) }); +/* Server-Assignment-Request, + * 3GPP TS 29.273 8.1.2.2.2 UE/PDN Registration/DeRegistration Notification + * 3GPP TS 29.273 8.2.2.3 Non-3GPP IP Access Registration Procedure */ +template (present) PDU_DIAMETER +tr_DIA_SWx_SAR(template (present) hexstring imsi := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?, + template (present) CxDx_3GPP_Server_Assignment_Type server_ass_type := ?, + template (present) charstring service_selection := ?) := + tr_DIAMETER(flags := '1???????'B, + cmd_code := Server_Assignment, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_VendorSpecAppId(?, ?), + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_DestinationRealm(dest_realm), + tr_AVP_UserNameImsi(imsi), + tr_AVP_3GPP_ServerAssignmentType(server_ass_type), + tr_AVP_ServiceSelection(service_selection) + )); + +/* Server-Assignment-Answer, + * 3GPP TS 29.273 8.1.2.2.2 UE/PDN Registration/DeRegistration Notification + * 3GPP TS 29.273 8.2.2.3 Non-3GPP IP Access Registration Procedure */ +template (value) PDU_DIAMETER +ts_DIA_SWx_SAA(template (value) hexstring imsi, + template (value) uint32_t vendor_app_id := c_DIAMETER_3GPP_SWx_AID, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '01000000'B, + cmd_code := Multimedia_Auth, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_VendorSpecAppId(vendor_id_3GPP, valueof(vendor_app_id)), + ts_AVP_ResultCode(DIAMETER_SUCCESS), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_UserNameImsi(valueof(imsi)) + /* TODO: + * [ Non-3GPP-User-Data ] + * [ 3GPP-AAA-Server-Name ] + * [ OC-Supported-Features ] + * [ OC-OLR ] ] + * *[ Load ] + * *[ Supported-Features ] + */ + }); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b9b45eb4eed88ea5c1ba2b870c03b04f7f4c3b2 Gerrit-Change-Number: 34782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2023