Attention is currently required from: arehbein, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
> I didn't prefix the function with osmo_-anything, because the other functions in gsmtap_util. […]
That's okay, we want to keep it consistent. The reason for the missing osmo_* is that this is very early code and we simply didn't use any common prefix back then. Now we're stuck with it due to backwards compatibility.
File src/core/libosmocore.map:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/a65667de_1be9595f
PS2, Line 42: gsmtap_inst_fd;
Not sure if this needs a line in TODO-RELEASE? It seems like an addition to the ABI, even if it was static inline in the header before.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Oct 2023 06:41:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I didn't prefix the function with osmo_-anything, because the other functions in gsmtap_util.h all begin with `gsmtap` or something other than osmo (because it's a util.h (?))
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Oct 2023 23:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
gsmtap: Hide implementation of gsmtap_inst
- Use forward decl. of struct gsmtap_inst in header
- Remove 'static inline' attributes from gsmtap_inst_fd() declaration,
move function definition to gsmtap_util.c
Related: OS#6213
Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
---
M include/osmocom/core/gsmtap_util.h
M src/core/gsmtap_util.c
M src/core/libosmocore.map
M src/core/logging_gsmtap.c
4 files changed, 33 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/34720/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34718?usp=email
to look at the new patch set (#2).
Change subject: hss: Test Operator-Determined-Barring feature
......................................................................
hss: Test Operator-Determined-Barring feature
Related: SYS#6588
Change-Id: I8deea9e284447f8991bdeced982c14fae2f211c5
---
M hss/HSS_Tests.ttcn
M library/DIAMETER_Templates.ttcn
2 files changed, 72 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/34718/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8deea9e284447f8991bdeced982c14fae2f211c5
Gerrit-Change-Number: 34718
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset