January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: modem: do not depend on $(top_srcdir)/src/misc/rslms.c

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30897 ) Change subject: modem: do not depend on $(top_srcdir)/src/misc/rslms.c ...................................................................... modem: do not depend on $(top_srcdir)/src/misc/rslms.c Change-Id: Ic4d7e1956530aa10ff3125d6d857efe47ea37d38 Related: SYS#5500 --- M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/app_modem.c 2 files changed, 67 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/30897/1 diff --git a/src/host/layer23/src/modem/Makefile.am b/src/host/layer23/src/modem/Makefile.am index 522456a..3fa1ceb 100644 --- a/src/host/layer23/src/modem/Makefile.am +++ b/src/host/layer23/src/modem/Makefile.am @@ -15,7 +15,6 @@ modem_SOURCES = \ $(top_srcdir)/src/common/main.c \ - $(top_srcdir)/src/misc/rslms.c \ app_modem.c \ $(NULL) modem_LDADD = \ diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index 48c216d..fbc7527 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -39,8 +39,6 @@ #include <osmocom/bb/common/l1ctl.h> #include <osmocom/bb/common/l23_app.h> #include <osmocom/bb/common/sysinfo.h> -#include <osmocom/bb/misc/rslms.h> -#include <osmocom/bb/misc/layer3.h> #include <l1ctl_proto.h> @@ -271,6 +269,70 @@ } } +static int rcv_rll_ud(struct osmocom_ms *ms, struct msgb *msg) +{ + const struct abis_rsl_rll_hdr *rllh = msgb_l2(msg); + struct tlv_parsed tv; + + DEBUGP(DRSL, "RSLms UNIT DATA IND chan_nr=0x%02x link_id=0x%02x\n", + rllh->chan_nr, rllh->link_id); + + if (rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg) - sizeof(*rllh)) < 0) { + LOGP(DRSL, LOGL_ERROR, "%s(): rsl_tlv_parse() failed\n", __func__); + return -EINVAL; + } + + if (!TLVP_PRESENT(&tv, RSL_IE_L3_INFO)) { + LOGP(DRSL, LOGL_ERROR, "UNIT_DATA_IND without L3 INFO ?!?\n"); + return -EINVAL; + } + + msg->l3h = (uint8_t *)TLVP_VAL(&tv, RSL_IE_L3_INFO); + + switch (rllh->chan_nr) { + case RSL_CHAN_PCH_AGCH: + return gsm48_rx_ccch(msg, ms); + case RSL_CHAN_BCCH: + return gsm48_rx_bcch(msg, ms); + default: + return 0; + } +} + +static int rcv_rll(struct osmocom_ms *ms, struct msgb *msg) +{ + const struct abis_rsl_rll_hdr *rllh = msgb_l2(msg); + + switch (rllh->c.msg_type) { + case RSL_MT_UNIT_DATA_IND: + return rcv_rll_ud(ms, msg); + default: + LOGP(DRSL, LOGL_NOTICE, "Unhandled RSLms RLL message " + "(msg_type 0x%02x)\n", rllh->c.msg_type); + return -EINVAL; + } +} + +static int rcv_rsl(struct msgb *msg, struct lapdm_entity *le, void *ctx) +{ + const struct abis_rsl_common_hdr *rslh = msgb_l2(msg); + int rc; + + switch (rslh->msg_discr & 0xfe) { + case ABIS_RSL_MDISC_RLL: + rc = rcv_rll((struct osmocom_ms *)ctx, msg); + break; + default: + LOGP(DRSL, LOGL_NOTICE, "Unhandled RSLms message " + "(msg_discr 0x%02x)\n", rslh->msg_discr); + rc = -EINVAL; + break; + } + + msgb_free(msg); + return rc; +} + void layer3_app_reset(void) { memset(&app_data, 0x00, sizeof(app_data)); @@ -306,7 +368,9 @@ osmo_signal_register_handler(SS_L1CTL, &signal_cb, NULL); l1ctl_tx_reset_req(ms, L1CTL_RES_T_FULL); - return layer3_init(ms); + lapdm_channel_set_l3(&ms->lapdm_channel, &rcv_rsl, ms); + + return 0; } static int l23_cfg_supported(void) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic4d7e1956530aa10ff3125d6d857efe47ea37d38 Gerrit-Change-Number: 30897 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: implement decoding of SI13 Rest Octets

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 to look at the new patch set (#10). Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ...................................................................... layer23/sysinfo: implement decoding of SI13 Rest Octets Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Related: SYS#5500 --- M src/host/layer23/include/osmocom/bb/common/sysinfo.h M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/mobile/gsm48_rr.c 3 files changed, 171 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/30812/10 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add spec ref for frame number calculation

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30894 ) Change subject: abis_rsl: add spec ref for frame number calculation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6 Gerrit-Change-Number: 30894 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 06 Jan 2023 17:29:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add spec ref for frame number calculation

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30894 ) Change subject: abis_rsl: add spec ref for frame number calculation ...................................................................... abis_rsl: add spec ref for frame number calculation The frame number calculation in rsl_rx_pchan_rqd() is done using a specific formula. Lets add a spec reference and also restructure the code a bit. Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index bb1c5d6..51824f5 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1814,11 +1814,13 @@ return -EINVAL; } else { is_11bit = 0; + rqd_ta = rqd->ta; + + /* See also 3GPP TS 04.08, section 10.5.2.38 and 3GPP TS 08.58, section 9.3.8 */ t1 = rqd->ref.t1; t2 = rqd->ref.t2; t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3); fn = (51 * ((t3-t2) % 26) + t3 + 51 * 26 * t1); - rqd_ta = rqd->ta; } return pcu_tx_rach_ind(rqd->bts, rqd_ta, rqd->ref.ra, fn, is_11bit, null-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6 Gerrit-Change-Number: 30894 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-upf-test: fetch /tmp/commit from gerrit, not from cgit

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30895 ) Change subject: ttcn3-upf-test: fetch /tmp/commit from gerrit, not from cgit ...................................................................... ttcn3-upf-test: fetch /tmp/commit from gerrit, not from cgit Change-Id: Id327720258a9ece1efb79db0d7c4fcbe19864c92 --- M ttcn3-upf-test/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/30895/1 diff --git a/ttcn3-upf-test/Dockerfile b/ttcn3-upf-test/Dockerfile index addc43f..c0e3d6c 100644 --- a/ttcn3-upf-test/Dockerfile +++ b/ttcn3-upf-test/Dockerfile @@ -3,7 +3,7 @@ FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" -ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ttcn3-hacks/+/$OSMO_TTCN3_B… /tmp/commit RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" upf VOLUME /data -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id327720258a9ece1efb79db0d7c4fcbe19864c92 Gerrit-Change-Number: 30895 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: */Dockerfile: clone from gerrit.osmocom.org using https://

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30896 ) Change subject: */Dockerfile: clone from gerrit.osmocom.org using https:// ...................................................................... */Dockerfile: clone from gerrit.osmocom.org using https:// * Do not clone using deprecated git://, use https:// instead. * Clone from the main repo gerrit.osmocom.org (if possible). * Use the gitiles plugin to fetch the last commit from Gerrit. Change-Id: I204fa6e3e3ebbdb8732393b897fca35659d61ae8 --- M fpga-build/Dockerfile M gr-gsm-master/Dockerfile M nplab-m3ua-test/Dockerfile M nplab-sua-test/Dockerfile M osmo-bsc-master/Dockerfile M osmo-bts-master/Dockerfile M osmo-cbc-master/Dockerfile M osmo-dev-on-debian-sid/Dockerfile M osmo-gbproxy-master/Dockerfile M osmo-ggsn-master/Dockerfile M osmo-hlr-master/Dockerfile M osmo-hnbgw-master/Dockerfile M osmo-hnodeb-master/Dockerfile M osmo-mgw-master/Dockerfile M osmo-msc-master/Dockerfile M osmo-nitb-master/Dockerfile M osmo-ns-master/Dockerfile M osmo-pcap-master/Dockerfile M osmo-pcu-master/Dockerfile M osmo-remsim-master/Dockerfile M osmo-sgsn-master/Dockerfile M osmo-sip-master/Dockerfile M osmo-smlc-master/Dockerfile M osmo-stp-master/Dockerfile M osmo-uecups-master/Dockerfile M osmo-upf-master/Dockerfile M osmocom-bb-host-master/Dockerfile 27 files changed, 59 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/30896/1 diff --git a/fpga-build/Dockerfile b/fpga-build/Dockerfile index 6e975a7..1421d29 100644 --- a/fpga-build/Dockerfile +++ b/fpga-build/Dockerfile @@ -39,13 +39,13 @@ ENV PATH=/opt/fpga-toolchain/bin:/opt/xpack-riscv-none-embed-gcc-${RISCV_TOOLCHAIN_VER}/bin:${PATH} # Install osmo-ci.git/scripts to /usr/local/bin -ADD http://git.osmocom.org/osmo-ci/patch /tmp/osmo-ci-commit -RUN git clone https://git.osmocom.org/osmo-ci osmo-ci && \ +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ci/+/master?format=TEXT /tmp/osmo-ci-commit +RUN git clone https://gerrit.osmocom.org/osmo-ci.git && \ cp -v $(find osmo-ci/scripts \ -maxdepth 1 \ -type f ) \ /usr/local/bin # Install osmo-gsm-manuals to /opt/osmo-gsm-manuals -ADD http://git.osmocom.org/osmo-gsm-manuals/patch /tmp/osmo-gsm-manuals-commit -RUN git -C /opt clone https://git.osmocom.org/osmo-gsm-manuals +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-gsm-manuals/+/master?format… /tmp/osmo-gsm-manuals-commit +RUN git -C /opt clone https://gerrit.osmocom.org/osmo-gsm-manuals diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile index f0e4e97..3301bfd 100644 --- a/gr-gsm-master/Dockerfile +++ b/gr-gsm-master/Dockerfile @@ -13,8 +13,8 @@ ARG GR_GSM_BRANCH="master" -RUN git clone git://git.osmocom.org/gr-gsm -ADD http://git.osmocom.org/gr-gsm/patch?h=$GR_GSM_BRANCH /tmp/commit-gr-gsm +RUN git clone https://gerrit.osmocom.org/gr-gsm +ADD https://gerrit.osmocom.org/plugins/gitiles/gr-gsm/+/$GR_GSM_BRANCH?format=T… /tmp/commit-gr-gsm RUN cd gr-gsm \ && git fetch && git checkout -f -B $GR_GSM_BRANCH origin/$GR_GSM_BRANCH \ diff --git a/nplab-m3ua-test/Dockerfile b/nplab-m3ua-test/Dockerfile index 1a53329..2f6ad93 100644 --- a/nplab-m3ua-test/Dockerfile +++ b/nplab-m3ua-test/Dockerfile @@ -2,7 +2,7 @@ FROM $USER/sigtran-tests -RUN cd /tmp && git clone git://git.osmocom.org/nplab/m3ua-testtool +RUN cd /tmp && git clone https://git.osmocom.org/nplab/m3ua-testtool ADD http://git.osmocom.org/nplab/m3ua-testtool/patch/?h=laforge/python3 /tmp/commit RUN cd /tmp/m3ua-testtool && \ git fetch && \ diff --git a/nplab-sua-test/Dockerfile b/nplab-sua-test/Dockerfile index 931623b..6bb3ad2 100644 --- a/nplab-sua-test/Dockerfile +++ b/nplab-sua-test/Dockerfile @@ -2,7 +2,7 @@ FROM $USER/sigtran-tests -RUN cd /tmp && git clone git://git.osmocom.org/nplab/sua-testtool +RUN cd /tmp && git clone https://git.osmocom.org/nplab/sua-testtool ADD http://git.osmocom.org/nplab/sua-testtool/patch/?h=laforge/python3 /tmp/commit RUN cd /tmp/sua-testtool && \ git fetch && \ diff --git a/osmo-bsc-master/Dockerfile b/osmo-bsc-master/Dockerfile index 32ded30..65ec5d4 100644 --- a/osmo-bsc-master/Dockerfile +++ b/osmo-bsc-master/Dockerfile @@ -36,8 +36,8 @@ ARG OSMO_BSC_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-bsc.git -ADD http://git.osmocom.org/osmo-bsc/patch?h=$OSMO_BSC_BRANCH /tmp/commit-osmo-bsc +RUN git clone https://gerrit.osmocom.org/osmo-bsc.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-bsc/+/$OSMO_BSC_BRANCH?form… /tmp/commit-osmo-bsc RUN cd osmo-bsc && \ git fetch && git checkout $OSMO_BSC_BRANCH && \ diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 67dd75f..8c43973 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -35,8 +35,8 @@ ARG OSMO_BTS_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-bts.git -ADD http://git.osmocom.org/osmo-bts/patch?h=$OSMO_BTS_BRANCH /tmp/commit-osmo-bts +RUN git clone https://gerrit.osmocom.org/osmo-bts.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-bts/+/$OSMO_BTS_BRANCH?form… /tmp/commit-osmo-bts RUN cd osmo-bts && \ git fetch && git checkout $OSMO_BTS_BRANCH && \ diff --git a/osmo-cbc-master/Dockerfile b/osmo-cbc-master/Dockerfile index a4ec904..0e90fc8 100644 --- a/osmo-cbc-master/Dockerfile +++ b/osmo-cbc-master/Dockerfile @@ -29,8 +29,8 @@ ARG OSMO_CBC_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-cbc.git -ADD http://git.osmocom.org/osmo-cbc/patch?h=$OSMO_CBC_BRANCH /tmp/commit-osmo-cbc +RUN git clone https://gerrit.osmocom.org/osmo-cbc.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-cbc/+/$OSMO_CBC_BRANCH?form… /tmp/commit-osmo-cbc RUN cd osmo-cbc && \ git fetch && git checkout $OSMO_CBC_BRANCH && \ diff --git a/osmo-dev-on-debian-sid/Dockerfile b/osmo-dev-on-debian-sid/Dockerfile index 81ba3cd..3b2791d 100644 --- a/osmo-dev-on-debian-sid/Dockerfile +++ b/osmo-dev-on-debian-sid/Dockerfile @@ -3,12 +3,13 @@ WORKDIR /build -ADD http://git.osmocom.org/osmo-dev/patch /build/commit-osmo-dev -RUN git clone git://git.osmocom.org/osmo-dev.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-dev/+/master?format=TEXT /build/commit-osmo-dev +RUN git clone https://gerrit.osmocom.org/osmo-dev.git RUN cd osmo-dev && \ ./gen_makefile.py 3G+2G.deps default.opts iu.opts -m make --ldconfig-without-sudo +# Not using gitiles plugin here because gen_makefile.py clones from git.osmocom.org ADD http://git.osmocom.org/libosmocore/patch /build/commit-libosmocore ADD http://git.osmocom.org/libosmo-abis/patch /build/commit-libosmo-abis ADD http://git.osmocom.org/libosmo-netif/patch /build/commit-libosmo-netif diff --git a/osmo-gbproxy-master/Dockerfile b/osmo-gbproxy-master/Dockerfile index 3e0e40c..484bb88 100644 --- a/osmo-gbproxy-master/Dockerfile +++ b/osmo-gbproxy-master/Dockerfile @@ -30,8 +30,8 @@ ARG OSMO_GBPROXY_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-gbproxy.git -ADD http://git.osmocom.org/osmo-gbproxy/patch?h=$OSMO_GBPROXY_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/osmo-gbproxy.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-gbproxy/+/$OSMO_GBPROXY_BRA… /tmp/commit-osmo-gbproxy RUN cd osmo-gbproxy && \ git fetch && git checkout $OSMO_GBPROXY_BRANCH && \ diff --git a/osmo-ggsn-master/Dockerfile b/osmo-ggsn-master/Dockerfile index 1a4504b..7f505d0 100644 --- a/osmo-ggsn-master/Dockerfile +++ b/osmo-ggsn-master/Dockerfile @@ -37,8 +37,9 @@ ARG OSMO_GGSN_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-ggsn.git -ADD http://git.osmocom.org/osmo-ggsn/patch/?h=$OSMO_GGSN_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/osmo-ggsn.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ggsn/+/$OSMO_GGSN_BRANCH?fo… /tmp/commit-osmo-ggsn + RUN cd osmo-ggsn && \ git fetch && git checkout $OSMO_GGSN_BRANCH && \ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_GGSN_BRANCH || exit 1); \ diff --git a/osmo-hlr-master/Dockerfile b/osmo-hlr-master/Dockerfile index 1c3251a..192c939 100644 --- a/osmo-hlr-master/Dockerfile +++ b/osmo-hlr-master/Dockerfile @@ -31,8 +31,8 @@ ARG OSMO_HLR_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-hlr.git -ADD http://git.osmocom.org/osmo-hlr/patch?h=$OSMO_HLR_BRANCH /tmp/commit-osmo-hlr +RUN git clone https://gerrit.osmocom.org/osmo-hlr.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-hlr/+/$OSMO_HLR_BRANCH?form… /tmp/commit-osmo-hlr RUN cd osmo-hlr && \ git fetch && git checkout $OSMO_HLR_BRANCH && \ diff --git a/osmo-hnbgw-master/Dockerfile b/osmo-hnbgw-master/Dockerfile index d842fb3..f69a6b4 100644 --- a/osmo-hnbgw-master/Dockerfile +++ b/osmo-hnbgw-master/Dockerfile @@ -23,8 +23,8 @@ ARG OSMO_HNBGW_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-hnbgw.git -ADD http://git.osmocom.org/osmo-hnbgw/patch?h=$OSMO_HNBGW_BRANCH /tmp/commit-osmo-hnbgw +RUN git clone https://gerrit.osmocom.org/osmo-hnbgw.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-hnbgw/+/$OSMO_HNBGW_BRANCH?… /tmp/commit-osmo-hnbgw RUN cd osmo-hnbgw && \ git fetch && git checkout $OSMO_HNBGW_BRANCH && \ diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile index 1a3ded9..ffdb639 100644 --- a/osmo-hnodeb-master/Dockerfile +++ b/osmo-hnodeb-master/Dockerfile @@ -17,8 +17,8 @@ ARG OSMO_IUH_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-iuh.git -ADD http://git.osmocom.org/osmo-iuh/patch?h=$OSMO_IUH_BRANCH /tmp/commit-osmo-iuh +RUN git clone https://gerrit.osmocom.org/osmo-iuh.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-iuh/+/$OSMO_IUH_BRANCH?form… /tmp/commit-osmo-iuh RUN cd osmo-iuh && \ git fetch && git checkout $OSMO_IUH_BRANCH && \ @@ -31,8 +31,8 @@ ARG OSMO_HNODEB_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-hnodeb.git -ADD http://git.osmocom.org/osmo-hnodeb/patch?h=$OSMO_HNODEB_BRANCH /tmp/commit-osmo-hnodeb +RUN git clone https://gerrit.osmocom.org/osmo-hnodeb.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-hnodeb/+/$OSMO_HNODEB_BRANC… /tmp/commit-osmo-hnodeb RUN cd osmo-hnodeb && \ git fetch && git checkout $OSMO_HNODEB_BRANCH && \ diff --git a/osmo-mgw-master/Dockerfile b/osmo-mgw-master/Dockerfile index dea4951..20b5b1a 100644 --- a/osmo-mgw-master/Dockerfile +++ b/osmo-mgw-master/Dockerfile @@ -31,8 +31,8 @@ ARG OSMO_MGW_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-mgw.git -ADD http://git.osmocom.org/osmo-mgw/patch?h=$OSMO_MGW_BRANCH /tmp/commit-osmo-mgw +RUN git clone https://gerrit.osmocom.org/osmo-mgw.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-mgw/+/$OSMO_MGW_BRANCH?form… /tmp/commit-osmo-mgw RUN cd osmo-mgw && \ diff --git a/osmo-msc-master/Dockerfile b/osmo-msc-master/Dockerfile index 7d79988..7a0362d 100644 --- a/osmo-msc-master/Dockerfile +++ b/osmo-msc-master/Dockerfile @@ -44,8 +44,8 @@ ARG OSMO_MSC_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-msc.git -ADD http://git.osmocom.org/osmo-msc/patch?h=$OSMO_MSC_BRANCH /tmp/commit-osmo-msc +RUN git clone https://gerrit.osmocom.org/osmo-msc.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-msc/+/$OSMO_MSC_BRANCH?form… /tmp/commit-osmo-msc RUN cd osmo-msc && \ git fetch && git checkout $OSMO_MSC_BRANCH && \ diff --git a/osmo-nitb-master/Dockerfile b/osmo-nitb-master/Dockerfile index 43a8d22..aa82a5f 100644 --- a/osmo-nitb-master/Dockerfile +++ b/osmo-nitb-master/Dockerfile @@ -18,8 +18,8 @@ ARG OSMO_NITB_BRANCH="master" -RUN git clone git://git.osmocom.org/openbsc.git -ADD http://git.osmocom.org/openbsc/patch?h=$OSMO_NITB_BRANCH /tmp/commit-openbsc +RUN git clone https://gerrit.osmocom.org/openbsc.git +ADD https://gerrit.osmocom.org/plugins/gitiles/openbsc/+/$OSMO_NITB_BRANCH?form… /tmp/commit-openbsc RUN cd openbsc/openbsc && \ git fetch && git checkout $OSMO_NITB_BRANCH && \ diff --git a/osmo-ns-master/Dockerfile b/osmo-ns-master/Dockerfile index 2f88c83..b5164a6 100644 --- a/osmo-ns-master/Dockerfile +++ b/osmo-ns-master/Dockerfile @@ -22,8 +22,8 @@ ARG LIBOSMOCORE_BRANCH="master" -RUN git clone git://git.osmocom.org/libosmocore.git -ADD http://git.osmocom.org/libosmocore/patch?h=$LIBOSMOCORE_BRANCH /tmp/commit-libosmocore +RUN git clone https://gerrit.osmocom.org/libosmocore.git +ADD https://gerrit.osmocom.org/plugins/gitiles/libosmocore/+/$LIBOSMOCORE_BRANC… /tmp/commit-libosmocore RUN cd libosmocore && \ git fetch && git checkout $LIBOSMOCORE_BRANCH && \ diff --git a/osmo-pcap-master/Dockerfile b/osmo-pcap-master/Dockerfile index eeb210c..e595bc1 100644 --- a/osmo-pcap-master/Dockerfile +++ b/osmo-pcap-master/Dockerfile @@ -28,8 +28,8 @@ ARG OSMO_PCAP_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-pcap.git -ADD http://git.osmocom.org/osmo-pcap/patch?h=$OSMO_PCAP_BRANCH /tmp/commit-osmo-pcap +RUN git clone https://gerrit.osmocom.org/osmo-pcap.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-pcap/+/$OSMO_PCAP_BRANCH?fo… /tmp/commit-osmo-pcap RUN cd osmo-pcap && \ git fetch && git checkout $OSMO_PCAP_BRANCH && \ diff --git a/osmo-pcu-master/Dockerfile b/osmo-pcu-master/Dockerfile index 41cd6d5..ac0fc1e 100644 --- a/osmo-pcu-master/Dockerfile +++ b/osmo-pcu-master/Dockerfile @@ -25,8 +25,8 @@ ARG OSMO_PCU_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-pcu.git -ADD http://git.osmocom.org/osmo-pcu/patch?h=$OSMO_PCU_BRANCH /tmp/commit-osmo-pcu +RUN git clone https://gerrit.osmocom.org/osmo-pcu.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-pcu/+/$OSMO_PCU_BRANCH?form… /tmp/commit-osmo-pcu RUN cd osmo-pcu && \ git fetch && git checkout $OSMO_PCU_BRANCH && \ diff --git a/osmo-remsim-master/Dockerfile b/osmo-remsim-master/Dockerfile index 173f243..c21bcbb 100644 --- a/osmo-remsim-master/Dockerfile +++ b/osmo-remsim-master/Dockerfile @@ -65,8 +65,8 @@ ARG OSMO_REMSIM_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-remsim.git -ADD http://git.osmocom.org/osmo-remsim/patch?h=$OSMO_REMSIM_BRANCH /tmp/commit-osmo-remsim +RUN git clone https://gerrit.osmocom.org/osmo-remsim.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-remsim/+/$OSMO_REMSIM_BRANC… /tmp/commit-osmo-remsim RUN cd osmo-remsim && \ git fetch && git checkout $OSMO_REMSIM_BRANCH && \ diff --git a/osmo-sgsn-master/Dockerfile b/osmo-sgsn-master/Dockerfile index 55d9695..edd912f 100644 --- a/osmo-sgsn-master/Dockerfile +++ b/osmo-sgsn-master/Dockerfile @@ -42,8 +42,8 @@ ARG OSMO_SGSN_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-sgsn.git -ADD http://git.osmocom.org/osmo-sgsn/patch?h=$OSMO_SGSN_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/osmo-sgsn.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-sgsn/+/$OSMO_SGSN_BRANCH?fo… /tmp/commit-osmo-sgsn RUN cd osmo-sgsn && \ git fetch && git checkout $OSMO_SGSN_BRANCH && \ diff --git a/osmo-sip-master/Dockerfile b/osmo-sip-master/Dockerfile index 3261a55..71fcf53 100644 --- a/osmo-sip-master/Dockerfile +++ b/osmo-sip-master/Dockerfile @@ -25,8 +25,8 @@ ARG OSMO_SIP_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-sip-connector.git -ADD http://git.osmocom.org/osmo-sip-connector/patch?h=$OSMO_SIP_BRANCH /tmp/commit-osmo-sip-connector +RUN git clone https://gerrit.osmocom.org/osmo-sip-connector.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-sip-connector/+/$OSMO_SIP_B… /tmp/commit-osmo-sip-connector RUN cd osmo-sip-connector && \ git fetch && git checkout $OSMO_SIP_BRANCH && \ diff --git a/osmo-smlc-master/Dockerfile b/osmo-smlc-master/Dockerfile index b814f7a..c602268 100644 --- a/osmo-smlc-master/Dockerfile +++ b/osmo-smlc-master/Dockerfile @@ -30,8 +30,8 @@ ARG OSMO_SMLC_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-smlc.git -ADD http://git.osmocom.org/osmo-smlc/patch?h=$OSMO_SMLC_BRANCH /tmp/commit-osmo-smlc +RUN git clone https://gerrit.osmocom.org/osmo-smlc.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-smlc/+/$OSMO_SMLC_BRANCH?fo… /tmp/commit-osmo-smlc RUN cd osmo-smlc && \ git fetch && git checkout $OSMO_SMLC_BRANCH && \ diff --git a/osmo-stp-master/Dockerfile b/osmo-stp-master/Dockerfile index 7061e89..2e6ecd6 100644 --- a/osmo-stp-master/Dockerfile +++ b/osmo-stp-master/Dockerfile @@ -25,8 +25,9 @@ ARG OSMO_STP_BRANCH="master" -RUN git clone git://git.osmocom.org/libosmo-sccp.git -ADD http://git.osmocom.org/libosmo-sccp/patch?h=$OSMO_STP_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/libosmo-sccp.git +ADD https://gerrit.osmocom.org/plugins/gitiles/libosmo-sccp/+/$OSMO_STP_BRANCH?… /tmp/commit-libosmo-sccp + RUN cd libosmo-sccp && \ git fetch && git checkout $OSMO_STP_BRANCH && \ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_STP_BRANCH || exit 1); \ diff --git a/osmo-uecups-master/Dockerfile b/osmo-uecups-master/Dockerfile index 74469e5..7841b32 100644 --- a/osmo-uecups-master/Dockerfile +++ b/osmo-uecups-master/Dockerfile @@ -19,8 +19,8 @@ ARG OSMO_UECUPS_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-uecups.git -ADD http://git.osmocom.org/osmo-uecups/patch?h=$OSMO_UECUPS_BRANCH /tmp/commit-osmo-uecups +RUN git clone https://gerrit.osmocom.org/osmo-uecups.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-uecups/+/$OSMO_UECUPS_BRANC… /tmp/commit-osmo-uecups RUN cd osmo-uecups && \ git fetch && git checkout $OSMO_UECUPS_BRANCH && \ diff --git a/osmo-upf-master/Dockerfile b/osmo-upf-master/Dockerfile index 7c5c1e6..97cdd95 100644 --- a/osmo-upf-master/Dockerfile +++ b/osmo-upf-master/Dockerfile @@ -29,8 +29,8 @@ ARG OSMO_UPF_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-upf.git -ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-upf/+/refs/heads/$OSMO_UPF_… /tmp/commit-osmo-upf +RUN git clone https://gerrit.osmocom.org/osmo-upf.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-upf/+/$OSMO_UPF_BRANCH?form… /tmp/commit-osmo-upf RUN cd osmo-upf && \ git fetch && git checkout $OSMO_UPF_BRANCH && \ diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile index 21c7f31..efc9925 100644 --- a/osmocom-bb-host-master/Dockerfile +++ b/osmocom-bb-host-master/Dockerfile @@ -12,9 +12,9 @@ WORKDIR /tmp -RUN git clone git://git.osmocom.org/osmocom-bb.git +RUN git clone https://gerrit.osmocom.org/osmocom-bb.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmocom-bb/+/$OSMO_BB_BRANCH?for… /tmp/commit-osmocom-bb -ADD http://git.osmocom.org/osmocom-bb/patch?h=$OSMO_BB_BRANCH /tmp/commit RUN cd osmocom-bb && \ git fetch && git checkout $OSMO_BB_BRANCH && \ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_BB_BRANCH || exit 1); \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I204fa6e3e3ebbdb8732393b897fca35659d61ae8 Gerrit-Change-Number: 30896 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add spec ref for frame number calculation

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30894 ) Change subject: abis_rsl: add spec ref for frame number calculation ...................................................................... abis_rsl: add spec ref for frame number calculation The frame number calculation in rsl_rx_pchan_rqd() is done using a specific formula. Lets add a spec reference and also restructure the code a bit. Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/30894/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index bb1c5d6..51824f5 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1814,11 +1814,13 @@ return -EINVAL; } else { is_11bit = 0; + rqd_ta = rqd->ta; + + /* See also 3GPP TS 04.08, section 10.5.2.38 and 3GPP TS 08.58, section 9.3.8 */ t1 = rqd->ref.t1; t2 = rqd->ref.t2; t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3); fn = (51 * ((t3-t2) % 26) + t3 + 51 * 26 * t1); - rqd_ta = rqd->ta; } return pcu_tx_rach_ind(rqd->bts, rqd_ta, rqd->ref.ra, fn, is_11bit, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6 Gerrit-Change-Number: 30894 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 ) Change subject: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: Confirmed to fix LCLS testcases by running ttcn3-bsc-test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69ab8699b0be80b12e2df590d9170a743a00d035 Gerrit-Change-Number: 30893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Jan 2023 15:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 ) Change subject: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly ...................................................................... fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly As stated in the comment near the t_def_TestHdlrPars definition, valueof() shall not be used for getting a value of this template. The f_gen_test_hdlr_pars() function should be used instead. All LCLS testcases violated this, and started to fail since recently after patch [1] has been merged: "MSC_ConnectionHandler.ttcn:820 : Either imsi or imei must be set!" BSC_Tests_LCLS.ttcn:743 BSC_Tests_LCLS control part BSC_Tests_LCLS.ttcn:262 TC_lcls_gcr_only testcase Use f_gen_test_hdlr_pars() as suggested. Change-Id: I69ab8699b0be80b12e2df590d9170a743a00d035 Fixes: [1] b27653c6b60d49de5e67dfffb876d1a8b7091ff2 --- M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_LCLS.ttcn 2 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/30893/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index c0a64a9..a9d7c9d 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -22,6 +22,7 @@ friend module BSC_Tests_VAMOS; friend module BSC_Tests_CBSP; +friend module BSC_Tests_LCLS; import from Misc_Helpers all; import from General_Types all; diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn index 0e7692c..6686a34 100644 --- a/bsc/BSC_Tests_LCLS.ttcn +++ b/bsc/BSC_Tests_LCLS.ttcn @@ -249,7 +249,7 @@ /* Send an ASSIGNMENT REQ with LCLS GCR only, without LCLS CFG or CSC */ testcase TC_lcls_gcr_only() runs on lcls_test_CT { - var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; f_lcls_init(); @@ -335,7 +335,7 @@ } private function f_tc_lcls_gcr_bway_connect(boolean hr, boolean bts_mode := false) runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; @@ -393,7 +393,7 @@ /* Unless explicitly enabled, osmo-bsc will avoid LCLSs when the codecs or rates * of both legs are different */ testcase TC_lcls_gcr_bway_codec_mismatch() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; var MgcpCommand mgcp_cmd; @@ -428,7 +428,7 @@ /* Send an ASSIGNMENT REQ with LCLS CFG+CSC enabling LCLS but GCR doesn't match! */ testcase TC_lcls_gcr_nomatch_bway_connect() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; var MgcpCommand mgcp_cmd; @@ -462,7 +462,7 @@ /* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect no connect */ testcase TC_lcls_gcr_bway_dont_connect() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; @@ -487,7 +487,7 @@ /* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect no connect */ testcase TC_lcls_gcr_unsuppported_cfg() runs on lcls_test_CT { - var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; f_lcls_init(); @@ -508,7 +508,7 @@ /* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect no connect */ testcase TC_lcls_gcr_unsuppported_csc() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; @@ -568,7 +568,7 @@ /* Send an ASSIGNMENT REQ with "do not connect" and enable later using LCLS CTRL */ testcase TC_lcls_gcr_bway_dont_connect_csc() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; var MgcpCommand mgcp_cmd; @@ -620,7 +620,7 @@ } private function f_lcls_connect_break(boolean bts_mode := false) runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; @@ -676,7 +676,7 @@ /* Establish LCLS "connect" followed by a SCCP-level release of one leg */ testcase TC_lcls_connect_clear() runs on lcls_test_CT { - var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars); + var TestHdlrParams pars_a := f_gen_test_hdlr_pars(); var TestHdlrParams pars_b; var MSC_ConnHdlr vc_conn; var MgcpCommand mgcp_cmd; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69ab8699b0be80b12e2df590d9170a743a00d035 Gerrit-Change-Number: 30893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-upf[master]: tunend: choose local GTP addr by Network Instance IEs

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30831 ) Change subject: tunend: choose local GTP addr by Network Instance IEs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I376c09bfc1844df1e61d2efac17561fac614858b Gerrit-Change-Number: 30831 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Jan 2023 13:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023