January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-sgsn[master]: Move gtphub header to include/osmocom/gtphub/

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30899 ) Change subject: Move gtphub header to include/osmocom/gtphub/ ...................................................................... Move gtphub header to include/osmocom/gtphub/ Change-Id: I82e1f2a3bc8e22b28747a540879bd661f1704cde --- M configure.ac M debian/copyright M include/osmocom/Makefile.am A include/osmocom/gtphub/Makefile.am R include/osmocom/gtphub/gtphub.h M include/osmocom/sgsn/Makefile.am M src/gtphub/gtphub.c M src/gtphub/gtphub_ares.c M src/gtphub/gtphub_main.c M src/gtphub/gtphub_sock.c M src/gtphub/gtphub_vty.c M tests/gtphub/gtphub_test.c 12 files changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/30899/1 diff --git a/configure.ac b/configure.ac index 64b74e3..2c335d7 100644 --- a/configure.ac +++ b/configure.ac @@ -235,6 +235,7 @@ AC_OUTPUT( include/Makefile include/osmocom/Makefile + include/osmocom/gtphub/Makefile include/osmocom/sgsn/Makefile src/Makefile src/gprs/Makefile diff --git a/debian/copyright b/debian/copyright index d4e7451..cd8d7e8 100644 --- a/debian/copyright +++ b/debian/copyright @@ -74,7 +74,7 @@ include/osmocom/sgsn/gprs_sndcp_pcomp.h include/osmocom/sgsn/gprs_sndcp_xid.h include/osmocom/sgsn/gprs_utils.h - include/osmocom/sgsn/gtphub.h + include/osmocom/gtphub/gtphub.h include/osmocom/sgsn/signal.h src/gprs/gprs_llc_parse.c src/gprs/crc24.c diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am index 09db97a..f5bc76a 100644 --- a/include/osmocom/Makefile.am +++ b/include/osmocom/Makefile.am @@ -1,3 +1,4 @@ SUBDIRS = \ + gtphub \ sgsn \ $(NULL) diff --git a/include/osmocom/gtphub/Makefile.am b/include/osmocom/gtphub/Makefile.am new file mode 100644 index 0000000..c61dad9 --- /dev/null +++ b/include/osmocom/gtphub/Makefile.am @@ -0,0 +1,3 @@ +noinst_HEADERS = \ + gtphub.h \ + $(NULL) diff --git a/include/osmocom/sgsn/gtphub.h b/include/osmocom/gtphub/gtphub.h similarity index 100% rename from include/osmocom/sgsn/gtphub.h rename to include/osmocom/gtphub/gtphub.h diff --git a/include/osmocom/sgsn/Makefile.am b/include/osmocom/sgsn/Makefile.am index a3bc218..017954d 100644 --- a/include/osmocom/sgsn/Makefile.am +++ b/include/osmocom/sgsn/Makefile.am @@ -23,7 +23,6 @@ gprs_subscriber.h \ gprs_utils.h \ gtp.h \ - gtphub.h \ gtp_ggsn.h \ gtp_mme.h \ pdpctx.h \ diff --git a/src/gtphub/gtphub.c b/src/gtphub/gtphub.c index 89ca676..2b00f59 100644 --- a/src/gtphub/gtphub.c +++ b/src/gtphub/gtphub.c @@ -32,7 +32,7 @@ #include <gtp.h> #include <gtpie.h> -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> #include <osmocom/sgsn/debug.h> #include <osmocom/sgsn/gprs_utils.h> diff --git a/src/gtphub/gtphub_ares.c b/src/gtphub/gtphub_ares.c index 87dc860..a2d8a4a 100644 --- a/src/gtphub/gtphub_ares.c +++ b/src/gtphub/gtphub_ares.c @@ -28,7 +28,7 @@ #include <string.h> #include <unistd.h> -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> #include <osmocom/sgsn/debug.h> #include <osmocom/core/utils.h> diff --git a/src/gtphub/gtphub_main.c b/src/gtphub/gtphub_main.c index a9a7529..0f389ab 100644 --- a/src/gtphub/gtphub_main.c +++ b/src/gtphub/gtphub_main.c @@ -41,7 +41,7 @@ #include <osmocom/vty/misc.h> #include <osmocom/sgsn/debug.h> -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> #include <osmocom/sgsn/vty.h> #include "../../bscconfig.h" diff --git a/src/gtphub/gtphub_sock.c b/src/gtphub/gtphub_sock.c index 1837533..59a0d42 100644 --- a/src/gtphub/gtphub_sock.c +++ b/src/gtphub/gtphub_sock.c @@ -25,7 +25,7 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> #include <osmocom/sgsn/debug.h> /* Convenience makro, note: only within this C file. */ diff --git a/src/gtphub/gtphub_vty.c b/src/gtphub/gtphub_vty.c index abc08fd..b5f102a 100644 --- a/src/gtphub/gtphub_vty.c +++ b/src/gtphub/gtphub_vty.c @@ -31,7 +31,7 @@ #include <osmocom/vty/misc.h> #include <osmocom/sgsn/vty.h> -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> /* TODO split GRX ares from sgsn into a separate struct and allow use without * globals. */ diff --git a/tests/gtphub/gtphub_test.c b/tests/gtphub/gtphub_test.c index 13d2636..4f58315 100644 --- a/tests/gtphub/gtphub_test.c +++ b/tests/gtphub/gtphub_test.c @@ -30,7 +30,7 @@ #include <osmocom/sgsn/debug.h> -#include <osmocom/sgsn/gtphub.h> +#include <osmocom/gtphub/gtphub.h> #include <gtp.h> #include <gtpie.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I82e1f2a3bc8e22b28747a540879bd661f1704cde Gerrit-Change-Number: 30899 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: fix unusual argument order: *ms always first

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30898 ) Change subject: modem: fix unusual argument order: *ms always first ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9fabe39575f191ce6c893a1fecaa7ac040ef0e3e Gerrit-Change-Number: 30898 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:57:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: do not depend on $(top_srcdir)/src/misc/rslms.c

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30897 ) Change subject: modem: do not depend on $(top_srcdir)/src/misc/rslms.c ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: why not depending on it? we simply don't need it? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic4d7e1956530aa10ff3125d6d857efe47ea37d38 Gerrit-Change-Number: 30897 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:57:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-upf-test: fetch /tmp/commit from gerrit, not from cgit

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30895 ) Change subject: ttcn3-upf-test: fetch /tmp/commit from gerrit, not from cgit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id327720258a9ece1efb79db0d7c4fcbe19864c92 Gerrit-Change-Number: 30895 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:55:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 ) Change subject: fix BSC_Tests_LCLS: do not use t_def_TestHdlrPars directly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69ab8699b0be80b12e2df590d9170a743a00d035 Gerrit-Change-Number: 30893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:55:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-upf[master]: tunend: choose local GTP addr by Network Instance IEs

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30831 ) Change subject: tunend: choose local GTP addr by Network Instance IEs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I376c09bfc1844df1e61d2efac17561fac614858b Gerrit-Change-Number: 30831 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:54:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-upf[master]: manual: add charts explaining tunend and tunmap

by pespin

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30835 ) Change subject: manual: add charts explaining tunend and tunmap ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia0674c97eb0d8b5caeae988aefe523c5eee7318b Gerrit-Change-Number: 30835 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Jan 2023 09:53:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: fix unusual argument order: *ms always first

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30898 to look at the new patch set (#2). Change subject: modem: fix unusual argument order: *ms always first ...................................................................... modem: fix unusual argument order: *ms always first Change-Id: I9fabe39575f191ce6c893a1fecaa7ac040ef0e3e Related: SYS#5500 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/30898/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9fabe39575f191ce6c893a1fecaa7ac040ef0e3e Gerrit-Change-Number: 30898 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: do not depend on $(top_srcdir)/src/misc/rslms.c

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30897 to look at the new patch set (#2). Change subject: modem: do not depend on $(top_srcdir)/src/misc/rslms.c ...................................................................... modem: do not depend on $(top_srcdir)/src/misc/rslms.c Change-Id: Ic4d7e1956530aa10ff3125d6d857efe47ea37d38 Related: SYS#5500 --- M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/app_modem.c 2 files changed, 71 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/30897/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic4d7e1956530aa10ff3125d6d857efe47ea37d38 Gerrit-Change-Number: 30897 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: fix unusual argument order: *ms always first

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30898 ) Change subject: modem: fix unusual argument order: *ms always first ...................................................................... modem: fix unusual argument order: *ms always first Change-Id: I9fabe39575f191ce6c893a1fecaa7ac040ef0e3e Related: SYS#5500 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/30898/1 diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index fbc7527..d0654fe 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -141,7 +141,7 @@ return 0; } -int gsm48_rx_bcch(struct msgb *msg, struct osmocom_ms *ms) +int gsm48_rx_bcch(struct osmocom_ms *ms, struct msgb *msg) { const struct gsm48_system_information_type_header *si_hdr = msgb_l3(msg); const uint8_t si_type = si_hdr->system_information; @@ -163,7 +163,7 @@ }; } -static int gsm48_rx_imm_ass(struct msgb *msg, struct osmocom_ms *ms) +static int gsm48_rx_imm_ass(struct osmocom_ms *ms, struct msgb *msg) { const struct gsm48_imm_ass *ia = msgb_l3(msg); uint8_t ch_type, ch_subch, ch_ts; @@ -241,7 +241,7 @@ return false; } -int gsm48_rx_ccch(struct msgb *msg, struct osmocom_ms *ms) +int gsm48_rx_ccch(struct osmocom_ms *ms, struct msgb *msg) { const struct gsm48_system_information_type_header *sih = msgb_l3(msg); @@ -263,7 +263,7 @@ switch (sih->system_information) { case GSM48_MT_RR_IMM_ASS: - return gsm48_rx_imm_ass(msg, ms); + return gsm48_rx_imm_ass(ms, msg); default: return 0; } @@ -291,9 +291,9 @@ switch (rllh->chan_nr) { case RSL_CHAN_PCH_AGCH: - return gsm48_rx_ccch(msg, ms); + return gsm48_rx_ccch(ms, msg); case RSL_CHAN_BCCH: - return gsm48_rx_bcch(msg, ms); + return gsm48_rx_bcch(ms, msg); default: return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9fabe39575f191ce6c893a1fecaa7ac040ef0e3e Gerrit-Change-Number: 30898 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023