January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: install-coverity: add missing tag coverity

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30916 ) Change subject: install-coverity: add missing tag coverity ...................................................................... install-coverity: add missing tag coverity Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/16/30916/1 diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 4047fb8..6192c27 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -3,6 +3,7 @@ apt: name: - curl + tags: [coverity] - name: copy coverity installer copy: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e Gerrit-Change-Number: 30916 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: install-coverity: ensure it's not installed twice

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30917 ) Change subject: install-coverity: ensure it's not installed twice ...................................................................... install-coverity: ensure it's not installed twice Check if the coverity path already exists. Even this wouldn't detect if the coverity has been only installed half way. Change-Id: I95549983bb6bd47e04eb37c73afe5409637f87d3 --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 35 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/30917/1 diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 6192c27..246fa36 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -5,39 +5,44 @@ - curl tags: [coverity] -- name: copy coverity installer - copy: - src: "{{ coverity_installer_file }}" - dest: "/tmp/{{ coverity_installer_file }}" - mode: 0750 - register: coverity_copy - ignore_errors: yes +- name: check if coverity needs to be installed + stat: + path: "/opt/coverity/{{ coverity_version }}/" + register: coverity_stat tags: [coverity] -- name: create /opt/coverity/{{ coverity_version }}/ - file: - path: /opt/coverity/{{ coverity_version }}/ - state: directory - when: coverity_copy.failed == False +- name: install coverity if required + when: coverity_stat.stat.exists == False tags: [coverity] + block: + - name: copy coverity installer + copy: + src: "{{ coverity_installer_file }}" + dest: "/tmp/{{ coverity_installer_file }}" + mode: 0750 + register: coverity_copy + ignore_errors: yes -- name: unpack coverity - unarchive: - src: "/tmp/{{ coverity_installer_file }}" - dest: /opt/coverity/{{ coverity_version }} - remote_src: yes - when: coverity_copy.failed == False - tags: [coverity] + - name: create /opt/coverity/{{ coverity_version }}/ + file: + path: /opt/coverity/{{ coverity_version }}/ + state: directory + when: coverity_copy.failed == False -- name: create link /opt/coverity/current - shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current - args: - warn: false - when: coverity_copy.failed == False - tags: [coverity] + - name: unpack coverity + unarchive: + src: "/tmp/{{ coverity_installer_file }}" + dest: /opt/coverity/{{ coverity_version }} + remote_src: yes + when: coverity_copy.failed == False -- name: "Please download {{ coverity_installer_file }} to your ansible directory to allow ansible to install coverity" - debug: - msg: "Ansible can not find {{ coverity_installer_file }}" - when: coverity_copy.failed - tags: [coverity] + - name: create link /opt/coverity/current + shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current + args: + warn: false + when: coverity_copy.failed == False + + - name: "Please download {{ coverity_installer_file }} to your ansible directory to allow ansible to install coverity" + debug: + msg: "Ansible can not find {{ coverity_installer_file }}" + when: coverity_copy.failed -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95549983bb6bd47e04eb37c73afe5409637f87d3 Gerrit-Change-Number: 30917 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: hosts: replace invalid char minus ("-") in host group names

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30918 ) Change subject: hosts: replace invalid char minus ("-") in host group names ...................................................................... hosts: replace invalid char minus ("-") in host group names Change-Id: I0c13ce4edb7f57c7ff77141b5511080bba639ec0 --- M ansible/README.md M ansible/hosts M ansible/setup-gsm-tester.yml M ansible/setup-jenkins-slave.yml M ansible/setup-obs-worker.yml 5 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/30918/1 diff --git a/ansible/README.md b/ansible/README.md index e5d146c..9085c74 100644 --- a/ansible/README.md +++ b/ansible/README.md @@ -33,4 +33,4 @@ # how to make slaves log-in to registry.osmocom.org: -`ansible jenkins-slaves -u root -a "su - osmocom-build -c 'docker login -u jenkins-slave -p PASSWD https://registry.osmocom.org/'"` +`ansible jenkins_slaves -u root -a "su - osmocom-build -c 'docker login -u jenkins_slave -p PASSWD https://registry.osmocom.org/'"` diff --git a/ansible/hosts b/ansible/hosts index 0551d44..b62ef82 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -1,12 +1,12 @@ -[gsm-tester] +[gsm_tester] osmo-gsm-tester-rnd ansible_host=10.9.25.101 osmo-gsm-tester-prod ansible_host=10.9.25.107 -[coverity-slaves] +[coverity_slaves] build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 -[jenkins-slaves] +[jenkins_slaves] build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 osmocom_jenkins_slave_fstrim=True @@ -20,7 +20,7 @@ [simtester] simtest ansible_host=10.9.25.80 -[obs-workers] +[obs_workers] build3-obsworker1 ansible_host=2a01:4f8:212:3762::1:2 obs_worker_instances=8 obs_worker_jobs=8 lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4 diff --git a/ansible/setup-gsm-tester.yml b/ansible/setup-gsm-tester.yml index 9d27256..526b621 100644 --- a/ansible/setup-gsm-tester.yml +++ b/ansible/setup-gsm-tester.yml @@ -1,6 +1,6 @@ --- - name: setup osmo-gsm-tester apu - hosts: gsm-tester + hosts: gsm_tester user: root tasks: - name: install common utilities diff --git a/ansible/setup-jenkins-slave.yml b/ansible/setup-jenkins-slave.yml index 7eac8b7..5813b40 100644 --- a/ansible/setup-jenkins-slave.yml +++ b/ansible/setup-jenkins-slave.yml @@ -1,6 +1,6 @@ --- - name: setup jenkins slaves - hosts: jenkins-slaves + hosts: jenkins_slaves user: root vars_files: - "vars/{{ ansible_facts['os_family'] }}-{{ ansible_facts['distribution_major_version']}}.yml" @@ -47,7 +47,7 @@ - name: ntpd - name: setup coverity slaves - hosts: coverity-slaves + hosts: coverity_slaves user: root roles: - name: install-coverity diff --git a/ansible/setup-obs-worker.yml b/ansible/setup-obs-worker.yml index c742a19..b79e1a5 100644 --- a/ansible/setup-obs-worker.yml +++ b/ansible/setup-obs-worker.yml @@ -1,6 +1,6 @@ --- - name: setup OBS worker - hosts: obs-workers + hosts: obs_workers user: root vars_files: - "vars/{{ ansible_facts['os_family'] }}-{{ ansible_facts['distribution_major_version']}}.yml" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0c13ce4edb7f57c7ff77141b5511080bba639ec0 Gerrit-Change-Number: 30918 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: add ssh configuration

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30919 ) Change subject: ansible: add ssh configuration ...................................................................... ansible: add ssh configuration Change-Id: Idbc7a51c20125182b1e484ae516e8d72239c1e00 --- M ansible/ansible.cfg A ansible/util/ssh_config 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/30919/1 diff --git a/ansible/ansible.cfg b/ansible/ansible.cfg index 11169e6..6c361a3 100644 --- a/ansible/ansible.cfg +++ b/ansible/ansible.cfg @@ -1,2 +1,8 @@ [defaults] stdout_callback=debug + +remote_user = root + +[ssh_connection] +ssh_args = -F util/ssh_config -o ControlMaster=auto -o ControlPersist=60s -o StrictHostKeyChecking=accept-new + diff --git a/ansible/util/ssh_config b/ansible/util/ssh_config new file mode 100644 index 0000000..9738e83 --- /dev/null +++ b/ansible/util/ssh_config @@ -0,0 +1,3 @@ + UserKnownHostsFile=util/known_hosts + HashKnownHosts=no + -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idbc7a51c20125182b1e484ae516e8d72239c1e00 Gerrit-Change-Number: 30919 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: install-poky-sdk: add tag poky to the apt install task

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30915 ) Change subject: install-poky-sdk: add tag poky to the apt install task ...................................................................... install-poky-sdk: add tag poky to the apt install task Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/30915/1 diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml index 7c1e9a9..57d0137 100644 --- a/ansible/roles/install-poky-sdk/tasks/main.yml +++ b/ansible/roles/install-poky-sdk/tasks/main.yml @@ -8,6 +8,7 @@ - tar cache_valid_time: 3600 update_cache: yes + tags: [poky] - name: check if poky needs to be installed stat: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a Gerrit-Change-Number: 30915 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: install-poky-sdk: ensure it's not installed twice

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30913 ) Change subject: install-poky-sdk: ensure it's not installed twice ...................................................................... install-poky-sdk: ensure it's not installed twice Check if the poky path already exists. Even this wouldn't detect if the poky has been only installed half way. Change-Id: I8f795be1e595268abe279b4d15d0b0c162ee22e1 Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 37 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/13/30913/1 diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml index 4b41bd2..7c1e9a9 100644 --- a/ansible/roles/install-poky-sdk/tasks/main.yml +++ b/ansible/roles/install-poky-sdk/tasks/main.yml @@ -9,40 +9,45 @@ cache_valid_time: 3600 update_cache: yes -- name: copy poky installer - copy: - src: "{{ poky_installer_file }}" - dest: "/tmp/{{ poky_installer_file }}" - mode: 0750 - register: poky_copy - ignore_errors: yes - tags: [poky] - -- name: execute poky installer - command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'" - args: - creates: "{{ poky_dest }}" - when: poky_copy.failed == False - tags: [poky] - -- name: change owner/group to jenkins user - file: +- name: check if poky needs to be installed + stat: path: "{{ poky_dest }}" - owner: "{{ jenkins_user }}" - group: "{{ jenkins_user }}" - recurse: yes - when: poky_copy.failed == False + register: poky_stat tags: [poky] -- name: remove poky installer - file: - path: "/tmp/{{ poky_installer_file }}" - state: absent - when: poky_copy.failed == False +- name: install poky if required tags: [poky] + when: poky_stat.stat.exists == False + block: + - name: copy poky installer + copy: + src: "{{ poky_installer_file }}" + dest: "/tmp/{{ poky_installer_file }}" + mode: 0750 + register: poky_copy + ignore_errors: yes -- name: "Please download {{ poky_installer_file }} to your ansible directory to allow ansible to install poky" - debug: - msg: "Ansible can not find or copy {{ poky_installer_file }}" - when: poky_copy.failed == True - tags: [poky] + - name: execute poky installer + command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'" + args: + creates: "{{ poky_dest }}" + when: poky_copy.failed == False + + - name: change owner/group to jenkins user + file: + path: "{{ poky_dest }}" + owner: "{{ jenkins_user }}" + group: "{{ jenkins_user }}" + recurse: yes + when: poky_copy.failed == False + + - name: remove poky installer + file: + path: "/tmp/{{ poky_installer_file }}" + state: absent + when: poky_copy.failed == False + + - name: "Please download {{ poky_installer_file }} to your ansible directory to allow ansible to install poky" + debug: + msg: "Ansible can not find or copy {{ poky_installer_file }}" + when: poky_copy.failed == True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 Gerrit-Change-Number: 30913 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: .gitignore: make poky regex more specific

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30914 ) Change subject: .gitignore: make poky regex more specific ...................................................................... .gitignore: make poky regex more specific Otherwise it would also prevent changes to the poky role Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 --- M ansible/.gitignore 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/14/30914/1 diff --git a/ansible/.gitignore b/ansible/.gitignore index 2fa603c..b23a1b1 100644 --- a/ansible/.gitignore +++ b/ansible/.gitignore @@ -1,4 +1,4 @@ -poky-* +poky-*toolchain* cov-analysis-*.tar.gz *.retry *.swo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 Gerrit-Change-Number: 30914 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: replace deprecated include by import_tasks

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30912 ) Change subject: ansible: replace deprecated include by import_tasks ...................................................................... ansible: replace deprecated include by import_tasks include_tasks and import_tasks have similar functionality. Use import_tasks when importing non-variable depending files. Further use import_tasks when not used within a loop. Closes: OS#5797 Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 --- M ansible/roles/docker/tasks/main.yml M ansible/roles/osmocom-workstation/tasks/main.yml 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/30912/1 diff --git a/ansible/roles/docker/tasks/main.yml b/ansible/roles/docker/tasks/main.yml index aa0fe4b..f64ae96 100644 --- a/ansible/roles/docker/tasks/main.yml +++ b/ansible/roles/docker/tasks/main.yml @@ -57,4 +57,4 @@ shell: "docker info | grep -q 'Storage Driver: overlay2' || rm -rf /var/lib/docker/vfs" # After docker is set up, add docuum to clean old docker images -- include: docuum.yml +- import_tasks: docuum.yml diff --git a/ansible/roles/osmocom-workstation/tasks/main.yml b/ansible/roles/osmocom-workstation/tasks/main.yml index ae29111..0331207 100644 --- a/ansible/roles/osmocom-workstation/tasks/main.yml +++ b/ansible/roles/osmocom-workstation/tasks/main.yml @@ -9,8 +9,8 @@ shell: /usr/bin/zsh groups: docker -- name: include git repos - include: git-repos.yml +- name: import git repos + import_tasks: git-repos.yml - name: install distribution packages apt: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 Gerrit-Change-Number: 30912 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Deprecate APIs telnet_init(_dynip)()

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Deprecate APIs telnet_init(_dynip)() ...................................................................... libosmocore: Deprecate APIs telnet_init(_dynip)() Related: OS#5809 Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 --- M include/osmocom/vty/telnet_interface.h M src/vty/telnet_interface.c 2 files changed, 34 insertions(+), 22 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/vty/telnet_interface.h b/include/osmocom/vty/telnet_interface.h index a28df47..73b79df 100644 --- a/include/osmocom/vty/telnet_interface.h +++ b/include/osmocom/vty/telnet_interface.h @@ -18,6 +18,7 @@ #pragma once +#include <osmocom/core/defs.h> #include <osmocom/core/logging.h> #include <osmocom/core/select.h> @@ -41,10 +42,13 @@ struct log_target *dbg; }; -int telnet_init(void *tall_ctx, void *priv, int port); -int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port); int telnet_init_default(void *tall_ctx, void *priv, int default_port); +int telnet_init(void *tall_ctx, void *priv, int port) + OSMO_DEPRECATED("This function ignores dynamic port configuration. Use telnet_init_default() instead"); +int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) + OSMO_DEPRECATED("This function ignores dynamic port configuration. Use telnet_init_default() instead"); + void telnet_exit(void); /*! @} */ diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index 3fcae6e..8fa5dbf 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -42,7 +42,7 @@ * process in order to enable interactive command-line introspection, * interaction and configuration. * - * You typically call \ref telnet_init or \ref telnet_init_dynif once + * You typically call telnet_init_default once * from your application code to enable this. */ @@ -60,23 +60,8 @@ .priv_nr = 0, }; -/*! Initialize telnet based VTY interface listening to 127.0.0.1 - * \param[in] tall_ctx \ref talloc context - * \param[in] priv private data to be passed to callback - * \param[in] port TCP port number to bind to - */ -int telnet_init(void *tall_ctx, void *priv, int port) -{ - return telnet_init_dynif(tall_ctx, priv, "127.0.0.1", port); -} - -/*! Initialize telnet based VTY interface - * \param[in] tall_ctx \ref talloc context - * \param[in] priv private data to be passed to callback - * \param[in] ip IP to listen to ('::1' for localhost, '::0' for all, ...) - * \param[in] port TCP port number to bind to - */ -int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) +/* Helper for deprecating telnet_init_dynif(), which previously held this code */ +static int _telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) { int rc; @@ -104,6 +89,29 @@ return 0; } +/*! Initialize telnet based VTY interface listening to 127.0.0.1 + * \param[in] tall_ctx \ref talloc context + * \param[in] priv private data to be passed to callback + * \param[in] port TCP port number to bind to + * \deprecated use telnet_init_default() instead + */ +int telnet_init(void *tall_ctx, void *priv, int port) +{ + return _telnet_init_dynif(tall_ctx, priv, "127.0.0.1", port); +} + +/*! Initialize telnet based VTY interface + * \param[in] tall_ctx \ref talloc context + * \param[in] priv private data to be passed to callback + * \param[in] ip IP to listen to ('::1' for localhost, '::0' for all, ...) + * \param[in] port TCP port number to bind to + * \deprecated use telnet_init_default() instead + */ +int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) +{ + return _telnet_init_dynif(tall_ctx, priv, ip, port); +} + /*! Initializes telnet based VTY interface using the configured bind addr/port. * \param[in] tall_ctx \ref talloc context * \param[in] priv private data to be passed to callback @@ -111,8 +119,8 @@ */ int telnet_init_default(void *tall_ctx, void *priv, int default_port) { - return telnet_init_dynif(tall_ctx, priv, vty_get_bind_addr(), - vty_get_bind_port(default_port)); + return _telnet_init_dynif(tall_ctx, priv, vty_get_bind_addr(), + vty_get_bind_port(default_port)); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: radio interface: fix init

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30911 ) Change subject: radio interface: fix init ...................................................................... Patch Set 1: Verified+1 Code-Review+1 (1 comment) Patchset: PS1: I verified it fixed the issue I was seeing with multi-arfcn. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I74fc1586f8ae0832f4093ba8a44a1c70c78ec3d8 Gerrit-Change-Number: 30911 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Jan 2023 19:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023