Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30911 )
Change subject: radio interface: fix init
......................................................................
radio interface: fix init
5561f1129d0bed0ebd2a49fde07e8ee91e487fd6 introduced some changes,
but while RadioInterface lost its call to close() that was previously
used to improperly reset the buffers upon init() that call was
accidentally not removed for RadioInterfaceMulti and
RadioInterfaceResamp, so those reset previously initialized values to 0
during init(), which break osmo-trx for weird setups.
Change-Id: I74fc1586f8ae0832f4093ba8a44a1c70c78ec3d8
---
M Transceiver52M/radioInterfaceMulti.cpp
M Transceiver52M/radioInterfaceResamp.cpp
2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/30911/1
diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp
index eeb0c97..a7195b4 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -153,8 +153,6 @@
return false;
}
- close();
-
convertSendBuffer.resize(1);
convertRecvBuffer.resize(1);
diff --git a/Transceiver52M/radioInterfaceResamp.cpp b/Transceiver52M/radioInterfaceResamp.cpp
index 37167ae..869acd0 100644
--- a/Transceiver52M/radioInterfaceResamp.cpp
+++ b/Transceiver52M/radioInterfaceResamp.cpp
@@ -98,8 +98,6 @@
{
float cutoff = 1.0f;
- close();
-
switch (type) {
case RadioDevice::RESAMP_64M:
resamp_inrate = RESAMP_64M_INRATE;
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I74fc1586f8ae0832f4093ba8a44a1c70c78ec3d8
Gerrit-Change-Number: 30911
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30908
to look at the new patch set (#3).
Change subject: lapd_pcap: fix illegal VLA within struct
......................................................................
lapd_pcap: fix illegal VLA within struct
Another weird and unique gcc supported extension, clang complains:
CC input/lapd_pcap.lo
input/lapd_pcap.c:134:8: error: fields must have a constant size:
'variable length array in structure' extension will never be supported
char buf[msg->len];
^
The kernel has been VLA-free since 2018, let's try not to make it worse.
Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d
---
M src/input/lapd_pcap.c
1 file changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/08/30908/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d
Gerrit-Change-Number: 30908
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30908
to look at the new patch set (#2).
Change subject: lapd_pcap: fix illegal VLA within struct
......................................................................
lapd_pcap: fix illegal VLA within struct
Another weird and unique gcc supported extension, clang complains:
CC input/lapd_pcap.lo
input/lapd_pcap.c:134:8: error: fields must have a constant size:
'variable length array in structure' extension will never be supported
char buf[msg->len];
^
The kernel has been VLA-free since 2018, let's try not to make it worse.
Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d
---
M src/input/lapd_pcap.c
1 file changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/08/30908/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d
Gerrit-Change-Number: 30908
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30908 )
Change subject: lapd_pcap: fix illegal VLA within struct
......................................................................
Patch Set 1:
(1 comment)
File src/input/lapd_pcap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2521):
https://gerrit.osmocom.org/c/libosmo-abis/+/30908/comment/610af20b_b2778d28
PS1, Line 138: struct tmp_pkt* s = alloca(total_pkt_len);
"foo* bar" should be "foo *bar"
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d
Gerrit-Change-Number: 30908
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 09 Jan 2023 17:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment