September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: mgcp_conn: rename field s/rate_ctr_group/ctrg/g

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29457 ) Change subject: mgcp_conn: rename field s/rate_ctr_group/ctrg/g ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I745eddbf66e7d811bb73c8ae9bb54ea93073c71b Gerrit-Change-Number: 29457 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:14:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: Fix typo in ratectr description

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29456 ) Change subject: Fix typo in ratectr description ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2ac8581f13814f320767ba188ef7cf3286fa443d Gerrit-Change-Number: 29456 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Get rid of static NULL talloc context

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29458 ) Change subject: osmux: Get rid of static NULL talloc context ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If4980424cdb8e3dc26a23e9ee419c0a38912f38f Gerrit-Change-Number: 29458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:13:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Clean up helper macro osmux_chunk_length()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29455 ) Change subject: osmux: Clean up helper macro osmux_chunk_length() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I482d8c5be08610788c2ed98e3b87ae4184075e8d Gerrit-Change-Number: 29455 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:13:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Attach osmux to virtual trunk

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29454 ) Change subject: osmux: Attach osmux to virtual trunk ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I173266c4058d5db9479d773d7dec1304bc8f1f99 Gerrit-Change-Number: 29454 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: mgcp_conn.h: fix indentation whitespace

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29453 ) Change subject: cosmetic: mgcp_conn.h: fix indentation whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b12b589d1b0a8f95a8283aac8ba0ad22026b43f Gerrit-Change-Number: 29453 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Log sendto() error

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29452 ) Change subject: osmux: Log sendto() error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icd91b725ac6b5ef2b9307cc99d67d60efdfa32cb Gerrit-Change-Number: 29452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:12:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: osmux: Fix formatting of if-else brackets

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29461 ) Change subject: cosmetic: osmux: Fix formatting of if-else brackets ...................................................................... cosmetic: osmux: Fix formatting of if-else brackets Change-Id: I748d41cd110841ef121f70560e70c07de56aa9da --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/61/29461/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 5ba48e8..5647348 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -598,8 +598,9 @@ "no available Osmux CID to allocate!\n"); return -1; } - } else + } else { osmux_cid_pool_get(osmux_cid); + } conn->osmux.cid = (uint8_t) osmux_cid; conn->osmux.cid_allocated = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I748d41cd110841ef121f70560e70c07de56aa9da Gerrit-Change-Number: 29461 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Add connection and global rate counters

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29459 to look at the new patch set (#2). Change subject: osmux: Add connection and global rate counters ...................................................................... osmux: Add connection and global rate counters Change-Id: I200a4aa3908cac0ec729d980a66f3df7f55e4da7 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_vty.c 8 files changed, 112 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/59/29459/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I200a4aa3908cac0ec729d980a66f3df7f55e4da7 Gerrit-Change-Number: 29459 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: Use 'static const' instead of 'const static' everywhere

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29460 ) Change subject: Use 'static const' instead of 'const static' everywhere ...................................................................... Use 'static const' instead of 'const static' everywhere As requested by the linter on a new patch being submitted. Change-Id: I692624da6a1c7f59ac2989509f074cb52d089907 --- M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_ratectr.c 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/60/29460/1 diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 7ab6eca..d963a56 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -37,7 +37,7 @@ #include <osmocom/core/timer.h> #include <ctype.h> -const static struct rate_ctr_group_desc rate_ctr_group_desc = { +static const struct rate_ctr_group_desc rate_ctr_group_desc = { .group_name_prefix = "conn_rtp", .group_description = "rtp connection statistics", .class_id = 1, diff --git a/src/libosmo-mgcp/mgcp_ratectr.c b/src/libosmo-mgcp/mgcp_ratectr.c index 6030ce2..bc6aa3c 100644 --- a/src/libosmo-mgcp/mgcp_ratectr.c +++ b/src/libosmo-mgcp/mgcp_ratectr.c @@ -43,7 +43,7 @@ { "mgcp:err_rx_no_endpoint", "can't find MGCP endpoint, probably we've used all allocated endpoints." }, }; -const static struct rate_ctr_group_desc mgcp_general_ctr_group_desc = { +static const struct rate_ctr_group_desc mgcp_general_ctr_group_desc = { .group_name_prefix = "mgcp", .group_description = "mgcp general statistics", .class_id = OSMO_STATS_CLASS_GLOBAL, @@ -71,7 +71,7 @@ [MGCP_CRCX_FAIL_CLAIM] = { "crcx:claim", "endpoint can not be claimed." }, }; -const static struct rate_ctr_group_desc mgcp_crcx_ctr_group_desc = { +static const struct rate_ctr_group_desc mgcp_crcx_ctr_group_desc = { .group_name_prefix = "crcx", .group_description = "crxc statistics", .class_id = OSMO_STATS_CLASS_GLOBAL, @@ -97,7 +97,7 @@ [MGCP_MDCX_FAIL_AVAIL] = { "mdcx:unavailable", "endpoint unavailable." }, }; -const static struct rate_ctr_group_desc mgcp_mdcx_ctr_group_desc = { +static const struct rate_ctr_group_desc mgcp_mdcx_ctr_group_desc = { .group_name_prefix = "mdcx", .group_description = "mdcx statistics", .class_id = OSMO_STATS_CLASS_GLOBAL, @@ -116,7 +116,7 @@ [MGCP_DLCX_FAIL_AVAIL] = { "dlcx:unavailable", "endpoint unavailable." }, }; -const static struct rate_ctr_group_desc mgcp_dlcx_ctr_group_desc = { +static const struct rate_ctr_group_desc mgcp_dlcx_ctr_group_desc = { .group_name_prefix = "dlcx", .group_description = "dlcx statistics", .class_id = OSMO_STATS_CLASS_GLOBAL, @@ -130,7 +130,7 @@ [E1_I460_TRAU_MUX_EMPTY_CTR] = { "e1:i460", "Outbound I.460 MUX queue empty." } }; -const static struct rate_ctr_group_desc e1_rate_ctr_group_desc = { +static const struct rate_ctr_group_desc e1_rate_ctr_group_desc = { .group_name_prefix = "e1", .group_description = "e1 statistics", .class_id = OSMO_STATS_CLASS_GLOBAL, @@ -138,7 +138,7 @@ .ctr_desc = e1_rate_ctr_desc }; -const static struct rate_ctr_group_desc all_rtp_conn_rate_ctr_group_desc = { +static const struct rate_ctr_group_desc all_rtp_conn_rate_ctr_group_desc = { .group_name_prefix = "all_rtp_conn", .group_description = "aggregated statistics for all rtp connections", .class_id = 1, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I692624da6a1c7f59ac2989509f074cb52d089907 Gerrit-Change-Number: 29460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022