September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: osmux: Clean up helper macro osmux_chunk_length()
by fixeria 23 Sep '22

23 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29455 ) Change subject: osmux: Clean up helper macro osmux_chunk_length() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I482d8c5be08610788c2ed98e3b87ae4184075e8d Gerrit-Change-Number: 29455 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 06:24:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Attach osmux to virtual trunk
by fixeria 23 Sep '22

23 Sep '22

Attention is currently required from: pespin, daniel, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29454 ) Change subject: osmux: Attach osmux to virtual trunk ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I173266c4058d5db9479d773d7dec1304bc8f1f99 Gerrit-Change-Number: 29454 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 06:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: hlr_vty.c: fix typo
by fixeria 23 Sep '22

23 Sep '22

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29406 ) Change subject: hlr_vty.c: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: If79ebd9a8998e64be55e52af43e426f37e3972af Gerrit-Change-Number: 29406 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 06:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-msc in Raspbian_11/armv7l
by OBS Notification 23 Sep '22

23 Sep '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 286s] [422/493] installing passwd-1:4.8.1-1 [ 287s] Shadow passwords are now on. [ 287s] [423/493] installing adduser-3.118 [ 288s] [424/493] installing libsctp-dev-1.0.18+dfsg-1 [ 288s] [425/493] installing libsqlite3-dev-3.34.1-3 [ 289s] [426/493] installing python3-3.9.2-3 [ 290s] [427/493] installing tipa-2:1.3-20.1 [ 292s] [428/493] installing libstdc++-10-dev-10.2.1-6+rpi1 [ 295s] [429/493] installing texlive-bibtex-extra-2020.20210202-3 [ 313s] [430/493] installing texlive-latex-recommended-2020.20210202-3 [ 318s] [431/493] installing libtool-2.4.6-15 [ 319s] [432/493] installing login-1:4.8.1-1 [ 322s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/login.deb' (size=648312) member 'control.tar': lzma error: compressed data is corrupt [ 322s] tar: Unexpected EOF in archive [ 322s] tar: Unexpected EOF in archive [ 322s] tar: Error is not recoverable: exiting now [ 322s] dpkg-deb: error: tar subprocess returned error exit status 2 [ 322s] dpkg: error processing archive .init_b_cache/login.deb (--install): [ 322s] dpkg-deb --control subprocess returned error exit status 2 [ 322s] Errors were encountered while processing: [ 322s] .init_b_cache/login.deb [ 322s] exit ... [ 322s] ### VM INTERACTION START ### [ 323s] [ 289.363502] sysrq: SysRq : Power Off [ 323s] [ 289.364867] reboot: Power down [ 323s] ### VM INTERACTION END ### [ 323s] [ 323s] armbuild01 failed "build osmo-msc_1.9.0.18.be768a.202209230052.dsc" at Fri Sep 23 03:18:02 UTC 2022. [ 323s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-hlr[master]: hlr_vty.c: fix typo
by msuraev 23 Sep '22

23 Sep '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29406 ) Change subject: hlr_vty.c: fix typo ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: If79ebd9a8998e64be55e52af43e426f37e3972af Gerrit-Change-Number: 29406 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 23 Sep 2022 02:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: cosmetic: mgcp_conn.h: fix indentation whitespace
by pespin 23 Sep '22

23 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29453 ) Change subject: cosmetic: mgcp_conn.h: fix indentation whitespace ...................................................................... cosmetic: mgcp_conn.h: fix indentation whitespace Change-Id: I6b12b589d1b0a8f95a8283aac8ba0ad22026b43f --- M include/osmocom/mgcp/mgcp_conn.h 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp_conn.h b/include/osmocom/mgcp/mgcp_conn.h index a08c089..3eca2f8 100644 --- a/include/osmocom/mgcp/mgcp_conn.h +++ b/include/osmocom/mgcp/mgcp_conn.h @@ -145,12 +145,12 @@ enum { IN_STREAM_ERR_TSTMP_CTR, OUT_STREAM_ERR_TSTMP_CTR, - RTP_PACKETS_RX_CTR, - RTP_OCTETS_RX_CTR, - RTP_PACKETS_TX_CTR, - RTP_OCTETS_TX_CTR, - RTP_DROPPED_PACKETS_CTR, - RTP_NUM_CONNECTIONS, + RTP_PACKETS_RX_CTR, + RTP_OCTETS_RX_CTR, + RTP_PACKETS_TX_CTR, + RTP_OCTETS_TX_CTR, + RTP_DROPPED_PACKETS_CTR, + RTP_NUM_CONNECTIONS, }; /* RTP per-connection statistics. Instances of the corresponding rate counter group -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b12b589d1b0a8f95a8283aac8ba0ad22026b43f Gerrit-Change-Number: 29453 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-mgw[master]: osmux: Log sendto() error
by pespin 23 Sep '22

23 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29452 ) Change subject: osmux: Log sendto() error ...................................................................... osmux: Log sendto() error Change-Id: Icd91b725ac6b5ef2b9307cc99d67d60efdfa32cb --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 98f2639..f15f37c 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -48,6 +48,7 @@ { struct osmux_handle *handle = data; socklen_t dest_len; + int rc; switch (handle->rem_addr.u.sa.sa_family) { case AF_INET6: @@ -58,8 +59,14 @@ dest_len = sizeof(handle->rem_addr.u.sin); break; } - sendto(osmux_fd.fd, batch_msg->data, batch_msg->len, 0, - (struct sockaddr *)&handle->rem_addr.u.sa, dest_len); + rc = sendto(osmux_fd.fd, batch_msg->data, batch_msg->len, 0, + (struct sockaddr *)&handle->rem_addr.u.sa, dest_len); + if (rc < 0) { + char errbuf[129]; + strerror_r(errno, errbuf, sizeof(errbuf)); + LOGP(DOSMUX, LOGL_NOTICE, "osmux sendto(%s) failed: %s\n", + osmo_sockaddr_to_str(&handle->rem_addr), errbuf); + } msgb_free(batch_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icd91b725ac6b5ef2b9307cc99d67d60efdfa32cb Gerrit-Change-Number: 29452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-mgw[master]: cosmetic: osmux: Fix formatting of if-else brackets
by laforge 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29461 ) Change subject: cosmetic: osmux: Fix formatting of if-else brackets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I748d41cd110841ef121f70560e70c07de56aa9da Gerrit-Change-Number: 29461 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:23:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Add connection and global rate counters
by laforge 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29459 ) Change subject: osmux: Add connection and global rate counters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I200a4aa3908cac0ec729d980a66f3df7f55e4da7 Gerrit-Change-Number: 29459 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:23:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: Use 'static const' instead of 'const static' everywhere
by laforge 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29460 ) Change subject: Use 'static const' instead of 'const static' everywhere ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I692624da6a1c7f59ac2989509f074cb52d089907 Gerrit-Change-Number: 29460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 20:14:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log September 2022