September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: ipaccess-config: Exit program with error if OML link is dropped

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29375 ) Change subject: ipaccess-config: Exit program with error if OML link is dropped ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic96635f618f2efbe29ca6c59eedd1dc1f90c1a1d Gerrit-Change-Number: 29375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 18:43:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: use available API to set e1inp_line_ops

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29374 ) Change subject: ipaccess-config: use available API to set e1inp_line_ops ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0d248fc5d1481ad96f7af20a1a80144137c626a Gerrit-Change-Number: 29374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 18:42:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initialize RSL ts driver fd to proper value

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29373 ) Change subject: ipaccess-config: Initialize RSL ts driver fd to proper value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19eb23a46f89b96dd8d63742ca2078ecd5c9ab6b Gerrit-Change-Number: 29373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 18:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initiate missing IPA osmo_link

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29372 ) Change subject: ipaccess-config: Initiate missing IPA osmo_link ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65 Gerrit-Change-Number: 29372 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 18:40:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29364 ) Change subject: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ief46bad5075b656c13d1f09a0724e33283148236 Gerrit-Change-Number: 29364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 18:38:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess: Remove unused stub

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29377 ) Change subject: ipaccess: Remove unused stub ...................................................................... ipaccess: Remove unused stub function on_gsm_ts_init() doesn't exist at all in the repository, so it can be dropped from here. Change-Id: I863ccad044960d3ba267fa2bbf3c697abdf596a8 --- M src/ipaccess/stubs.c 1 file changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/29377/1 diff --git a/src/ipaccess/stubs.c b/src/ipaccess/stubs.c index aaec4c5..8549397 100644 --- a/src/ipaccess/stubs.c +++ b/src/ipaccess/stubs.c @@ -1,6 +1,6 @@ /* Stubs required for linking */ -/* (C) 2018 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> +/* (C) 2018-2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> * * All Rights Reserved * @@ -19,17 +19,7 @@ * */ -#include <stdbool.h> struct gsm_bts; -struct gsm_bts_trx_ts; -struct msgb; -struct bsc_msc_data; - -bool on_gsm_ts_init(struct gsm_bts_trx_ts *ts) -{ - /* No TS init required here. */ - return true; -} int gsm_bts_check_cfg(struct gsm_bts *bts) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I863ccad044960d3ba267fa2bbf3c697abdf596a8 Gerrit-Change-Number: 29377 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess: Fix writing pcap output to fd=0 (stdin)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29378 ) Change subject: ipaccess: Fix writing pcap output to fd=0 (stdin) ...................................................................... ipaccess: Fix writing pcap output to fd=0 (stdin) It ended up in seeing lots of garbage in my terminal every time I run the program. Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/29378/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index a22d311..3df9f61 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -141,6 +141,7 @@ return -EINVAL; } e1inp_line_bind_ops(line, &ipaccess_e1inp_line_ops); + e1_set_pcap_fd2(line, -1); /* Disable writing to pcap */ sign_ts = e1inp_line_ipa_oml_ts(line); rsl_ts = e1inp_line_ipa_rsl_ts(line, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df Gerrit-Change-Number: 29378 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: use available API to set e1inp_line_ops

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29374 ) Change subject: ipaccess-config: use available API to set e1inp_line_ops ...................................................................... ipaccess-config: use available API to set e1inp_line_ops Change-Id: Ic0d248fc5d1481ad96f7af20a1a80144137c626a --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/29374/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 4d5e8b1..d1fbed7 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -140,7 +140,7 @@ fprintf(stderr, "cannot `ipa' driver, giving up.\n"); return -EINVAL; } - line->ops = &ipaccess_e1inp_line_ops; + e1inp_line_bind_ops(line, &ipaccess_e1inp_line_ops); sign_ts = e1inp_line_ipa_oml_ts(line); rsl_ts = e1inp_line_ipa_rsl_ts(line, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0d248fc5d1481ad96f7af20a1a80144137c626a Gerrit-Change-Number: 29374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Exit program with error if OML link is dropped

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29375 ) Change subject: ipaccess-config: Exit program with error if OML link is dropped ...................................................................... ipaccess-config: Exit program with error if OML link is dropped Change-Id: Ic96635f618f2efbe29ca6c59eedd1dc1f90c1a1d --- M src/ipaccess/ipaccess-config.c 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/29375/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index d1fbed7..a22d311 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -403,6 +403,32 @@ return 0; } +/* Callback function to be called every time we receive a signal from INPUT */ +static int inp_sig_cb(unsigned int subsys, unsigned int signal, + void *handler_data, void *signal_data) +{ + struct input_signal_data *isd = signal_data; + + if (subsys != SS_L_INPUT) + return -EINVAL; + + fprintf(stderr, "%s(): Input signal '%s' received\n", __func__, + get_value_string(e1inp_signal_names, signal)); + + switch (signal) { + case S_L_INP_TEI_UP: + break; + case S_L_INP_TEI_DN: + fprintf(stderr, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); + exit(1); + break; + default: + break; + } + + return 0; +} + /* callback function passed to the ABIS OML code */ static int percent; static int percent_old; @@ -1168,6 +1194,7 @@ bts->oml_tei = stream_id; osmo_signal_register_handler(SS_NM, nm_sig_cb, NULL); + osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); osmo_signal_register_handler(SS_IPAC_NWL, nwl_sig_cb, NULL); ipac_nwl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic96635f618f2efbe29ca6c59eedd1dc1f90c1a1d Gerrit-Change-Number: 29375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipacces-config: override gsm_bts_check_cfg() to void checking unset b...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 ) Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ...................................................................... ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration the shared code in libbsc checks for sane config being set, but this doesn't really apply to ipaccess-config, wihich doesn't set such config fields internally. Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 --- M src/ipaccess/stubs.c M src/osmo-bsc/bts.c 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/29376/1 diff --git a/src/ipaccess/stubs.c b/src/ipaccess/stubs.c index 60fa626..aaec4c5 100644 --- a/src/ipaccess/stubs.c +++ b/src/ipaccess/stubs.c @@ -30,3 +30,9 @@ /* No TS init required here. */ return true; } + +int gsm_bts_check_cfg(struct gsm_bts *bts) +{ + /* No checks required here */ + return 0; +} diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 95e7430..b7d3c3c 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -461,7 +461,7 @@ } /* Validate BTS configuration (ARFCN settings and physical channel configuration) */ -int gsm_bts_check_cfg(struct gsm_bts *bts) +__attribute__((weak)) int gsm_bts_check_cfg(struct gsm_bts *bts) { struct gsm_bts_trx *trx; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 Gerrit-Change-Number: 29376 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022