September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: ipaccess-config: Initiate missing IPA osmo_link

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29372 ) Change subject: ipaccess-config: Initiate missing IPA osmo_link ...................................................................... ipaccess-config: Initiate missing IPA osmo_link Since this is created by osmo-bsc, it is also expected to be there by ipaccess_drop_oml() in the shared libbsc code. But ipaccess-config was not creating it, so let's do so. Let's explicitly assert this condition in the code path expecting the pointer to be instantiated in shared code, to easily track related issues in the future. Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65 --- M src/ipaccess/ipaccess-config.c M src/osmo-bsc/bts_ipaccess_nanobts.c 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/29372/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 7c8d486..a214d28 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -129,7 +129,7 @@ { struct e1inp_line *line; struct e1inp_ts *sign_ts, *rsl_ts; - struct e1inp_sign_link *oml_link, *rsl_link; + struct e1inp_sign_link *oml_link, *osmo_link, *rsl_link; line = talloc_zero(tall_bsc_ctx, struct e1inp_line); if (!line) @@ -152,11 +152,14 @@ /* create signalling links for TRX0 */ oml_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OML, bts->c0, IPAC_PROTO_OML, 0); + osmo_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OSMO, + bts->c0, IPAC_PROTO_OSMO, 0); rsl_link = e1inp_sign_link_create(rsl_ts, E1INP_SIGN_RSL, bts->c0, IPAC_PROTO_RSL, 0); /* create back-links from bts/trx */ bts->oml_link = oml_link; + bts->osmo_link = osmo_link; bts->c0->rsl_link_primary = rsl_link; /* default port at BTS for incoming connections is 3006 */ diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 3165944..c4df29e 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -616,6 +616,7 @@ gsm_bts_stats_reset(bts); /* Also drop the associated OSMO link */ + OSMO_ASSERT(bts->osmo_link); e1inp_sign_link_destroy(bts->osmo_link); bts->osmo_link = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65 Gerrit-Change-Number: 29372 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initialize RSL ts driver fd to proper value

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29373 ) Change subject: ipaccess-config: Initialize RSL ts driver fd to proper value ...................................................................... ipaccess-config: Initialize RSL ts driver fd to proper value ipaccess-config sets up the entire line in a fake way. That requires also setting the fd of each TS used to -1 in order to avoid library code interacting with it during tear down if an error occurs. Change-Id: I19eb23a46f89b96dd8d63742ca2078ecd5c9ab6b --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/29373/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index a214d28..4d5e8b1 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -148,6 +148,7 @@ /* create E1 timeslots for signalling and TRAU frames */ e1inp_ts_config_sign(sign_ts, line); e1inp_ts_config_sign(rsl_ts, line); + rsl_ts->driver.ipaccess.fd.fd = -1; /* create signalling links for TRX0 */ oml_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OML, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19eb23a46f89b96dd8d63742ca2078ecd5c9ab6b Gerrit-Change-Number: 29373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 to look at the new patch set (#2). Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... ipaccess_close(): No need to lookup already available struct e1i_ts Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/70/29370/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 ) Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... Patch Set 1: (1 comment) File src/input/ipaccess.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-abis-lint-36): https://gerrit.osmocom.org/c/libosmo-abis/+/29370/comment/bc0212e4_8002d650 PS1, Line 457: struct osmo_fsm_inst* ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 16 Sep 2022 17:24:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 ) Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... ipaccess_close(): No need to lookup already available struct e1i_ts Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/70/29370/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 9331d07..fd6eabc 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -453,14 +453,10 @@ struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; struct e1inp_line *line = e1i_ts->line; - /* line might not exist if != bsc||bts */ - if (line) { - /* depending on caller the fsm might be dead */ - struct osmo_fsm_inst* ka_fsm = ipaccess_line_ts(bfd, line)->driver.ipaccess.ka_fsm; - if (ka_fsm) - ipa_keepalive_fsm_stop(ka_fsm); - - } + /* depending on caller the fsm might be dead */ + struct osmo_fsm_inst* ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; + if (ka_fsm) + ipa_keepalive_fsm_stop(ka_fsm); e1inp_int_snd_event(e1i_ts, sign_link, S_L_INP_TEI_DN); /* the first e1inp_sign_link_destroy call closes the socket. */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess: Call line->ops->sign_link_down() only if set

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29371 ) Change subject: ipaccess: Call line->ops->sign_link_down() only if set ...................................................................... ipaccess: Call line->ops->sign_link_down() only if set This op must not necessarily be set by the user, so check if it is set before calling it. Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/71/29371/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index fd6eabc..0180e12 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -123,7 +123,8 @@ e1i_ts->pending_msg = NULL; /* e1inp_sign_link_destroy releases the socket descriptors for us. */ - line->ops->sign_link_down(line); + if (line->ops->sign_link_down) + line->ops->sign_link_down(line); e1inp_line_put2(line, __func__); return ret; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba Gerrit-Change-Number: 29371 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29369 ) Change subject: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds ...................................................................... e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 --- M include/osmocom/abis/e1_input.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/69/29369/1 diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 29cc942..60f372a 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -229,7 +229,7 @@ int pcap_fd; }; #define e1inp_line_ipa_oml_ts(line) (&line->ts[0]) -#define e1inp_line_ipa_rsl_ts(line, trx_id) (&line->ts[1 + (trx_id)]) +#define e1inp_line_ipa_rsl_ts(line, trx_id) (((1 + (trx_id)) < NUM_E1_TS) ? (&line->ts[1 + (trx_id)]) : NULL) /* SS_L_INPUT signals */ enum e1inp_signal_input { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 Gerrit-Change-Number: 29369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: oml: Integrate signal S_NM_IPACC_SET_ATTR_ACK inside S_NM_IPACC_ACK

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29363 ) Change subject: oml: Integrate signal S_NM_IPACC_SET_ATTR_ACK inside S_NM_IPACC_ACK ...................................................................... oml: Integrate signal S_NM_IPACC_SET_ATTR_ACK inside S_NM_IPACC_ACK It makes no sense to have duplicate signals. Let's simply clean up S_NM_IPACC_ACK and pass the required info for higher layers to do whatever is needed based on the information. This allows reusing same signal infrastructure for different types of messages instead of having to implement new signals for each message (which can be done at a higher point in the stack). Change-Id: I18ae3d320d00077fc13bb9903903de2a17767302 --- M include/osmocom/bsc/signal.h M src/ipaccess/ipaccess-config.c M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bts_ipaccess_nanobts.c 4 files changed, 53 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h index 300bd55..4d5080d 100644 --- a/include/osmocom/bsc/signal.h +++ b/include/osmocom/bsc/signal.h @@ -65,7 +65,6 @@ S_NM_NACK, /* GSM 12.21 various NM_MT_*_NACK happened */ S_NM_IPACC_NACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_NACK happened */ S_NM_IPACC_ACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_ACK happened */ - S_NM_IPACC_SET_ATTR_ACK,/* GSM 12.21 nanoBTS extensions NM_MT_IPACC_SET_ATTR_ACK happened */ S_NM_IPACC_RESTART_ACK, /* nanoBTS has send a restart ack */ S_NM_IPACC_RESTART_NACK,/* nanoBTS has send a restart ack */ S_NM_TEST_REP, /* GSM 12.21 Test Report */ @@ -121,8 +120,10 @@ }; struct ipacc_ack_signal_data { - struct gsm_bts_trx *trx; - uint8_t msg_type; + /* The BTS which sent the ACK/NACK to us: */ + struct gsm_bts *bts; + /* messge header containing msg_type, obj_class, obj_inst: */ + struct abis_om_fom_hdr *foh; }; struct abis_om2k_mo; diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 1d8675e..7c8d486 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -191,6 +191,9 @@ static int ipacc_msg_ack(uint8_t mt, struct gsm_bts_trx *trx) { + if (mt != NM_MT_IPACC_SET_NVATTR_ACK && mt != NM_MT_IPACC_SET_ATTR_ACK) + return 0; + if (sw_load_state == 1) { fprintf(stderr, "The new software is activated.\n"); check_restart_or_exit(trx); @@ -352,14 +355,23 @@ struct ipacc_ack_signal_data *ipacc_data; struct nm_statechg_signal_data *nsd; struct msgb *oml_msg; + struct gsm_bts_trx *trx; switch (signal) { case S_NM_IPACC_NACK: ipacc_data = signal_data; - return ipacc_msg_nack(ipacc_data->msg_type); + return ipacc_msg_nack(ipacc_data->foh->msg_type); case S_NM_IPACC_ACK: ipacc_data = signal_data; - return ipacc_msg_ack(ipacc_data->msg_type, ipacc_data->trx); + switch (ipacc_data->foh->obj_class) { + case NM_OC_BASEB_TRANSC: + case NM_OC_RADIO_CARRIER: + trx = gsm_bts_trx_num(ipacc_data->bts, + ipacc_data->foh->obj_inst.trx_nr); + return ipacc_msg_ack(ipacc_data->foh->msg_type, trx); + default: + return 0; + } case S_NM_IPACC_RESTART_ACK: if (!quiet) printf("The BTS has acked the restart. Exiting.\n"); diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 8eeba89..b151f36 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -2865,6 +2865,7 @@ struct tlv_parsed tp; struct ipacc_ack_signal_data signal; struct e1inp_sign_link *sign_link = msg->dst; + struct gsm_bts *bts = sign_link->trx->bts; struct gsm_bts_trx *trx; foh = (struct abis_om_fom_hdr *) (oh->data + 1 + idstrlen); @@ -2874,14 +2875,14 @@ return -EINVAL; } - if (abis_nm_tlv_parse(&tp, sign_link->trx->bts, foh->data, oh->length - sizeof(*foh)) < 0) { + if (abis_nm_tlv_parse(&tp, bts, foh->data, oh->length - sizeof(*foh)) < 0) { LOGPFOH(DNM, LOGL_ERROR, foh, "%s(): tlv_parse failed\n", __func__); return -EINVAL; } /* The message might be received over the main OML link, so we cannot * just use sign_link->trx. Resolve it by number from the FOM header. */ - trx = gsm_bts_trx_num(sign_link->trx->bts, foh->obj_inst.trx_nr); + trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr); DEBUGPFOH(DNM, foh, "Rx IPACCESS(0x%02x): %s\n", foh->msg_type, osmo_hexdump(foh->data, oh->length - sizeof(*foh))); @@ -2961,21 +2962,15 @@ case NM_MT_IPACC_RSL_CONNECT_NACK: case NM_MT_IPACC_SET_NVATTR_NACK: case NM_MT_IPACC_GET_NVATTR_NACK: - if (!trx) - goto obj_inst_error; - signal.trx = trx; - signal.msg_type = foh->msg_type; + signal.bts = bts; + signal.foh = foh; osmo_signal_dispatch(SS_NM, S_NM_IPACC_NACK, &signal); break; case NM_MT_IPACC_SET_NVATTR_ACK: - if (!trx) - goto obj_inst_error; - signal.trx = trx; - signal.msg_type = foh->msg_type; - osmo_signal_dispatch(SS_NM, S_NM_IPACC_ACK, &signal); - break; case NM_MT_IPACC_SET_ATTR_ACK: - osmo_signal_dispatch(SS_NM, S_NM_IPACC_SET_ATTR_ACK, msg); + signal.bts = bts; + signal.foh = foh; + osmo_signal_dispatch(SS_NM, S_NM_IPACC_ACK, &signal); break; default: break; @@ -3041,8 +3036,17 @@ LOG_TRX(trx, DRSL, LOGL_NOTICE, "RSL connection request timed out\n"); /* Fake an RSL CONNECT NACK message from the BTS. */ - signal.trx = trx; - signal.msg_type = NM_MT_IPACC_RSL_CONNECT_NACK; + struct abis_om_fom_hdr foh = { + .msg_type = NM_MT_IPACC_RSL_CONNECT_NACK, + .obj_class = NM_OC_BASEB_TRANSC, + .obj_inst = { + .bts_nr = trx->bts->bts_nr, + .trx_nr = trx->nr, + .ts_nr = 0xff, + }, + }; + signal.foh = &foh; + signal.bts = trx->bts; osmo_signal_dispatch(SS_NM, S_NM_IPACC_NACK, &signal); } diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 8a63e16..0af5a28 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -413,19 +413,15 @@ osmo_fsm_inst_dispatch(ts->mo.fi, NM_EV_SET_ATTR_ACK, NULL); } -static void nm_rx_ipacc_set_attr_ack(struct msgb *oml_msg) +static void nm_rx_ipacc_set_attr_ack(struct ipacc_ack_signal_data *sig_data) { - struct e1inp_sign_link *sign_link = oml_msg->dst; - struct gsm_bts *bts = sign_link->trx->bts; - struct abis_om_hdr *oh = msgb_l2(oml_msg); - uint8_t idstrlen = oh->data[0]; - struct abis_om_fom_hdr *foh; + struct gsm_bts *bts = sig_data->bts; + struct abis_om_fom_hdr *foh = sig_data->foh; void *obj; struct gsm_gprs_nse *nse; struct gsm_gprs_cell *cell; struct gsm_gprs_nsvc *nsvc; - foh = (struct abis_om_fom_hdr *) (oh->data + 1 + idstrlen); obj = gsm_objclass2obj(bts, foh->obj_class, &foh->obj_inst); switch (foh->obj_class) { @@ -447,6 +443,17 @@ } } +static void nm_rx_ipacc_ack(struct ipacc_ack_signal_data *sig_data) +{ + switch (sig_data->foh->msg_type) { + case NM_MT_IPACC_SET_ATTR_ACK: + nm_rx_ipacc_set_attr_ack(sig_data); + break; + default: + break; + } +} + /* Callback function to be called every time we receive a signal from NM */ static int bts_ipa_nm_sig_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) @@ -477,8 +484,8 @@ case S_NM_SET_CHAN_ATTR_ACK: nm_rx_set_chan_attr_ack(signal_data); return 0; - case S_NM_IPACC_SET_ATTR_ACK: - nm_rx_ipacc_set_attr_ack(signal_data); + case S_NM_IPACC_ACK: + nm_rx_ipacc_ack(signal_data); return 0; default: break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18ae3d320d00077fc13bb9903903de2a17767302 Gerrit-Change-Number: 29363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: oml: Integrate signal S_NM_IPACC_SET_ATTR_ACK inside S_NM_IPACC_ACK

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29363 ) Change subject: oml: Integrate signal S_NM_IPACC_SET_ATTR_ACK inside S_NM_IPACC_ACK ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18ae3d320d00077fc13bb9903903de2a17767302 Gerrit-Change-Number: 29363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 16:25:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in meta-telephony[201705]: git clones: git.osmocom.org -> gerrit.osmocom.org

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/29368 ) Change subject: git clones: git.osmocom.org -> gerrit.osmocom.org ...................................................................... Patch Set 1: (1 comment) File recipes-osmocom/libosmo-netif/libosmo-netif.inc: https://gerrit.osmocom.org/c/meta-telephony/+/29368/comment/991e4f53_8d74ab… PS1, Line 2: HOMEPAGE = "http://gerrit.osmocom.org" https? -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/29368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I2b9640b542ed68b3f5abf63e774e4f878232211a Gerrit-Change-Number: 29368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 15:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022