August 2022 - gerrit-log - lists.osmocom.org

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Tumbleweed/i586

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 30s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw(x86-32) = 1.3.0.17.9f65.202208210052-1.1 [ 30s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 30s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 30s] Requires(pre): /bin/sh systemd [ 30s] Requires(post): /bin/sh systemd [ 30s] Requires(preun): /bin/sh systemd [ 30s] Requires(postun): /bin/sh systemd [ 30s] Requires: libasn1c.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-hnbap.so.0 libosmo-mgcp-client.so.9 libosmo-ranap.so.5 libosmo-rua.so.0 libosmo-sigtran.so.7 libosmocore.so.19 libosmoctrl.so.0 libosmoctrl.so.0(LIBOSMOCTRL_1.0) libosmogsm.so.18 libosmogsm.so.18(LIBOSMOGSM_1.0) libosmonetif.so.8 libosmovty.so.9 libtalloc.so.2 libtalloc.so.2(TALLOC_2.0.2) [ 30s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208210052-1.1.i586 [ 30s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debugsource(x86-32) = 1.3.0.17.9f65.202208210052-1.1 [ 30s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 30s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208210052-1.1.i586 [ 30s] Provides: debuginfo(build-id) = 441ea42e19416c4c66586659da0a967690fa0158 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debuginfo(x86-32) = 1.3.0.17.9f65.202208210052-1.1 [ 30s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 30s] Recommends: osmo-hnbgw-debugsource(x86-32) = 1.3.0.17.9f65.202208210052-1.1 [ 30s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208210052-1.1.i386 [ 30s] error: Installed (but unpackaged) file(s) found: [ 30s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 30s] [ 30s] RPM build errors: [ 30s] Installed (but unpackaged) file(s) found: [ 30s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 30s] ### VM INTERACTION START ### [ 30s] [ 19.879133][ T1] sysrq: Power Off [ 30s] [ 19.880834][ T18] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] goat05 failed "build osmo-hnbgw.spec" at Sun Aug 21 18:20:14 UTC 2022. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/libosmo-pfcp in openSUSE_Tumbleweed/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmo-pfcp failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-pfcp Last lines of build log: [ 125s] libosmo-pfcp.src: E: no-changelogname-tag [ 125s] There is no changelog. Please insert a '%changelog' section heading in your [ 125s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 125s] [ 125s] libosmo-pfcp.src: W: name-repeated-in-summary libosmo-pfcp [ 125s] The name of the package is repeated in its summary. Make the summary brief and [ 125s] to the point without including redundant information in it. [ 125s] [ 125s] libosmo-gtlv-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-gtlv.a [ 125s] libosmo-pfcp-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-pfcp.a [ 125s] This archive does not contain a non-empty .text section. The archive was not [ 125s] created with -ffat-lto-objects option. [ 125s] [ 125s] ---------------- Badness 20227 exceeds threshold 999, aborting. ---------------- [ 125s] Check time report (>1% & >0.1s): [ 125s] Check Duration (in s) Fraction (in %) Checked files [ 125s] BinariesCheck 0.1 22.8 4 [ 125s] rpm2cpio 0.1 19.6 [ 125s] TOTAL 0.5 100.0 26 [ 125s] [ 125s] 5 packages and 0 specfiles checked; 11 errors, 3 warnings, 20227 badness; has taken 0.5 s [ 125s] [ 125s] ### VM INTERACTION START ### [ 125s] [ 107.987118][ T1] sysrq: Power Off [ 125s] [ 108.004969][ T18] reboot: Power down [ 125s] ### VM INTERACTION END ### [ 125s] [ 125s] lamb21 failed "build libosmo-pfcp.spec" at Sun Aug 21 18:20:16 UTC 2022. [ 125s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-upf in openSUSE_Tumbleweed/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-upf failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-upf Last lines of build log: [ 54s] checking whether to build static libraries... yes [ 54s] checking for pkg-config... /usr/bin/pkg-config [ 54s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 54s] checking pkg-config is at least version 0.20... yes [ 54s] checking for LIBOSMOCORE... yes [ 54s] checking for LIBOSMOVTY... yes [ 54s] checking for LIBOSMOCTRL... yes [ 54s] checking for LIBOSMOGTLV... no [ 54s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met: [ 54s] [ 54s] Package 'libosmo-gtlv', required by 'virtual:world', not found [ 54s] [ 54s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 54s] installed software in a non-standard prefix. [ 54s] [ 54s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS [ 54s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config. [ 54s] See the pkg-config man page for more details. [ 54s] error: Bad exit status from /var/tmp/rpm-tmp.Utdw5j (%build) [ 54s] [ 54s] RPM build errors: [ 54s] Bad exit status from /var/tmp/rpm-tmp.Utdw5j (%build) [ 54s] ### VM INTERACTION START ### [ 54s] [ 43.654264][ T1] sysrq: Power Off [ 54s] [ 43.714606][ T18] reboot: Power down [ 54s] ### VM INTERACTION END ### [ 54s] [ 54s] hurricane3 failed "build osmo-upf.spec" at Sun Aug 21 18:19:41 UTC 2022. [ 54s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/libosmo-pfcp in openSUSE_Tumbleweed/i586

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmo-pfcp failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-pfcp Last lines of build log: [ 90s] libosmo-pfcp0.i586: E: no-changelogname-tag [ 90s] libosmo-pfcp.src: E: no-changelogname-tag [ 90s] There is no changelog. Please insert a '%changelog' section heading in your [ 90s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 90s] [ 90s] libosmo-pfcp.src: W: name-repeated-in-summary libosmo-pfcp [ 90s] The name of the package is repeated in its summary. Make the summary brief and [ 90s] to the point without including redundant information in it. [ 90s] [ 90s] libosmo-gtlv-devel.i586: E: lto-no-text-in-archive (Badness: 10000) /usr/lib/libosmo-gtlv.a [ 90s] libosmo-pfcp-devel.i586: E: lto-no-text-in-archive (Badness: 10000) /usr/lib/libosmo-pfcp.a [ 90s] This archive does not contain a non-empty .text section. The archive was not [ 90s] created with -ffat-lto-objects option. [ 90s] [ 90s] ---------------- Badness 20227 exceeds threshold 999, aborting. ---------------- [ 90s] Check time report (>1% & >0.1s): [ 90s] Check Duration (in s) Fraction (in %) Checked files [ 90s] BinariesCheck 0.1 30.1 4 [ 90s] TOTAL 0.4 100.0 26 [ 90s] [ 90s] 5 packages and 0 specfiles checked; 11 errors, 3 warnings, 20227 badness; has taken 0.4 s [ 90s] [ 90s] ### VM INTERACTION START ### [ 90s] [ 80.363915][ T1] sysrq: Power Off [ 90s] [ 80.367702][ T18] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] lamb59 failed "build libosmo-pfcp.spec" at Sun Aug 21 18:02:12 UTC 2022. [ 90s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-upf in openSUSE_Tumbleweed/i586

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-upf failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-upf Last lines of build log: [ 29s] checking whether to build static libraries... yes [ 29s] checking for pkg-config... /usr/bin/pkg-config [ 29s] checking for i586-suse-linux-gnu-pkg-config... /usr/bin/i586-suse-linux-gnu-pkg-config [ 29s] checking pkg-config is at least version 0.20... yes [ 29s] checking for LIBOSMOCORE... yes [ 29s] checking for LIBOSMOVTY... yes [ 29s] checking for LIBOSMOCTRL... yes [ 29s] checking for LIBOSMOGTLV... no [ 29s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met: [ 29s] [ 29s] Package 'libosmo-gtlv', required by 'virtual:world', not found [ 29s] [ 29s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 29s] installed software in a non-standard prefix. [ 29s] [ 29s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS [ 29s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config. [ 29s] See the pkg-config man page for more details. [ 29s] error: Bad exit status from /var/tmp/rpm-tmp.ocF7i6 (%build) [ 29s] [ 29s] RPM build errors: [ 29s] Bad exit status from /var/tmp/rpm-tmp.ocF7i6 (%build) [ 29s] ### VM INTERACTION START ### [ 29s] [ 24.225369][ T1] sysrq: Power Off [ 29s] [ 24.229217][ T18] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] sheep84 failed "build osmo-upf.spec" at Sun Aug 21 18:02:18 UTC 2022. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: Properly handle send() return code

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 ) Change subject: Properly handle send() return code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 Gerrit-Change-Number: 29178 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 17:58:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 8: Code-Review-1 (8 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/b4a12965_631453b6 PS8, Line 9: Limit length of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or This reads a bit weird. I suggest to reword this sentence a bit: "The length limit of optional Data parameter is 130 bytes according to ...". File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/71eac16a_a492bac8 PS8, Line 50: #include <osmocom/core/msgb.h> cosmetic: move it below to other imports from 'osmocom/core'. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/e492c454_2d79602b PS8, Line 603: xua_class_msg_name xua_class_msg_name() operates on a static buffer, so calling it more than once in a logging statement may result in printing the same value twice. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/6a245579_bbce0965 PS8, Line 613: lim IIUC, this value is always SCCP_MAX_DATA. Do we really need to accept it as an argument? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/dcfca9b6_4ef859a8 PS8, Line 623: xua_opt_data_cache_check When I see function names ending with _check, I expect them to do nothing else but check something and return some outcome. But here _check actually means populate the cache if necessary and return true if caching is not needed. This is confusing. I suggest to rename it to xua_opt_data_cache_populate() or so, and return true if the cache was populated. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/106453f9_f4b1f5a4 PS8, Line 650: static bool xua_opt_data_length_check(struct sccp_connection *conn, const struct osmo_scu_prim *prim, int msg_type) Again, this naming is really confusing. _opt_data_length_check implies that this function does check length of optional data and return an outcome. In reality this function not only does the length checks, but may also cache data or even Tx it by calling osmo_sccp_tx_data(). https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/ee25b20a_253a13c4 PS8, Line 659: break unreachable https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/937dacf4_df42e77a PS8, Line 1006: xua_opt_data_clear_cache IMO, this should be done in conn_destroy(). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 17:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by fixeria

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/a18d7184_e027049c PS1, Line 97: > unrelated cosmetic change to the indent level. […] I would expect it to be aligned to the opening brace, and it looks like you intended to do so. It might be that you're using non-standard tab-size=4, while in C projects it's 8. Please either undo this change, or properly align to the opening brace. File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/7777bfe9_52fc8336 PS2, Line 97: [DATA] You forgot to add documentation an optional parameter: # disconnect-req? disconnect-req N-DISCONNT.req # disconnect-req ? <0-16777216> Connection ID # disconnect-req 0 ? [DATA] NULL <!----------------------- https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/8b278161_3277aba5 PS2, Line 103: argv[1] Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I would rather rely on argc: const uint8_t *data = NULL; if (argc > 1) data = (const uint8_t *)argv[1]; Also, wouldn't it be more useful to accept a hex-string as the input? File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/a07ead1e_14649eeb PS2, Line 48: Really weird alignment making it rather harder to read. Tab-size should be 8. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 17:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: error if attempting to send exceedingly big data

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29168 ) Change subject: SIGTRAN: error if attempting to send exceedingly big data ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8a67bc40080eb1405ab3b0df874e3ea20941a850 Gerrit-Change-Number: 29168 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 16:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: don't advance FSM on failed connection request

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 ) Change subject: SIGTRAN: don't advance FSM on failed connection request ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c Gerrit-Change-Number: 29167 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 16:46:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022