August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 12: (2 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/c3633442_e7d22e25 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > > please declare 'int ret;' on a separate line […] I agree with Neels that doing "int a = ..., rc;" hides definition of rc. I find it harder to read than if it was on a separate line. If not a separate line, "int rc, a = ...;" is an acceptable solution too. Regarding ret vs rc - I don't care. File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/501d0b7f_b6c20a69 PS12, Line 459: osmo_sccp_conn_id_exists So this function basically converts the result of conn_find_by_id() to boolean. Not sure if it's really beneficial to add a new symbol, you could simply expose conn_find_by_id() and call it directly when you need to check connection existence. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 16:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Add basic readme for example code

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 ) Change subject: Add basic readme for example code ...................................................................... Add basic readme for example code Related: OS#5579 Change-Id: I4c76a48a76ca9afc960ea2f08229bacc79b6fe77 --- A examples/README 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/examples/README b/examples/README new file mode 100644 index 0000000..e2aeaff --- /dev/null +++ b/examples/README @@ -0,0 +1,21 @@ +This example code is handy in illustrating libosmo-sigtran library use as well as experimenting with SCCP protocol. + +Run it as follows: +Server: +./sccp_demo_user -d DLINP,5:DLSS7,5:DLSCCP,1:DSCCP,1:DMAIN,1 +Client: +./sccp_demo_user -d DLINP,5:DLSS7,5:DLSCCP,1:DSCCP,1:DMAIN,1 -c +Server's vty: +telnet 127.0.0.1 2324 +Client's vty: +telnet 127.0.0.2 2325 + +On the client side, after entering privileged mode by typing 'enable', you can switch to demo user mode with 'sccp-user' command. + +This gives several additional commands, for example: +'called-addr-ssn 202' - selecting "echo" application (201 is "refuser", 203 is "callback") +'connect-req 10 aaaaaaaaaaaaaaaaaaa' - sending N-CONNECT message with ID=12 and optional data + +See vty's help for further details. + +Calling 'show cs7 instance 0 sccp connections' in privileged mode on the server will show currently active SCCP connections. 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4c76a48a76ca9afc960ea2f08229bacc79b6fe77 Gerrit-Change-Number: 29169 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Add basic readme for example code

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 ) Change subject: Add basic readme for example code ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4c76a48a76ca9afc960ea2f08229bacc79b6fe77 Gerrit-Change-Number: 29169 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 16:10:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 15:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: [cosmetic] sccp_scoc.c: constify function parameters

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 ) Change subject: [cosmetic] sccp_scoc.c: constify function parameters ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/2c7feda3_51b7efd1 PS1, Line 7: cosmetic: constify function parameters, return proper error > the summary should indicate the scope ("sccp_scoc.c:... […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/b7b8ce1a_5a5bc755 PS1, Line 704: return -ENOMSG; > -ENOMEM would be the proper code here. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666 Gerrit-Change-Number: 29159 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 15:07:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: [cosmetic] sccp_scoc.c: constify function parameters

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 ) Change subject: [cosmetic] sccp_scoc.c: constify function parameters ...................................................................... [cosmetic] sccp_scoc.c: constify function parameters Related: OS#5579 Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666 --- M include/osmocom/sigtran/sccp_sap.h M src/sccp_sap.c M src/sccp_scoc.c 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h index 2b41fed..5624d33 100644 --- a/include/osmocom/sigtran/sccp_sap.h +++ b/include/osmocom/sigtran/sccp_sap.h @@ -273,7 +273,7 @@ #define msgb_scu_prim(msg) ((struct osmo_scu_prim *)(msg)->l1h) -char *osmo_scu_prim_name(struct osmo_prim_hdr *oph); +char *osmo_scu_prim_name(const struct osmo_prim_hdr *oph); struct osmo_ss7_instance; struct osmo_sccp_instance; diff --git a/src/sccp_sap.c b/src/sccp_sap.c index 7c9ce65..cdf0acc 100644 --- a/src/sccp_sap.c +++ b/src/sccp_sap.c @@ -43,7 +43,7 @@ static char prim_name_buf[128]; -char *osmo_scu_prim_name(struct osmo_prim_hdr *oph) +char *osmo_scu_prim_name(const struct osmo_prim_hdr *oph) { const char *name = get_value_string(osmo_scu_prim_names, oph->primitive); diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 5e2cbdd..c209bd7 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -572,7 +572,7 @@ /* generate a 'struct xua_msg' of requested type from connection + * primitive data */ static struct xua_msg *xua_gen_msg_co(struct sccp_connection *conn, uint32_t event, - struct osmo_scu_prim *prim, int msg_type) + const struct osmo_scu_prim *prim, int msg_type) { struct xua_msg *xua = xua_msg_alloc(); @@ -689,7 +689,7 @@ /* generate xua_msg, encode it and send it to SCRC */ static int xua_gen_encode_and_send(struct sccp_connection *conn, uint32_t event, - struct osmo_scu_prim *prim, int msg_type) + const struct osmo_scu_prim *prim, int msg_type) { struct xua_msg *xua; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666 Gerrit-Change-Number: 29159 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 to look at the new patch set (#2). Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... SIGTRAN: add osmo_sccp_tx_disconn_data() helper SCCP RLSD message might have up to 130 bytes of optional data according to ITU-T Rec Q.713 §4.5 - add helper which allows sending it and use it in example code. Related: OS#5579 Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c 3 files changed, 24 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/29170/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 2: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29082/comment/941a1ae6_ed7f56ca PS2, Line 1334: ret > Somehow I missed this. […] Indeed, although we also might set ret - see https://gerrit.osmocom.org/c/libosmo-netif/+/29178 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 14:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: Properly handle send() return code

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 ) Change subject: Properly handle send() return code ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 Gerrit-Change-Number: 29178 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 14:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: layer23: use $(top_srcdir) instead of relative paths

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29176 ) Change subject: layer23: use $(top_srcdir) instead of relative paths ...................................................................... layer23: use $(top_srcdir) instead of relative paths Change-Id: I320ed2295c0c8e12a46be416e3dbda8865987424 --- M src/host/layer23/src/misc/Makefile.am 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/76/29176/1 diff --git a/src/host/layer23/src/misc/Makefile.am b/src/host/layer23/src/misc/Makefile.am index 3d32592..4daaf91 100644 --- a/src/host/layer23/src/misc/Makefile.am +++ b/src/host/layer23/src/misc/Makefile.am @@ -32,31 +32,31 @@ $(NULL) bcch_scan_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_bcch_scan.c \ bcch_scan.c \ $(NULL) ccch_scan_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_ccch_scan.c \ rslms.c \ $(NULL) echo_test_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_echo_test.c \ $(NULL) cell_log_LDADD = $(LDADD) -lm cell_log_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_cell_log.c \ cell_log.c \ geo.c \ $(NULL) cbch_sniff_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_cbch_sniff.c \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I320ed2295c0c8e12a46be416e3dbda8865987424 Gerrit-Change-Number: 29176 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022