August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: bts_trx_vty: do not print nmstate of bb_trxc mo

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28895 ) Change subject: bts_trx_vty: do not print nmstate of bb_trxc mo ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28895/comment/a903b8cf_1936ee28 PS1, Line 743: if (!is_ericsson_bts(trx->bts)) { > Yes, but this is just a display issue and I think it would be nicer to not to display the BBTRANSC m […] Well taking into account that some osmo-cb generic parts expect the BBTRANSC MO to be in a certain state, I really think this should be displayed in order to be able to find out what's going on. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f5501f6fbc7ce6d5457676b16c7f93f70db5763 Gerrit-Change-Number: 28895 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 10:41:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: configure: fix warning: AC_OUTPUT should be used without arguments

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I71fc8dc78b8b10628ef0533c69e42c0298fb27df Gerrit-Change-Number: 28901 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 10:40:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: configure: fix AC_CONFIG_MACRO_DIRS related warnings

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 ) Change subject: configure: fix AC_CONFIG_MACRO_DIRS related warnings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9d605490c4b403b99ed54745838cc9f242030c3 Gerrit-Change-Number: 28900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 10:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: bts_trx_vty: do not print nmstate of bb_trxc mo

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28895 ) Change subject: bts_trx_vty: do not print nmstate of bb_trxc mo ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28895/comment/df83cbc3_c11fdc13 PS1, Line 743: if (!is_ericsson_bts(trx->bts)) { > Since you are implementing BBTRANSC for OM2000 in next patch, I don't see a reason to have this. […] Yes, but this is just a display issue and I think it would be nicer to not to display the BBTRANSC mo here. I will keep this patch in the patch set for a while. We can decide later if we abandon it or not. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f5501f6fbc7ce6d5457676b16c7f93f70db5763 Gerrit-Change-Number: 28895 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 08:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: configure: fix warning: AC_OUTPUT should be used without arguments

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... configure: fix warning: AC_OUTPUT should be used without arguments Change-Id: I71fc8dc78b8b10628ef0533c69e42c0298fb27df --- M configure.ac 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/01/28901/1 diff --git a/configure.ac b/configure.ac index 8d0ebb1..77cb672 100644 --- a/configure.ac +++ b/configure.ac @@ -85,7 +85,7 @@ dnl Generate the output AM_CONFIG_HEADER(config.h) -AC_OUTPUT( +AC_CONFIG_FILES([ libosmo-gtlv.pc libosmo-pfcp.pc include/Makefile @@ -104,4 +104,5 @@ doc/Makefile doc/charts/Makefile contrib/Makefile - Makefile) + Makefile]) +AC_OUTPUT -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I71fc8dc78b8b10628ef0533c69e42c0298fb27df Gerrit-Change-Number: 28901 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: configure: fix AC_CONFIG_MACRO_DIRS related warnings

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 ) Change subject: configure: fix AC_CONFIG_MACRO_DIRS related warnings ...................................................................... configure: fix AC_CONFIG_MACRO_DIRS related warnings Create m4/.gitkeep to eliminate the following warning: aclocal: warning: couldn't open directory 'm4': No such file or directory Add 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac to as suggested: libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac Change-Id: Id9d605490c4b403b99ed54745838cc9f242030c3 --- M configure.ac A m4/.gitkeep 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/00/28900/1 diff --git a/configure.ac b/configure.ac index 4391ff9..8d0ebb1 100644 --- a/configure.ac +++ b/configure.ac @@ -6,6 +6,7 @@ AC_CONFIG_AUX_DIR([.]) AM_INIT_AUTOMAKE([dist-bzip2]) +AC_CONFIG_MACRO_DIRS([m4]) AC_CONFIG_TESTDIR(tests) CFLAGS="$CFLAGS -std=gnu11" diff --git a/m4/.gitkeep b/m4/.gitkeep new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/m4/.gitkeep -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9d605490c4b403b99ed54745838cc9f242030c3 Gerrit-Change-Number: 28900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: test concurrent CBS message

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28899 ) Change subject: cbc: test concurrent CBS message ...................................................................... cbc: test concurrent CBS message Test having more than one active CBS message being broadcasted to an MME. Related: OS#4945 Change-Id: Ie9208c33f3b2586e19b446318b6ae9da07a76506 --- M cbc/CBC_Tests.ttcn 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/28899/1 diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index e4c6cda..fd88775 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -596,6 +596,63 @@ f_shutdown_helper(); } +/* Create 2 concurrent messages against an MME, then delete them */ +private function f_mme_TC_concurrent_cbs_msg_mme() runs on MME_ConnHdlr { + var CBS_Message msg[2]; + msg[0] := g_pars.exp_cbs_msg; + msg[1] := msg[0]; + msg[1].msg_id := msg[0].msg_id + 1; + + for (var integer i := 0; i < lengthof(msg); i := i + 1) { + f_sbcap_handle_write_replace_warn_req(msg[i], 0); + if (ispresent(g_pars.write_replace_warning_ind_cause) and + ispresent(g_pars.bcast_cell_id_list)) { + f_sbcap_tx_write_replace_warn_ind(0, msg[i], + g_pars.write_replace_warning_ind_cause, + g_pars.bcast_cell_id_list) + } + } + /* Now handle Stop: */ + for (var integer i := 0; i < lengthof(msg); i := i + 1) { + f_sbcap_handle_stop_warn_req(0, msg[i]); + } +} +testcase TC_concurrent_cbs_msg_mme() runs on test_CT { + var template (value) CellId_Broadcast_List bcast_cell_id_li; + var CBS_Message msg[2]; + var EcbeCbcMessage ecbe; + + msg[0] := valueof(t_CBSmsg(49, 16752)); + msg[1] := msg[0]; + msg[1].msg_id := msg[0].msg_id + 1; + + f_init(num_bsc := 0, num_mme := 1); + + bcast_cell_id_li := { + ts_SBCAP_CellId_Broadcast_List_Item(ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 1234)) + }; + g_pars_MME[0].start_fn := refers(f_mme_TC_concurrent_cbs_msg_mme); + g_pars_MME[0].exp_cbs_msg := msg[0]; + g_pars_MME[0].write_replace_warning_ind_cause := SBC_AP_Cause_message_accepted; + g_pars_MME[0].bcast_cell_id_list := valueof(bcast_cell_id_li); + f_start(); + + for (var integer i := 0; i < lengthof(msg); i := i + 1) { + ecbe := f_cbs2ecbe(msg[i], "TTCN-3"); + f_ecbe_tx_post_cbs(ecbe); + f_ecbe_rx_resp(201); + } + + f_sleep(2.0); + + for (var integer i := 0; i < lengthof(msg); i := i + 1) { + f_ecbe_tx_delete_cbs(msg[i].msg_id); + f_ecbe_rx_resp(200); + } + + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -609,6 +666,7 @@ execute( TC_ecbe_create_delete_bsc_and_mme() ); execute( TC_ecbe_create_delete_bsc_server() ); execute( TC_ecbe_create_delete_mme_server() ); + execute( TC_concurrent_cbs_msg_mme() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9208c33f3b2586e19b446318b6ae9da07a76506 Gerrit-Change-Number: 28899 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: fix missing signal

by fixeria

Attention is currently required from: neels, laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28838 ) Change subject: abis_om2000: fix missing signal ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I305df5b2f962473e33e32484c42a79ff96e53e1a Gerrit-Change-Number: 28838 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Aug 2022 16:29:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Expect Concurrent-Warning-Message-Indicator IE in SBcAP Write-Re...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28898 ) Change subject: cbc: Expect Concurrent-Warning-Message-Indicator IE in SBcAP Write-Repl-Req ...................................................................... cbc: Expect Concurrent-Warning-Message-Indicator IE in SBcAP Write-Repl-Req 3GPP TS 23.041 9.3.32 states that the IE is always present for non-ETWS messages and never present in ETWS messages. The present template is used for CBS messages (non-ETWS) only so far. Once we add support to test ETWS message this will be updated accordingly if needed. Related: osmo-cbc.git I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef Related: OS#4945 Change-Id: I8f2067069ecf0c46f86279413a10e5970ec4456c --- M library/sbcap/SBC_AP_Templates.ttcn 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/28898/1 diff --git a/library/sbcap/SBC_AP_Templates.ttcn b/library/sbcap/SBC_AP_Templates.ttcn index 37a8a51..e51c44d 100644 --- a/library/sbcap/SBC_AP_Templates.ttcn +++ b/library/sbcap/SBC_AP_Templates.ttcn @@ -159,7 +159,8 @@ template (present) uint16_t p_num_bcast, template (present) BIT8 dcs := ?, template (present) octetstring p_msg_content := ?, - template (present) Send_Write_Replace_Warning_Indication send_ind := ? + template (present) Send_Write_Replace_Warning_Indication send_ind := ?, + template (present) Concurrent_Warning_Message_Indicator concurrent_ind := ? ) := { initiatingMessage := { procedureCode := id_Write_Replace_Warning, @@ -206,6 +207,10 @@ /* OMC ID */ /* Concurrent Warning Message Indicator */ }, { + id := SBC_AP_Constants.id_Concurrent_Warning_Message_Indicator, + criticality := reject, + value_ := { Concurrent_Warning_Message_Indicator := concurrent_ind } + }, { id := SBC_AP_Constants.id_Send_Write_Replace_Warning_Indication, criticality := ignore, value_ := { Send_Write_Replace_Warning_Indication := send_ind } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8f2067069ecf0c46f86279413a10e5970ec4456c Gerrit-Change-Number: 28898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28897 ) Change subject: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req ...................................................................... sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req 3GPP TS 23.041 9.3.32 states that the IE is always present for non-ETWS messages and never present in ETWS messages. Related: OS#4945 Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef --- M src/sbcap_msg.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/97/28897/1 diff --git a/src/sbcap_msg.c b/src/sbcap_msg.c index 1c0e768..f9fa70a 100644 --- a/src/sbcap_msg.c +++ b/src/sbcap_msg.c @@ -223,6 +223,14 @@ ptr++; } ASN_SEQUENCE_ADD(as_pdu, ie); + + /* Concurrent Warning Message Indicator + * 3GPP TS 36.413 8.12.1.2 and 9.2.1.72, 3GPP TS 23.041 9.3.32 + * static const long asn_VAL_13_SBcAP_id_Concurrent_Warning_Message_Indicator = 20; */ + ie = sbcap_alloc_Write_Replace_Warning_Request_IE(20, SBcAP_Criticality_reject, + SBcAP_Write_Replace_Warning_Request_IEs__value_PR_Concurrent_Warning_Message_Indicator); + ie->value.choice.Concurrent_Warning_Message_Indicator = SBcAP_Concurrent_Warning_Message_Indicator_true; + ASN_SEQUENCE_ADD(as_pdu, ie); } /* Send Write-Replace-Warning-Indication -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef Gerrit-Change-Number: 28897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022