pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28911 )
Change subject: WIP: TODO
......................................................................
WIP: TODO
Change-Id: Ibecc128677d25f7d19a47f8a8a8a80a62b3c707a
---
M cbc/CBC_Tests.ttcn
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/28911/1
diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn
index fd88775..267290b 100644
--- a/cbc/CBC_Tests.ttcn
+++ b/cbc/CBC_Tests.ttcn
@@ -669,4 +669,14 @@
execute( TC_concurrent_cbs_msg_mme() );
}
+/* TODO:
+ * + Test CBC resends active message upon cell failure:
+ * 1- Set a state with an ongoing CBS message in the MME
+ * 2- MME sends Failure Report Indication (cell is down)
+ * 3- MME sends Restart indication (cell is up and ready again)
+ * 4- CBC should then re-send a Write-Replace for that cell (setting cell list to that one only?)
+ *
+ * + Test ETWS message, only CBS tested so far. Look at TS 23.041 9.4.1.2.2
+ */
+
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibecc128677d25f7d19a47f8a8a8a80a62b3c707a
Gerrit-Change-Number: 28911
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28895 )
Change subject: bts_trx_vty: do not print nmstate of bb_trxc mo
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28895/comment/abdb34e4_c73976b7
PS1, Line 743: if (!is_ericsson_bts(trx->bts)) {
> osmo-bsc*
you could prefix it with [Virtual] or [Emulated] in the OM2K case.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28895
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0f5501f6fbc7ce6d5457676b16c7f93f70db5763
Gerrit-Change-Number: 28895
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Aug 2022 15:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28838 )
Change subject: abis_om2000: fix missing signal
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28838/comment/54496ba5_3b90fdf6
PS2, Line 51: abis_om2000_fsm_becomes_enabled
it's a bit odd that the function name looks generic, but then in reality it is very specific to the trx/radio_carrier.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28838
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I305df5b2f962473e33e32484c42a79ff96e53e1a
Gerrit-Change-Number: 28838
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Aug 2022 15:36:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28899 )
Change subject: cbc: test concurrent CBS message
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28899
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9208c33f3b2586e19b446318b6ae9da07a76506
Gerrit-Change-Number: 28899
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Aug 2022 15:35:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893 )
Change subject: cbc: Test sneding Unknwon TAI List to osmo-cbc
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893/comment/9d8968e8_29cd…
PS2, Line 7: sneding Unknwon
you appear to be competing against me in terms of typo density here... both words :)
Patchset:
PS2:
looks good except for the typos. At least for the TC_... we should avoid introducing it first and fixing it later, as that would mess up the jenkins test analyzer display
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893/comment/585dae97_80b3…
PS2, Line 505: unknwon
even here this unkn-won, must be some ancient korean unit of currency :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7d8cf5e6498d03ad340b8f843ce93a20171e9fca
Gerrit-Change-Number: 28893
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Aug 2022 15:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment