August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-tetra[master]: keep track of which block of a downlink burst is being processed

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28891 ) Change subject: keep track of which block of a downlink burst is being processed ...................................................................... keep track of which block of a downlink burst is being processed tp_sap_udata_ind now accepts a parameter designating from which block (first or second) of the downlink burst the bits originate (not applicable for all downlink burst types). In some cases, the upper mac needs this information, see ETSI EN 300 392-7 clause 6.4.1 Change-Id: I5ff316a773906328e19c3530b09d7412f9c731ec --- M src/conv_enc_test.c M src/lower_mac/tetra_lower_mac.c M src/phy/tetra_burst.c M src/phy/tetra_burst.h M src/tetra_prim.h 5 files changed, 19 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/conv_enc_test.c b/src/conv_enc_test.c index aa921fa..c5924ce 100644 --- a/src/conv_enc_test.c +++ b/src/conv_enc_test.c @@ -45,7 +45,7 @@ static unsigned int num_crc_err; /* incoming TP-SAP UNITDATA.ind from PHY into lower MAC */ -void tp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t *bits, unsigned int len, void *priv) +void tp_sap_udata_ind(enum tp_sap_data_type type, int blk_num, const uint8_t *bits, unsigned int len, void *priv) { } diff --git a/src/lower_mac/tetra_lower_mac.c b/src/lower_mac/tetra_lower_mac.c index d6f9e41..ca1b72e 100644 --- a/src/lower_mac/tetra_lower_mac.c +++ b/src/lower_mac/tetra_lower_mac.c @@ -53,7 +53,7 @@ static const struct tetra_blk_param tetra_blk_param[] = { [TPSAP_T_SB1] = { .name = "SB1", - .type345_bits = 120, + .type345_bits = 120, .type2_bits = 80, .type1_bits = 60, .interleave_a = 11, @@ -138,7 +138,7 @@ } /* incoming TP-SAP UNITDATA.ind from PHY into lower MAC */ -void tp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t *bits, unsigned int len, void *priv) +void tp_sap_udata_ind(enum tp_sap_data_type type, int blk_num, const uint8_t *bits, unsigned int len, void *priv) { /* various intermediary buffers */ uint8_t type4[512]; @@ -216,7 +216,6 @@ /* Write it */ fwrite(block, sizeof(int16_t), 690, f); - fclose(f); /* Write used ssi */ @@ -260,6 +259,9 @@ osmo_ubit_dump(type2, tbp->type1_bits)); } + /* Set whether BLK1 or BLK2 in downlink burst (or 0 if not applicable) */ + tup->blk_num = blk_num; + msg->l1h = msgb_put(msg, tbp->type1_bits); memcpy(msg->l1h, type2, tbp->type1_bits); diff --git a/src/phy/tetra_burst.c b/src/phy/tetra_burst.c index c791ee0..80a438a 100644 --- a/src/phy/tetra_burst.c +++ b/src/phy/tetra_burst.c @@ -347,18 +347,18 @@ case TETRA_TRAIN_SYNC: /* Split SB1, SB2 and Broadcast Block */ /* send three parts of the burst via TP-SAP into lower MAC */ - tp_sap_udata_ind(TPSAP_T_SB1, burst+SB_BLK1_OFFSET, SB_BLK1_BITS, priv); - tp_sap_udata_ind(TPSAP_T_BBK, burst+SB_BBK_OFFSET, SB_BBK_BITS, priv); - tp_sap_udata_ind(TPSAP_T_SB2, burst+SB_BLK2_OFFSET, SB_BLK2_BITS, priv); + tp_sap_udata_ind(TPSAP_T_SB1, BLK_1, burst+SB_BLK1_OFFSET, SB_BLK1_BITS, priv); + tp_sap_udata_ind(TPSAP_T_BBK, 0, burst+SB_BBK_OFFSET, SB_BBK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_SB2, BLK_2, burst+SB_BLK2_OFFSET, SB_BLK2_BITS, priv); break; case TETRA_TRAIN_NORM_2: /* re-combine the broadcast block */ memcpy(bbk_buf, burst+NDB_BBK1_OFFSET, NDB_BBK1_BITS); memcpy(bbk_buf+NDB_BBK1_BITS, burst+NDB_BBK2_OFFSET, NDB_BBK2_BITS); /* send three parts of the burst via TP-SAP into lower MAC */ - tp_sap_udata_ind(TPSAP_T_BBK, bbk_buf, NDB_BBK_BITS, priv); - tp_sap_udata_ind(TPSAP_T_NDB, burst+NDB_BLK1_OFFSET, NDB_BLK_BITS, priv); - tp_sap_udata_ind(TPSAP_T_NDB, burst+NDB_BLK2_OFFSET, NDB_BLK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_BBK, 0, bbk_buf, NDB_BBK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_NDB, BLK_1, burst+NDB_BLK1_OFFSET, NDB_BLK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_NDB, BLK_2, burst+NDB_BLK2_OFFSET, NDB_BLK_BITS, priv); break; case TETRA_TRAIN_NORM_1: /* re-combine the broadcast block */ @@ -368,8 +368,8 @@ memcpy(ndbf_buf, burst+NDB_BLK1_OFFSET, NDB_BLK_BITS); memcpy(ndbf_buf+NDB_BLK_BITS, burst+NDB_BLK2_OFFSET, NDB_BLK_BITS); /* send two parts of the burst via TP-SAP into lower MAC */ - tp_sap_udata_ind(TPSAP_T_BBK, bbk_buf, NDB_BBK_BITS, priv); - tp_sap_udata_ind(TPSAP_T_SCH_F, ndbf_buf, 2*NDB_BLK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_BBK, 0, bbk_buf, NDB_BBK_BITS, priv); + tp_sap_udata_ind(TPSAP_T_SCH_F, 0, ndbf_buf, 2*NDB_BLK_BITS, priv); break; case TETRA_TRAIN_NORM_3: case TETRA_TRAIN_EXT: diff --git a/src/phy/tetra_burst.h b/src/phy/tetra_burst.h index 8feb09c..0230c88 100644 --- a/src/phy/tetra_burst.h +++ b/src/phy/tetra_burst.h @@ -3,6 +3,9 @@ #include <stdint.h> +#define BLK_1 1 +#define BLK_2 2 + enum tp_sap_data_type { TPSAP_T_SB1, TPSAP_T_SB2, @@ -12,7 +15,7 @@ TPSAP_T_SCH_F, }; -extern void tp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t *bits, unsigned int len, void *priv); +extern void tp_sap_udata_ind(enum tp_sap_data_type type, int blk_num, const uint8_t *bits, unsigned int len, void *priv); /* 9.4.4.2.6 Synchronization continuous downlink burst */ int build_sync_c_d_burst(uint8_t *buf, const uint8_t *sb, const uint8_t *bb, const uint8_t *bkn); diff --git a/src/tetra_prim.h b/src/tetra_prim.h index 8913187..918abd7 100644 --- a/src/tetra_prim.h +++ b/src/tetra_prim.h @@ -28,6 +28,7 @@ int crc_ok; /* was the CRC verified OK? */ uint32_t scrambling_code; /* which scrambling code was used */ struct tetra_tdma_time tdma_time;/* TDMA timestamp */ + int blk_num; /* Indicates whether BLK1 or BLK2 in the downlink burst */ //uint8_t mac_block[412]; /* maximum num of bits in a non-QAM chan */ }; -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I5ff316a773906328e19c3530b09d7412f9c731ec Gerrit-Change-Number: 28891 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: moved variable declaration to prevent compiler warnings

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28597 ) Change subject: moved variable declaration to prevent compiler warnings ...................................................................... moved variable declaration to prevent compiler warnings Change-Id: If9a83589b220ae7d937ef75c79de57be11858cd1 --- M src/conv_enc_test.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/conv_enc_test.c b/src/conv_enc_test.c index 166cebc..aa921fa 100644 --- a/src/conv_enc_test.c +++ b/src/conv_enc_test.c @@ -306,8 +306,7 @@ int main(int argc, char **argv) { - int err, i; - uint16_t out; + int i; uint32_t ret; /* first: run some subsystem tests */ @@ -317,6 +316,8 @@ tetra_rm3014_init(); #if 0 + int err; + uint16_t out; ret = tetra_rm3014_compute(0x1001); printf("RM3014: 0x%08x\n", ret); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If9a83589b220ae7d937ef75c79de57be11858cd1 Gerrit-Change-Number: 28597 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Improved parsing in macpdu_decode_resource

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28850 ) Change subject: Improved parsing in macpdu_decode_resource ...................................................................... Improved parsing in macpdu_decode_resource fill_bits and grant_position bits are now parsed and stored in the tetra_resrc_decoded struct A flag is_encrypted is set to to true if resource was not encrypted or if the calling function states that the frame has been decrypted successfully before passing it to tetra_resrc_decoded. Lastly, the channel_alloc element is only parsed if the frame is unencrypted. Change-Id: I6c85c93b70a34e01fd1a96a863f0e113be6424d3 --- M src/tetra_mac_pdu.c M src/tetra_mac_pdu.h M src/tetra_upper_mac.c 3 files changed, 17 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/tetra_mac_pdu.c b/src/tetra_mac_pdu.c index b395b7c..d114703 100644 --- a/src/tetra_mac_pdu.c +++ b/src/tetra_mac_pdu.c @@ -91,7 +91,7 @@ }; /* 21.5.2 */ -static int decode_chan_alloc(struct tetra_chan_alloc_decoded *cad, const uint8_t *bits) +static int macpdu_decode_chan_alloc(struct tetra_chan_alloc_decoded *cad, const uint8_t *bits) { const uint8_t *cur = bits; @@ -182,12 +182,15 @@ return -EINVAL; } -/* Section 21.4.3.1 MAC-RESOURCE */ -int macpdu_decode_resource(struct tetra_resrc_decoded *rsd, const uint8_t *bits) -{ - const uint8_t *cur = bits + 4; +/* Section 21.4.3.1 MAC-RESOURCE */ +int macpdu_decode_resource(struct tetra_resrc_decoded *rsd, const uint8_t *bits, uint8_t is_decrypted) +{ + const uint8_t *cur = bits + 2; + rsd->fill_bits = bits_to_uint(cur, 1); cur += 1; + rsd->grant_position = bits_to_uint(cur, 1); cur += 1; rsd->encryption_mode = bits_to_uint(cur, 2); cur += 2; + rsd->is_encrypted = rsd->encryption_mode > 0 && !is_decrypted; rsd->rand_acc_flag = *cur++; rsd->macpdu_length = decode_length(bits_to_uint(cur, 6)); cur += 6; rsd->addr.type = bits_to_uint(cur, 3); cur += 3; @@ -239,10 +242,10 @@ #endif } rsd->chan_alloc_pres = *cur++; - /* FIXME: If encryption is enabled, Channel Allocation is encrypted !!! */ - if (rsd->chan_alloc_pres) - cur += decode_chan_alloc(&rsd->cad, cur); - /* FIXME: TM-SDU */ + + if (rsd->chan_alloc_pres && !rsd->is_encrypted) + // We can only determine length if the frame is unencrypted + cur += macpdu_decode_chan_alloc(&rsd->cad, cur); return cur - bits; } diff --git a/src/tetra_mac_pdu.h b/src/tetra_mac_pdu.h index 051e47a..d243062 100644 --- a/src/tetra_mac_pdu.h +++ b/src/tetra_mac_pdu.h @@ -213,7 +213,10 @@ }; struct tetra_resrc_decoded { + uint8_t fill_bits; + uint8_t grant_position; uint8_t encryption_mode; + uint8_t is_encrypted; // Set to 0 if not encrypted or decrypted successfully uint8_t rand_acc_flag; int macpdu_length; struct tetra_addr addr; @@ -229,7 +232,7 @@ uint8_t chan_alloc_pres; struct tetra_chan_alloc_decoded cad; }; -int macpdu_decode_resource(struct tetra_resrc_decoded *rsd, const uint8_t *bits); +int macpdu_decode_resource(struct tetra_resrc_decoded *rsd, const uint8_t *bits, uint8_t is_decrypted); const char *tetra_addr_dump(const struct tetra_addr *addr); diff --git a/src/tetra_upper_mac.c b/src/tetra_upper_mac.c index a4c7e59..0e090cf 100644 --- a/src/tetra_upper_mac.c +++ b/src/tetra_upper_mac.c @@ -157,7 +157,7 @@ int tmpdu_offset; memset(&rsd, 0, sizeof(rsd)); - tmpdu_offset = macpdu_decode_resource(&rsd, msg->l1h); + tmpdu_offset = macpdu_decode_resource(&rsd, msg->l1h, 0); msg->l2h = msg->l1h + tmpdu_offset; printf("RESOURCE Encr=%u, Length=%d Addr=%s ", -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6c85c93b70a34e01fd1a96a863f0e113be6424d3 Gerrit-Change-Number: 28850 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: fixed out of bounds write to pdu_sync buffer

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28596 ) Change subject: fixed out of bounds write to pdu_sync buffer ...................................................................... fixed out of bounds write to pdu_sync buffer Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb --- M src/conv_enc_test.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/conv_enc_test.c b/src/conv_enc_test.c index 303ef31..166cebc 100644 --- a/src/conv_enc_test.c +++ b/src/conv_enc_test.c @@ -335,12 +335,12 @@ srand(time(NULL)); for (i = 0; i < 100; i++) { uint32_t r = rand(); - osmo_pbit2ubit(pdu_sync, (uint8_t *) &r, 32); - osmo_pbit2ubit(pdu_sync+32, (uint8_t *)&r, 60-32); + osmo_store32le(r, pdu_sync); + osmo_store32le(r, pdu_sync + 4); //build_sb(); - osmo_pbit2ubit(pdu_schf, (uint8_t *) &r, 32); - osmo_pbit2ubit(pdu_schf+32, (uint8_t *)&r, 60-32); + osmo_store32le(r, pdu_schf); + osmo_store32le(r, pdu_schf + 4); build_ndb_schf(); } #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb Gerrit-Change-Number: 28596 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: keep track of which block of a downlink burst is being processed

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28891 ) Change subject: keep track of which block of a downlink burst is being processed ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/28891/comment/deeb5cb6_d227794a PS1, Line 56: .type345_bits = 120, unrelated whitespace change, but let's not argue about it. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I5ff316a773906328e19c3530b09d7412f9c731ec Gerrit-Change-Number: 28891 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Added basic link FCS validation in LLC

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28851 ) Change subject: Added basic link FCS validation in LLC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I81941110801d00ca06bdafdcc0a7afaf7b7617d3 Gerrit-Change-Number: 28851 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:51:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: update_op_state() does not send signal

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28915 ) Change subject: abis_om2000: update_op_state() does not send signal ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: +1 once you fix the compiling issues. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id19c6beb2bc79c4db0ec07ef593aacb57fff8b75 Gerrit-Change-Number: 28915 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Improved parsing in macpdu_decode_resource

by laforge

Attention is currently required from: wbokslag, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28850 ) Change subject: Improved parsing in macpdu_decode_resource ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6c85c93b70a34e01fd1a96a863f0e113be6424d3 Gerrit-Change-Number: 28850 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: jobs/ttcn3: add debian nightly + asan jobs

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28909 ) Change subject: jobs/ttcn3: add debian nightly + asan jobs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not entirely sure we should really run all of our test suites for both asan and non-asan builds. Looks like a lot of overhead, doubling the load on the slaves. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7a0b3f57607ac1e25d98d2fe3d611476c71d7cf7 Gerrit-Change-Number: 28909 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: fix missing signal

by pespin

Attention is currently required from: neels, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28838 ) Change subject: abis_om2000: fix missing signal ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28838/comment/152296fa_db9478e8 PS2, Line 51: abis_om2000_fsm_becomes_enabled > I have oriented myself on the naming scheme I found in nm_rcarrier_fsm.c and nm_bb_transc_fsm.c. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I305df5b2f962473e33e32484c42a79ff96e53e1a Gerrit-Change-Number: 28838 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:49:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022