Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043 )
Change subject: gtlv: test repeated IEIs to several struct members
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I994d0fb1f1435d2c27a8630a43fe106652ac6e41
Gerrit-Change-Number: 29043
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:57:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29029 )
Change subject: osmux.h: Define default Osmux port
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/netif/osmux.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/29029/comment/547c45c1_883a5100
PS1, Line 16: #define OSMUX_DEFAULT_PORT 1984
might make sense to add it to https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers and add a link from herre to it, as well as to the manuals section which contains all our port numbers.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
Gerrit-Change-Number: 29029
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042 )
Change subject: gtlv: fix repeated IEIs to several struct members
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
+1 when you fix linter.
BTW, in case it's of use, I also did some fixes in open5gs tlv parser for repeated IEs and used a temporary stack-based rbtree:
https://github.com/open5gs/open5gs/pull/1351/commits/1a518bff735b6c34639df4…
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie37585178ff27306d425b75d8e407b71f92f1cdc
Gerrit-Change-Number: 29042
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment