August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29028 ) Change subject: osmux.h: Add missing msgb.h header ...................................................................... Patch Set 1: (1 comment) File include/osmocom/netif/osmux.h: https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/2461fffa_2d9312ba PS1, Line 6: #include <osmocom/core/msgb.h> > I don't like adding forward declarations of structs coming from other libraries. […] I see other [lib]osmo* projects having a forward declaration of 'struct msgb' in some header files. This reduces compile time. I do not insist, but I would still prefer this approach. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f Gerrit-Change-Number: 29028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 14:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29028 ) Change subject: osmux.h: Add missing msgb.h header ...................................................................... Patch Set 1: (1 comment) File include/osmocom/netif/osmux.h: https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/a6b4afa6_f4043158 PS1, Line 6: #include <osmocom/core/msgb.h> > adding a forward declaration of 'struct msgb' would have been enough. I don't like adding forward declarations of structs coming from other libraries. I don't think it's the right thing to do. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f Gerrit-Change-Number: 29028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29032 to look at the new patch set (#2). Change subject: Split out lchan rtp socket creation from rsl handling code ...................................................................... Split out lchan rtp socket creation from rsl handling code This makes the code more clear, as well as allows adding Osmux in the future. Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f --- M include/osmo-bts/lchan.h M src/common/lchan.c M src/common/rsl.c 3 files changed, 143 insertions(+), 113 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/29032/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f Gerrit-Change-Number: 29032 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29031 ) Change subject: Clean up osmo-bts-*/Makefile.am ...................................................................... Patch Set 5: (1 comment) File src/osmo-bts-trx/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/e920be35_5285b08e PS5, Line 15: $(LIBOSMOABIS_CFLAGS) \ > I'm putting all libosmocore.git ones together, then the libosmoabis ones. Ok, fine with me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b Gerrit-Change-Number: 29031 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:58:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29031 ) Change subject: Clean up osmo-bts-*/Makefile.am ...................................................................... Patch Set 5: (1 comment) File src/osmo-bts-trx/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/82b999b5_65a74c55 PS5, Line 15: $(LIBOSMOABIS_CFLAGS) \ > Why changing the order? I'm putting all libosmocore.git ones together, then the libosmoabis ones. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b Gerrit-Change-Number: 29031 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:57:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29029 ) Change subject: osmux.h: Define default Osmux port ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd Gerrit-Change-Number: 29029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:55:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29028 ) Change subject: osmux.h: Add missing msgb.h header ...................................................................... Patch Set 1: (1 comment) File include/osmocom/netif/osmux.h: https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/6eada0cb_d28e688a PS1, Line 6: #include <osmocom/core/msgb.h> adding a forward declaration of 'struct msgb' would have been enough. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f Gerrit-Change-Number: 29028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:54:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29032 ) Change subject: Split out lchan rtp socket creation from rsl handling code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f Gerrit-Change-Number: 29032 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:45:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29031 ) Change subject: Clean up osmo-bts-*/Makefile.am ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/osmo-bts-trx/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/46673582_d8c0a122 PS5, Line 15: $(LIBOSMOABIS_CFLAGS) \ Why changing the order? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b Gerrit-Change-Number: 29031 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:43:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bts[master]: logging: Move category descriptions to be in order with enum

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29030 ) Change subject: logging: Move category descriptions to be in order with enum ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450 Gerrit-Change-Number: 29030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 13:33:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022